Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C0D6C43219 for ; Thu, 24 Nov 2022 21:33:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8A2028563C; Thu, 24 Nov 2022 22:33:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="aDHX62RM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7AA7D85635; Thu, 24 Nov 2022 22:33:18 +0100 (CET) Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5EA4F85632 for ; Thu, 24 Nov 2022 22:33:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-wr1-x42d.google.com with SMTP id s5so4194907wru.1 for ; Thu, 24 Nov 2022 13:33:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=q5R0Zk88N3MPOX2ykpwPTxg+I/QZzfMSkcJlOQ/36fQ=; b=aDHX62RMoN7kR47muJlFfb+J4VVhKGMoeLcCt0TFnBLYLR3wID6iQ6I/aYpeYUsUYn mIHVZAacDvuJKh3RWrn2pvTuSeNLa/mwVrL0Fnl0tIqBvkGxqaZjVDLt//XOh/Ab9+fk Vx3dCy1S+PGz1Jbce+qqdsljT4B8W48WLWii0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q5R0Zk88N3MPOX2ykpwPTxg+I/QZzfMSkcJlOQ/36fQ=; b=0i+ufKd8JM/itPTpgONZ+XyIDC2wABWFKLhAso7zKTQV0AMXGotZTjIcA1DVBZ1/1k B3Pabcu+Sm3uZHnxrbyOVa3lZzf0nd8ufknUEXaVp1ga1Q/bMpOfXfMuIdyLcnQX0BMG 7sKwVHaA3bCp4pjD31ZJxFtPxftlQjGvAYu4jUiGxPvkuCp3Ijx0sTTFy5tsImO/WXuV hbeGwW36+ZMe1UUXcv6mh6m1+xFvm3R3Vun/0eNcAvlIzObE8llCf+7oDfRVwneUn6un t89ZXECIsfP02iH9xGhocVPOdXdAkhUvnmu+9OD7SiK/mT+FCR7uWZMyKvIpweUD3xnO nWFg== X-Gm-Message-State: ANoB5pkF8+X4xhsbOT6HVdesO8mnV6rxySfBZE6FCnORUsqWKWkVId9w tdcyJyZDn6k/bYoHOQYegi4AiQ== X-Google-Smtp-Source: AA0mqf4JTF+/XC3nUZtOhAa13fvyylJK7XXJml2yWC3AFLXirH92ibg5zBXBMuti1UFs1v9w+tdZwQ== X-Received: by 2002:a5d:6602:0:b0:236:651d:60cb with SMTP id n2-20020a5d6602000000b00236651d60cbmr11639081wru.474.1669325596131; Thu, 24 Nov 2022 13:33:16 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0c0d-8cfa-55df-646e.res6.spectrum.com. [2603:6081:7b00:6400:c0d:8cfa:55df:646e]) by smtp.gmail.com with ESMTPSA id x8-20020a5d6508000000b0022eafed36ebsm2179531wru.73.2022.11.24.13.33.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Nov 2022 13:33:15 -0800 (PST) Date: Thu, 24 Nov 2022 16:33:12 -0500 From: Tom Rini To: Dylan Hung Cc: ryan_chen@aspeedtech.com, chiawei_wang@aspeedtech.com, joel@jms.id.au, u-boot@lists.denx.de, BMC-SW@aspeedtech.com Subject: Re: [PATCH 2/3] ram: ast2600: Improve ddr4 timing and signal quality Message-ID: <20221124213312.GI3787616@bill-the-cat> References: <20221111073008.16364-1-dylan_hung@aspeedtech.com> <20221111073008.16364-3-dylan_hung@aspeedtech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3eH4Qcq5fItR5cpy" Content-Disposition: inline In-Reply-To: <20221111073008.16364-3-dylan_hung@aspeedtech.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --3eH4Qcq5fItR5cpy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 11, 2022 at 03:30:07PM +0800, Dylan Hung wrote: > Adjust the following settings to get better timing and signal quality. >=20 > 1. write DQS/DQ delay > - 1e6e2304[0] > - 1e6e2304[15:8] >=20 > 2. read DQS/DQ delay > - 0x1e6e0298[0] > - 0x1e6e0298[15:8] >=20 > 3. CLK/CA timing > - 0x1e6e01a8[31] >=20 > 4. Read and write termination > - change RTT_ROM from 40 ohm to 48 ohm (MR1[10:8]) > - change RTT_PARK from disable to 48 ohm (MR5[8:6]) > - change RTT_WR from 120 ohm to disable (MR2[11:9]) > - change PHY ODT from 40 ohm to 80 ohm (0x1e6e0130[10:8]) >=20 > Note1: Both DDR-PHY and DDR controller have their own registers for DDR4 > Mode Registers (MR0~MR6). This patch introduces macros to synchronize > the MR value on both sides. >=20 > Note2: the waveform meansurement can be found in item #21 of Aspeed > AST26x0 Application note (AP note). >=20 > Signed-off-by: Dylan Hung Applied to u-boot/master, thanks! --=20 Tom --3eH4Qcq5fItR5cpy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmN/4xgACgkQFHw5/5Y0 tyxrDgv+JkWaKYUdxB9nhgFGC/Tb/3y3UM3qsUGMzzW+n45aZZP5pB2di/3q5RXd sORrK02Qw+cNJmvUetJZx1yX1AjDLgFB1NfKGj1G0+iqv4HiWIgoaK5xC1lxhE5V 1Ts9GK1dTGloLmVfyDEKnlPuGWvRCSOvmsm/M3PUqb4Xzl2FCbIQwLhYsdmvOcmE ygQrP/6OrTtsW20F15rBzaFM01AnXA4Xi1x2EncKygIdaeLZhn7BYd5gbcLAWywC NYCCk2jIvZToEXGotlpvewBB2jFkDTppsrB368x6CB9CmWtn+ASz98/9VbrjaIuj X7il0dmMfPzUY8V+sKFmrat+P5tF1hp99niIggAGcVqmP06WV7bWDskEDSkmyHcy bBjilPzu3KuP5XSN95edj7U9LGd9xF6gTyh3vKAbAdXex4Dw1pr9zx1lgYzLrPcg vV6bWDHzhCad1oDxJqy7dpo+sXoSnCR0VQBf5qNQvpGp8H0FTcL05TzchyyGN6AD ZAe805Zu =f6y4 -----END PGP SIGNATURE----- --3eH4Qcq5fItR5cpy--