Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26303C4167B for ; Tue, 29 Nov 2022 16:18:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 77EFF83A26; Tue, 29 Nov 2022 17:18:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="BVC4ognF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CBF7385205; Tue, 29 Nov 2022 17:18:05 +0100 (CET) Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A087182162 for ; Tue, 29 Nov 2022 17:18:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-ej1-x631.google.com with SMTP id e27so35010804ejc.12 for ; Tue, 29 Nov 2022 08:18:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=w15Q15C5Qf6tsRtMZdVNMB1WbNQv4yhHEZJII+bQmws=; b=BVC4ognFtjxglR8WEzDMhZaJpuFRXyUCfNXMen6j77jlB5fJy6R8Da/hCUWlMeXefM rm+S3J7hO8nj9Z802pm/jKDO0io1YWIXZof9PKPPDnQP4oRaY67+hOqErqsKwwebOwGw T4U6p/aERKALp6AlBuUuxR++/5YTN1amp+omE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=w15Q15C5Qf6tsRtMZdVNMB1WbNQv4yhHEZJII+bQmws=; b=pec3DVNfxx4kgK07r3YERu6kfvfOL90uZ7LLu9kJ20ZlgXxKSGCvtaTnFbqkD93FsA MofNOot15QXbYgL2tK/mXSEZnE+OFvkWA/wPgE0KF/qt4OVtI1WVGKNPM6DdwUtTn+TQ Gwqe8k9OCbVWhgPqviEK7VXc23nDn2KUWLDHoGzUDjMeogWGb3vNgrq/lGhLVVDWHkBo hm6+ZibFErB3LR6+r8EmeMuuOnzSQwzwagHM2XtRF8J3plak2mxhGrMGZxwlaHpcYcUi pd8Oz+Hjmskw4uG9rgJA9i6DQncF4n9jYUfxWf38fZ6z9Lje3xrly7t/LYPLY4/wtr4s qKww== X-Gm-Message-State: ANoB5plIAgMv7p9wuTSvOQ6hMjueKXXspX/DUTPbPQ8Xvg4dFesP5qtT 3HOsFXd0TkJpN9JWtefgfg63eA== X-Google-Smtp-Source: AA0mqf4ri14EyLqIFzLGY5keh/r3Jxtb0GSY6Ct3BcFq1UIKIQJILs0r96FiSxHkBGLmGF3ApF3pAQ== X-Received: by 2002:a17:906:4bcc:b0:7be:6ab8:4ccc with SMTP id x12-20020a1709064bcc00b007be6ab84cccmr12953386ejv.713.1669738683205; Tue, 29 Nov 2022 08:18:03 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-00f2-cafa-5a7e-526c.res6.spectrum.com. [2603:6081:7b00:6400:f2:cafa:5a7e:526c]) by smtp.gmail.com with ESMTPSA id gu21-20020a170906f29500b007ad86f86b4fsm6312071ejb.69.2022.11.29.08.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Nov 2022 08:18:02 -0800 (PST) Date: Tue, 29 Nov 2022 11:17:59 -0500 From: Tom Rini To: Dario Binacchi Cc: Roger Quadros , michael@amarulasolutions.com, u-boot@lists.denx.de Subject: Re: [u-boot][PATCH 05/14] mtd: rawnand: omap_gpmc: Fix BCH6/16 HW based correction Message-ID: <20221129161759.GU3787616@bill-the-cat> References: <20221011115012.6181-1-rogerq@kernel.org> <20221011115012.6181-6-rogerq@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1VtFtf1bAEcuptAG" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --1VtFtf1bAEcuptAG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 29, 2022 at 04:25:13PM +0100, Dario Binacchi wrote: > Hi Roger, >=20 > On Tue, Oct 11, 2022 at 1:50 PM Roger Quadros wrote: > > > > The BCH detection hardware can generate ECC bytes for multiple > > sectors in one go. Use that feature. > > > > correct() only corrects one sector at a time so we need to call it > > repeatedly for each sector. > > > > Signed-off-by: Roger Quadros [snip] > > +/** > > + * omap_calculate_ecc_bch - ECC generator for 1 sector > > + * @mtd: MTD device structure > > + * @dat: The pointer to data on which ecc is computed > > + * @ecc_code: The ecc_code buffer > > + * > > + * Support calculating of BCH4/8/16 ECC vectors for one sector. This i= s used > > + * when SW based correction is required as ECC is required for one sec= tor > > + * at a time. > > + */ > > +static int omap_calculate_ecc_bch(struct mtd_info *mtd, > > + const u_char *dat, u_char *ecc_calc) >=20 > Please add __maybe_unused. Without it the CI/CD pipeline fails: >=20 > arm: + devkit8000 > +drivers/mtd/nand/raw/omap_gpmc.c:442:12: error: > 'omap_calculate_ecc_bch' defined but not used > [-Werror=3Dunused-function] > + 442 | static int omap_calculate_ecc_bch(struct mtd_info *mtd, > + | ^~~~~~~~~~~~~~~~~~~~~~ > +cc1: all warnings being treated as errors While not a firm rule, a general suggestion is if it's easy to fix a CI error like this, do so (and add Signed-off-by tag) during testing a PR rather than ask for a resubmit. Unless there's other more complex changes needed as well. --=20 Tom --1VtFtf1bAEcuptAG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOGMLMACgkQFHw5/5Y0 tyyyuQv/a2aWspAek6OzjzmSXdjrqMFH5tqVvcnRHmi8xCQvw+qgXVpcUvpmlSM7 6hk0MnZshOs3kujapDlQBfIAqg8avJueRCWeeiKm5XmfPI3KDgfQDWroHsal8DTT 7OOiBOj5VGEyUgWFUG5gp1YekeZuppimnapNCqX54UPoqk31EK19LEFFATsF+P+F W+BzO0T47Q7Lcpf+/79AXdGBdKZmuuz/4Fx8M8aCYy8Ieieeqyw/d4m+QtGshz02 VlahuZudpWP2rHQGl5o0+A6QtpwK5eJ4SkJ4wojd5bTmSitUQxp1r8HB6PKmI0ig TMo8yWZmvyPV/e5Fee1YTtUpXxuvEM9TT5kme4l+knoHJlltb3Vh4Gx+jZNIdLTW rvcFs4D3u++WAHa+W9B5XyCWuMEEKxjq/GTMxDr4fOh0TZxJRfWr8d/7S/NcOVY/ o+XrJJ0pao1UuAAScKwMiulKUOAHZM3c05sdEpcaQHsfpdjLouIAwi1GHCRhZ9Nu W9H5FiVi =P1WD -----END PGP SIGNATURE----- --1VtFtf1bAEcuptAG--