Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0CA3C433FE for ; Wed, 30 Nov 2022 00:12:04 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AA1F685165; Wed, 30 Nov 2022 01:12:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="HMJAxrki"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EA86785261; Wed, 30 Nov 2022 01:11:59 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0600.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0c::600]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9AD1385165 for ; Wed, 30 Nov 2022 01:11:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fdqY6gTLCv1Q4WPxzpAOjlFiyW8x9oE95adXZUgFdGqC0PO+YkTXhKvS9Jw/Pk7LHk5+C4V/d6W483pg7cShBXCSUnpUsjrIfwZKleKB6fVwpFIKUGHrXm9yZ3Bwm8mGjDAb+EBL0ct8O+tjQEQFW/EpdqQVvR26ZeZip63NuPbkCZMcXxE1DpcCImGtOrL2Q17QcV4O3sUEGJAEWX2FhD1ww7RgW2VJ2cCnBo/pTrv5CJAUZrAFrIa/5MX+MTsdQDiLgS3b8gRvqJ20I8TYJFYySMJ4/M2grfttmUAOLJ8Jf0jCH201x7w/dgLsjrBJQXzFRdIjbH4OHzrPl8xWCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nUb6iSJi6JjKpJJkvWrWZ8XT+MapeZVB+vrntCGq0HI=; b=nukJkZ//oGw1USRzI0FAH04bnqitfPxuPQ9xkZbCtpDkudF8dw0z+WdYucu8jYQvJ3I2Pv7HZaoR0jC3g9ixQkbjL/bOfHsBZVDUeuZ2cN1BOXvED1YrtnZTD/kpLswKGVtaSb7vgoEMUOZhMR70NOrIijG28XZEjr0mUZLdJ/qxKNbnybvkwuoa7A/l2Im7zrEwCX8kltiYuIiONXaGNDBQYOOmQfWGFUemyJOeoItHtsvfJ9Ehtl38wPluaqM+Rc1mhNgepTSMl6a+Cauf++V1RdkE39WpZX9RitW0yh/hed0qt/5gJdU/F8fE5RvwJ04AZEKd6JkUbMM1sAKrSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nUb6iSJi6JjKpJJkvWrWZ8XT+MapeZVB+vrntCGq0HI=; b=HMJAxrkiWm0pXliYtLPcQPmk85I/pqycXWGyMWhC/3PeNiTLUZ2g/JFqGU/4PFLA6++25CS65VIKJrH6s0PB7mLzPr9PPiIjoq6yhlYUSwmHjN7wQ+imtbCJ+4Z93kNKLnlrNMdgqMFXRuxuHivstD4l+ipnC4EpoxnuD6p3FNc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by DBBPR04MB7979.eurprd04.prod.outlook.com (2603:10a6:10:1ec::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.20; Wed, 30 Nov 2022 00:11:56 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::9317:77dc:9be2:63b]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::9317:77dc:9be2:63b%7]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 00:11:55 +0000 Date: Wed, 30 Nov 2022 02:11:51 +0200 From: Vladimir Oltean To: Tim Harvey Cc: Tom Rini , u-boot@lists.denx.de, Joe Hershberger , Ramon Fried , Stefano Babic , Fabio Estevam , "NXP i . MX U-Boot Team" , Marek =?utf-8?B?QmVoxILImW4=?= , Fabio Estevam Subject: Re: [PATCH v8 4/8] net: dsa: allow rcv() and xmit() to be optional Message-ID: <20221130001151.3mtm2thvyq2tlk2j@skbuf> References: <20221028004937.3752914-1-tharvey@gateworks.com> <20221028004937.3752914-5-tharvey@gateworks.com> <20221128155823.GA2577274@bill-the-cat> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: AS4P191CA0009.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:5d5::16) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR04MB5136:EE_|DBBPR04MB7979:EE_ X-MS-Office365-Filtering-Correlation-Id: d248f0e3-e5c8-45d3-7615-08dad2677d5b X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9db3Zf6Q16OdTZ4MV2l44zKDGWziY+430f6uz88dIZrMOBVo6F7Sng/PsirhrAvfTHOyiPIm2ctQHdZY1jetvtsMsXMVngdRDTtCGDQkNvW6r9Cpc3aaNF7AMDP2S+MGQAat25DnWAYt3NK5nFAjQyoeZ1brSAqoeq70344kD0ouRuzIrshBBf3pFPNGqgKQ/AGy52QI5YT6H20vU83Pddd47ZBFu7B2TAROWdbIB3JXjq0zB71MANkSIfybNkBo5wP5lyTm+yP0FOzhDVBGemi4TGDYMSqerATDGv03wI2wsD82ZVdcZqA+hnrTU6OcYPDTEkuBWvRmm9oeT6cVHgtuaT4Vy41jpIPHqW4mwn52AXvYYNbNQWydw9KbtbBdB/NlCa8wOej0V2be3Payf5d0VY89osVvnQ9847h21hLEiUd9ZudbPz6OPz8ODPPSVazG6JtKQTt+d0qQMB52GeCOOW+gPW4ntwWnkwubtwBtVk/UL9ekza1A9qh4BwgqfHSTTy5F0nyY6Vm7yFwxJrF/hcWKstVApn/5eSrApGUOqJVq2bCIeNhy5EFFFAlIJis/wLAbK9MZyt2W5dO8hAiGwCoIWQBsixchyqeMoS5OX71whyZ3r284xskPcTOeUIZXM3iFcUBUeC2qq1TG9w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(7916004)(39860400002)(376002)(346002)(396003)(136003)(366004)(451199015)(186003)(6486002)(66946007)(6666004)(53546011)(6506007)(54906003)(83380400001)(66556008)(66476007)(316002)(41300700001)(1076003)(8676002)(9686003)(8936002)(4326008)(5660300002)(26005)(6512007)(33716001)(86362001)(38100700002)(44832011)(478600001)(2906002)(6916009); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?R7Yf3G5NaxiMM3rbn0cv2dpLC64qBWjZQIEz/btWcnU9DoSyGwufnt6G/339?= =?us-ascii?Q?J6zXgon8d9SnPIjeNlKB0KuWGGbO4S5fQl5EvxGMJc+XWW6kME8IcGnUQY66?= =?us-ascii?Q?T5hzusT0942F/qV0hHYlgEI1uLwUBvq0GKJMUMwdqhsBOywhyAkDzJaZ0y2g?= =?us-ascii?Q?TCMs9h6gYhTMGaUhY81rLE5FlO5m8BGqgKAT/EpQkL1oOs/Q17E+deq7HnUY?= =?us-ascii?Q?q+vrGV3qUDwLCGQu8SOa+JdPsK49zt+9awFdEbT7uGc466UBYOrYfZopN2RX?= =?us-ascii?Q?QE5tlMiqsqF01v+12liCYO0dD3pTAv+b+4FmUGKQckrOIRQtHHgRAq1esNQY?= =?us-ascii?Q?xboM8hlNG6NTbsTiusoVGmeDRtywIjpwa8Zpb0isEVuqRZWwafxYVz5G6yBR?= =?us-ascii?Q?GG3aEgXZ6pR80imXUee86YcLkQPkGgPF5sUQQVEfW/RVcToTXg+IOeu18rx+?= =?us-ascii?Q?9F1Q0sqt+w4ifYM2fEXbF36kMsKDtlUAYEKMhJXfh7QCDMXYEF5ecPA0juvd?= =?us-ascii?Q?zjcRwU3gn8pfu1ej0aXWwzHIlaz9kttYtcBOc032NNiIX8aHC/n7Ey6bsqrE?= =?us-ascii?Q?nHmpaOjcTUFVMW1jyKiUMDz5V/pr4j6YBxpKVVrRXhnfmgC9zpkj/11HrI5l?= =?us-ascii?Q?qsf18R3uPB94jtj9yQzULvCL+RCL+2Nz8YqoEFOY6T+mlqzmUqUISkffXx16?= =?us-ascii?Q?1tQ/lN/+HyG3T0KwqRkBtgR8A+oRt3HhorDodb54tyxNrUE3rGMIGIK0jwbd?= =?us-ascii?Q?rw26D3dR+/KPQgxUSOe1C5s9XBK7+evqvlNLkgZBaaazMcUY8moT/ad6h8h2?= =?us-ascii?Q?XDYQgOBHQ3Az4H9yYFF5XwiukhUAIokXWzAqcWKty2ByWUtVG69UytLvuTP1?= =?us-ascii?Q?640efZeJ2bkDLHqRLzupEyhmO6cse3JNC2MAyTPaxzc5Q9IEnZ8PDTAp4FTV?= =?us-ascii?Q?VGsfd8xZZMqldkvAtZ5VUjb5uhWEYucEg2RUVo7PsGm4xOXQLMgJUBcWv0LF?= =?us-ascii?Q?UmEWCbzoE3hwsDCsTn1/7sYOesQAEMfg5+cdPDxJqJP/Yls+frjHb15Mbe9R?= =?us-ascii?Q?rH3M56oENKQ7+WWsOguP/N2ufKMQtOjrbZDIDXwtNA9pASjBfV6fBt8OPJe/?= =?us-ascii?Q?UvHD5AehQV9WccLGrKeWlRFiAeZinZJ8RqU28QV5c0m3xRBKVH5xioKpfWDw?= =?us-ascii?Q?dOGC+K6S2GFaOXflP2BGii4X6TAmjS/E/kbnv8Zt4P35XEJQEq9hvD0dKhGV?= =?us-ascii?Q?iXLrHQRrRTHzw3+lCpbwLge/HtVE/jGRp4MyfbVx8kV2kVdFjwEZ++JfvaRN?= =?us-ascii?Q?VTraK/xcOqtFCXMsH2N0ZUSAkJKp9idPUWwfAuPOSPKb/bC4dfyz9U55v6sG?= =?us-ascii?Q?8TOcGZt+jkWAKV26NI9Y1z3AZoU4Yi8o0wp6nMMJB487AEtEpmDufywj8TwB?= =?us-ascii?Q?hRJSmeJSA0D0mZxbrGtiJmpdMTTEcYY1S1olsRyQQYn8L0Hiv889eNRbnz0d?= =?us-ascii?Q?jnWySxKo6UJSYvPEFi3JXxVVD1P9/dE4QR3QvcGiShEOx5IAa2UF6s3FGtnp?= =?us-ascii?Q?EuJcEHRq67qmwRUq4zNbhShNZD7E61J/V8AGGGJbvuIBtbDa4D70mLd9LiW4?= =?us-ascii?Q?Kg=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d248f0e3-e5c8-45d3-7615-08dad2677d5b X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 00:11:55.4519 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x2Oh0uL/Co255MmUwG97sal8TNbyU/z/yo05saP14nkJYXz8+iOiTGscT797JsJtaobzOk7LBFZEB+EtggrHVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7979 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, Nov 29, 2022 at 02:53:15PM -0800, Tim Harvey wrote: > On Mon, Nov 28, 2022 at 7:58 AM Tom Rini wrote: > > > > On Thu, Oct 27, 2022 at 05:49:33PM -0700, Tim Harvey wrote: > > > > > Allow rcv() and xmit() dsa driver ops to be optional in case a driver > > > does not care to mangle a packet as in U-Boot only one network port is > > > enabled at a time and thus no packet mangling is necessary. > > > > > > Suggested-by: Vladimir Oltean > > > Signed-off-by: Tim Harvey > > > Reviewed-by: Vladimir Oltean > > > Reviewed-by: Fabio Estevam > > > > This causes: > > FAILED test/py/tests/test_ut.py::test_ut[ut_dm_dm_test_dsa] - AssertionError: assert False > > > > In sandbox, and I don't know if the test or the code is wrong. > > > > Tom, > > I'm not familiar at all with U-Boot's sandbox or unit test > infrastructure and am trying to learn. > > I've figured out how to build sandbox and run the dm_test_dsa > (./u-boot -T -c "ut dm dsa") and see the same failure as you but I > don't understand how to debug this as it seems prints I add in > dsa_port_send and dsa_port_recv (which is what this patch modifies) > don't get print when run from the test infrastructure. > > When I boot u-boot sandbox (./u-boot) I don't see any network devices > at all - perhaps I'm not booting sandbox with dm or something? I need > to understand what devices/drivers sandbox is using and how to > recreate the network environment that the dm_test_dsa function is > using which calls 'net_loop': > > net_ping_ip = string_to_ip("1.2.3.5"); > > env_set("ethact", "eth2"); > ut_assertok(net_loop(PING)); > > env_set("ethact", "lan0"); > ut_assertok(net_loop(PING)); > env_set("ethact", "lan1"); > ut_assertok(net_loop(PING)); > > env_set("ethact", ""); > > Best Regards, > > Tim I use the following steps: export KBUILD_OUTPUT=output-sandbox make sandbox_defconfig NO_SDL=1 make -j 8 NO_SDL=1 $KBUILD_OUTPUT/u-boot -d $KBUILD_OUTPUT/arch/sandbox/dts/test.dtb setenv ethact lan1 ping 1.2.3.5 ut dm dsa In this case the problem with the patch is simple, sorry for not noticing during review. dsa_port_mangle_packet() changes the "length" variable. But if ops->xmit exists, eth_get_ops(master)->send() is called with a bad (old) length, the one pre mangling.