Date: Wed, 30 Nov 2022 13:35:37 +0100 (CET) Message-Id: <202211301235.2AUCZbbm012064@...2054...> From: Gert Doering In-Reply-To: <20221130105502.662374-1-selva.nair@...277...> References: <20221130105502.662374-1-selva.nair@...277...> Subject: [Openvpn-devel] [PATCH applied] Re: pull-filter: ignore leading spaces in option names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Selva Nair Cc: openvpn-devel@lists.sourceforge.net Acked-by: Gert Doering I thought we might not need it, but Arne says it's useful, and it's really trivial and not adding much code. *line is a local variable, so it can't have side effects, and isspace(*line) is "end of string"-safe as well. Tested, of course, to a server that still had the extra blank $ openvpn --pull-filter ignore auth-token ... without the patch: 2022-11-30 13:10:41 PUSH: Received control message: 'PUSH_REPLY, auth-tokenSESS_ID' 2022-11-30 13:11:37 PUSH: Received control message: 'PUSH_REPLY, auth-tokenSESS_ID' with the patch: 2022-11-30 13:21:02 PUSH: Received control message: 'PUSH_REPLY, auth-tokenSESS_ID' 2022-11-30 13:21:02 Pushed option removed by filter: 'auth-token SESS_ID_... 2022-11-30 13:21:59 PUSH: Received control message: 'PUSH_REPLY, auth-tokenSESS_ID' 2022-11-30 13:21:59 Pushed option removed by filter: 'auth-token SESS_ID_... Your patch has been applied to the master and release/2.5 branch. commit f02946ff9900a37dd36f61748173d53eca01adf9 (master) commit 00952a6184da0a77fbabe801d842a7546058f6c2 (release/2.5) Author: Selva Nair Date: Wed Nov 30 05:55:02 2022 -0500 pull-filter: ignore leading spaces in option names Signed-off-by: Selva Nair Acked-by: Gert Doering Message-Id: <20221130105502.662374-1-selva.nair@...277...> URL: https://www.mail-archive.com/search?l=mid&q=20221130105502.662374-1-selva.nair@...277... Signed-off-by: Gert Doering -- kind regards, Gert Doering