Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84BB1C4321E for ; Fri, 2 Dec 2022 15:24:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C5A4285447; Fri, 2 Dec 2022 16:23:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="N3mvSNqN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ADF3785424; Fri, 2 Dec 2022 16:23:56 +0100 (CET) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 475D385447 for ; Fri, 2 Dec 2022 16:23:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-ej1-x62b.google.com with SMTP id ml11so12325285ejb.6 for ; Fri, 02 Dec 2022 07:23:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ysonmzqv//XtWQSh7lXgRjE1s8SVNmX4n3FBV3QckRI=; b=N3mvSNqNZd5z36Pm99ByT+EoczgC3kwk0QxSgtlsTEh4CJENOK4OeR4qBRSXMi8FLw w5zPY9Je5bMlfNYTfdBU8Ug4unA9uLJg3wITPJwxsfp347Veh6IGrCyHZ5QME4RUyd3W L35I5mZ3GUDP6+Gqssi+CK/RJRECZsToyKffM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ysonmzqv//XtWQSh7lXgRjE1s8SVNmX4n3FBV3QckRI=; b=gNcnZyfuhteXbA1z5e3fSPCfvzgwI16sIGaiddhg+KQaN/PADK2GkAk6P4gov2RgiL kP0AxQVVPnOW4BkPIR7tu1a+WL365z1uPlFCKxTvE6VVKIgyKHUiB+pG06C1v6VDfxSB mOqsqhOG9A4O+S6M9D+GHZVdmYF/u+i0vOVc/z8qCW65dONc9UuBIT0uRWleQMnG0wmr Gm65cElpEcQh8Ot8p4L6+fb3gG7oN9hu5NLLtdoyKhRgs3a9x87d8KCm+O0f5AylKbWL GJHZF1uDyKtTVI0umaffuCxQpTZlWYuKgRyoPTRI/+jpdNqWsySy1GO27hyUJ4tr8lQ8 V1/g== X-Gm-Message-State: ANoB5pm6d6h434mGMfu9LP4mgcNhamhQxLvM/+zxZqCNanB8y/BANUl2 AEB16yyK1frGl+tF7VJlzAhXWA== X-Google-Smtp-Source: AA0mqf5sapGgoQxGARI++bLpVJJFTyx5Aao489kIUkpn9WlW2Li0ku1xSP6Ppo7Glb6XwrtAU1RRVA== X-Received: by 2002:a17:906:a257:b0:7ae:3f79:4d0a with SMTP id bi23-20020a170906a25700b007ae3f794d0amr60588914ejb.120.1669994633754; Fri, 02 Dec 2022 07:23:53 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-f99b-6f1a-2cc1-7368.res6.spectrum.com. [2603:6081:7b00:6400:f99b:6f1a:2cc1:7368]) by smtp.gmail.com with ESMTPSA id es15-20020a056402380f00b0046aa78ecd8asm3041330edb.3.2022.12.02.07.23.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 07:23:53 -0800 (PST) Date: Fri, 2 Dec 2022 10:23:50 -0500 From: Tom Rini To: Paul Barker Cc: u-boot@lists.denx.de, Simon Glass Subject: Re: [PATCH v2 1/9] dm: core: Fix iteration over driver_info records Message-ID: <20221202152350.GI3787616@bill-the-cat> References: <20221114124243.3719037-1-paul.barker@sancloud.com> <20221114124243.3719037-2-paul.barker@sancloud.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eM3kDVniUg+mAxjW" Content-Disposition: inline In-Reply-To: <20221114124243.3719037-2-paul.barker@sancloud.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --eM3kDVniUg+mAxjW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 14, 2022 at 12:42:35PM +0000, Paul Barker wrote: > We should only perform additional iteration steps when needed to > initialize the parent of a device. Other binding errors (such as a > missing driver) should not lead to additional iteration steps. >=20 > Unnecessary iteration steps can cause issues when memory is tightly > constrained (such as in the TPL/SPL) since device_bind_by_name() > unconditionally allocates memory for a struct udevice. On the SanCloud > BBE this led to boot failure caused by memory exhaustion in the SPL > when booting from SPI flash. >=20 > Signed-off-by: Paul Barker For the series, applied to u-boot/master, thanks! --=20 Tom --eM3kDVniUg+mAxjW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOKGIYACgkQFHw5/5Y0 tyw5FQv7Be7nECNiydSmD9ooBg2lQnYFVK3W6TDzwFG2xD0S3XCMfzWtzlYkFqtW dBERkASzP1ySTVzor+j8wuFcL8a11uLRwk6ouS8/aWmE8ACgxABvRdGj+RpNIWRW QEYhXfBNTmv1k/5zSbnxaeCOgLbG0wLpK1HqPn1fu9FEjkTk8FZlxipAIst+VPa7 TKE3gYlfmPbKH15HZzlHb1ho59N5CgOMnP34bjNXX8gCxDrBxDoFPRArF7apJVdu UuIhDsbzhUAMXZzbtIw/gHb0Iov7h5c2NTMHS834jT3SlVMDc0xZEaYNHXqncdgv LZMd6q5ZVxwyu6y3nw7Pr9e2x12BFsq0wD7DgIBUvUismxnH2rV5wPhbcQxkuJKz X5A/VsNGk6FM9O96Yg26FC55MkO26zlplp/lBnny6Yw437m5OXfkXX5sY3t1w3/1 FUhPaKUNxVKNls6U4T+bT5ifJyrhdrs6C5013NoTomXQx+hGMyPAiHKzj9taZrwP ed244DoD =qXWt -----END PGP SIGNATURE----- --eM3kDVniUg+mAxjW--