Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98DD9C47089 for ; Tue, 6 Dec 2022 02:03:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E1E648532A; Tue, 6 Dec 2022 03:03:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="XF9PTkvv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 81FB085424; Tue, 6 Dec 2022 03:03:43 +0100 (CET) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 83FF684D1B for ; Tue, 6 Dec 2022 03:03:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-wr1-x430.google.com with SMTP id y16so21529689wrm.2 for ; Mon, 05 Dec 2022 18:03:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6Rdj3wy2e8zMVZF9NOH64wV9afXi5Z+5nDBYzwuVtaY=; b=XF9PTkvvKB3fVPsftF2Z5c3mmTCyTAox5FiGeiTZmYIXCVN/nc1aV3QvYT1L2D+zZH jKnRH8oix7qIfITxnGI+s1WLBqkFZLszWxcFfQTwCTmfSDIWh5wB40nSGxKSydN2F4DI a8oxT6l5Ma5FnpvBkMjbm1P+iL5OpoBrqK0q8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6Rdj3wy2e8zMVZF9NOH64wV9afXi5Z+5nDBYzwuVtaY=; b=2ExlUksKXnyw/01N/QVqs8tnJbAZIRRojYjmEXikW74ugPNtPRYjrMmMLC5jt/iFz3 1nZmXXcGoVnqYVLDM7wVMsSE1uXhlTQD44c/WqO/+lghT6m+MU/USi0m8DehTGkIecFY m4iov5jmzMkZ2x7tIXDjZaWsdcvU//YRN+CvgCqwwaTxF1qLPmqdrbqVatM0SRnxlY7d QihUyR5ZyOp3Ywpu3h1bAFmEziS5O4G6ILSIzF+U69uU0zkSrXCDw2Byl0H6DKf7MxhS WEztQBstF1l3PqG1zb6YjjcuzDh8Sn7ZobRKwFEE5xNrvL3N+T7NKh4DJfx0WxYTvVNz avZw== X-Gm-Message-State: ANoB5plhZCKEmfG2rzrEAzmy6/vcOl7keGOqrI0E1NSyqP7f/cNNbD7T /iZriEpROCqGqxtaiyPW7FVzaN1FsH0w2PXI X-Google-Smtp-Source: AA0mqf7dxvPUxZcVH8vtz3N5dr8/i1HPja1La3P3mNT7aDtXBe9vXMGb6uA4IDZoI2CNIxVhnpUk5A== X-Received: by 2002:adf:fd03:0:b0:242:5361:54ee with SMTP id e3-20020adffd03000000b00242536154eemr6737226wrr.667.1670292219861; Mon, 05 Dec 2022 18:03:39 -0800 (PST) Received: from bill-the-cat.lan (2603-6081-7b00-6400-3974-0ce5-e869-8ac0.res6.spectrum.com. [2603:6081:7b00:6400:3974:ce5:e869:8ac0]) by smtp.gmail.com with ESMTPSA id l22-20020a05600c4f1600b003d1de805de5sm3852759wmq.16.2022.12.05.18.03.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 18:03:39 -0800 (PST) From: Tom Rini To: u-boot@lists.denx.de Cc: Simon Glass , Peter Robinson Subject: [PATCH] Makefile: With BINMAN_ALLOW_MISSING=1 don't error on missing Date: Mon, 5 Dec 2022 21:03:36 -0500 Message-Id: <20221206020336.315465-1-trini@konsulko.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean When the user builds with BINMAN_ALLOW_MISSING=1 they're explicitly setting the flag to allow for additional binaries to be missing and so have acknowledged the output might not work. In this case we want to default to not passing a non-zero exit code. Cc: Simon Glass Reported-by: Peter Robinson Signed-off-by: Tom Rini --- This passes CI as-is: https://source.denx.de/u-boot/u-boot/-/pipelines/14340 --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index de5746399a63..03de1da1bfd0 100644 --- a/Makefile +++ b/Makefile @@ -1334,7 +1334,7 @@ cmd_binman = $(srctree)/tools/binman/binman $(if $(BINMAN_DEBUG),-D) \ --toolpath $(objtree)/tools \ $(if $(BINMAN_VERBOSE),-v$(BINMAN_VERBOSE)) \ build -u -d u-boot.dtb -O . -m \ - $(if $(BINMAN_ALLOW_MISSING),--allow-missing --fake-ext-blobs) \ + $(if $(BINMAN_ALLOW_MISSING),--allow-missing --ignore-missing) \ -I . -I $(srctree) -I $(srctree)/board/$(BOARDDIR) \ -I arch/$(ARCH)/dts -a of-list=$(CONFIG_OF_LIST) \ $(foreach f,$(BINMAN_INDIRS),-I $(f)) \ -- 2.25.1