Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2889DC4332F for ; Thu, 8 Dec 2022 09:53:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4B3C88517B; Thu, 8 Dec 2022 10:50:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=microchip.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=microchip.com header.i=@microchip.com header.b="KXxmFauN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B31A485098; Thu, 8 Dec 2022 10:50:01 +0100 (CET) Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AFA218518C for ; Thu, 8 Dec 2022 10:49:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=microchip.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=Sergiu.Moga@microchip.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1670492998; x=1702028998; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1QDxR4J4vMrHuyf5cmAe+jhT5fkYLgQtxPPQFNoAsKI=; b=KXxmFauNxb0lldDzCGUrtDYrfQG9C5BnHgXb8JMkNgY8faw8dcfrp2Z1 XNrahyAnTmlPedxIvPyUTMoqT5YWOH4SvHdrqtyD9/NSLuU+/8vTm8bYg YB1kmhAMbi4RaRi6ThcOOxLALSIVCcTXhqhOEdr/chV70beox6q+zYcrA lkHoJiNr/LXwwfdCrYyiW8oFzfCHAX3n6pvF4FrcNC+DGsz4Ag+lN74zj NQr5AkUIL30SXMvU8Ioi3fjYq7TLSPuANPzE6vupTGYZJUv5Cxk5qGtcs XYJNlLY2jtVGOn8z3AzEZSwPYyR484AE+R2MNq/T3inX8yipCRqkAx8/4 A==; X-IronPort-AV: E=Sophos;i="5.96,227,1665471600"; d="scan'208";a="203116956" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 08 Dec 2022 02:49:56 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 8 Dec 2022 02:49:56 -0700 Received: from ROB-ULT-M68701.mchp-main.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Thu, 8 Dec 2022 02:49:50 -0700 From: Sergiu Moga To: , , , , , , , , , , , , , , , , , , , , , , , , CC: Subject: [PATCH v2 19/19] usb: ohci-at91: Add `ohci_t` field in `ohci_at91_priv` Date: Thu, 8 Dec 2022 11:47:18 +0200 Message-ID: <20221208094717.45933-20-sergiu.moga@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221208094717.45933-1-sergiu.moga@microchip.com> References: <20221208094717.45933-1-sergiu.moga@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean From: Cristian Birsan The `ohci_register` function expects that the OHCI driver's priv is a struct whose first field is of type `ohci_t`. The original conversion to DM did not have it and this inconsistency revealed itself whenever U-Boot required multiple memory allocations resulting in a memory overwrite of where this field would supposedly be. Thus, add this missing field and automatically increase the implicit size of the driver's priv to avoid whatever future memory allocations may take place from overwriting it. Fixes: de1cf0a9c6 ("drivers: usb: ohci-at91: Enable OHCI functionality and register into DM") Signed-off-by: Cristian Birsan Signed-off-by: Sergiu Moga Tested-by: Mihai Sain --- v1 -> v2: - No change drivers/usb/host/ohci-at91.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index 4b1aff4127..0791769026 100644 --- a/drivers/usb/host/ohci-at91.c +++ b/drivers/usb/host/ohci-at91.c @@ -90,6 +90,7 @@ struct at91_usbh_data { }; struct ohci_at91_priv { + ohci_t ohci; struct clk *iclk; struct clk *fclk; struct clk *hclk; -- 2.34.1