Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75C01C4332F for ; Thu, 8 Dec 2022 20:23:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id ECE4885179; Thu, 8 Dec 2022 21:23:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="bWmPDeh9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E063185171; Thu, 8 Dec 2022 21:23:33 +0100 (CET) Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CF8EF8510C for ; Thu, 8 Dec 2022 21:23:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-wr1-x42a.google.com with SMTP id u12so3044779wrr.11 for ; Thu, 08 Dec 2022 12:23:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8kIBUR5KbGa2kEztSMqDoMI+YXdJSF2WoGmZxsor0Kg=; b=bWmPDeh9VTOUHI53MUSNKpAc2hgZVeEyzLXpoOM347EucuVvD7eTddYMx3Ia9Y+SVr NTNEbB5lmQtUMwN92xUGBIcvJFFx9eRTruZs3dgYrXE7uVa69IrxEqPr+s4mVj7mpM10 vOmphHX//OChwLyBgkEdsvel6Xx4LIF0UqZ9I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8kIBUR5KbGa2kEztSMqDoMI+YXdJSF2WoGmZxsor0Kg=; b=X7FUx6ao/HelD7SPX6XWUEqpz9v3ZJuaIsKCap7JDTtugAvROvckBWoZIf9EH6/DpY a1OHzL2GQ1PN4Ct9L4uWMA24EOq0CGxEP90nM0lUIAxvBEHEvmas/rhsipEbqXWNCFXM yJCvJQcDdaG4NluzU4KkmDLIAdg557/hCupCKX6LMAA3hOdkBRPkqKCcFrLmNNgckdBM gQPq9RkP10N2pEEtBobFfJXua6jFgXVc0Cxzo7G5Hk8LWo/nKV/ghGaf6OoBgEoDXy/3 8GMmoN6yeL0rAuktolm/sMNBz1iNNA9AkuvgtexOfY75wBYc5hqVIKcSy8lgcflUednC 7Cdw== X-Gm-Message-State: ANoB5pk7EY5MYHuSq+Ctw6XkWNybaYXen1JpiQ4A0CKJiHBn/CAYHneN c2SNs7jya0ApcTQGjy+4Xkrrodu7MlWsVffR X-Google-Smtp-Source: AA0mqf5NFJWy2B1Hyl8O22JwDnMYYQKulxj/Cu4UC2bbBHp7B65HIQ7LoeGWYaq7lMWIo0b9bPMD2Q== X-Received: by 2002:a5d:570b:0:b0:242:5d8e:6c35 with SMTP id a11-20020a5d570b000000b002425d8e6c35mr2047095wrv.28.1670531006385; Thu, 08 Dec 2022 12:23:26 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0511-db36-5a97-af74.res6.spectrum.com. [2603:6081:7b00:6400:511:db36:5a97:af74]) by smtp.gmail.com with ESMTPSA id j13-20020a056000124d00b002421db5f279sm22768240wrx.78.2022.12.08.12.23.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 12:23:25 -0800 (PST) Date: Thu, 8 Dec 2022 15:23:23 -0500 From: Tom Rini To: Mikhail Ilin Cc: u-boot@lists.denx.de Subject: Re: [PATCH] tool: ifwitool: Fix buffer overflow Message-ID: <20221208202323.GG3787616@bill-the-cat> References: <20221118115024.9092-1-ilin.mikhail.ol@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ESALR2nqcUcb10U9" Content-Disposition: inline In-Reply-To: <20221118115024.9092-1-ilin.mikhail.ol@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --ESALR2nqcUcb10U9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 18, 2022 at 02:50:24PM +0300, Mikhail Ilin wrote: > An incorrect 1st parameter is passed to the fix_member() > function. Should use a pointer to the beginning of the parent structure > (bpdt or subpart_dir, because are boxed), not to their fields. Otherwise, > this leads to an overrun of the structure boundary, since in the > fix_member() function, an 'offset' is made, relative to the 1st argument, > which itself is an 'offset' from the beginning of the structure. >=20 > Signed-off-by: Mikhail Ilin > Reviewed-by: Simon Glass Applied to u-boot/next, thanks! --=20 Tom --ESALR2nqcUcb10U9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOSR7sACgkQFHw5/5Y0 tyz2ZgwAk78i9RmtIv/TmgHfAA/Csuni/lNvHUPPEHHdUqiTD+CHrxOt+uztBD4J k7nrJgyIV5KNWMjw+9SxHe/G5CqFhPs+gMjqSwgK/XI14utgzfPyJiNMS20wxtIA /O1KQDdRv4O6GmpH721t+onMVWtI2Uo5poKDb8gNZKIBJHMtuDmkd6jlZpL3EprL Nctboj64VQSyDWGf5l18slxwJPz4UiPoBeExClk913wmSL++Y45tOYIa9cp/UrRm NT5BYriaDoJG8W0CKf7J8Qn1pG1hFgeRX8MD2V3S639zP1RzMC41ILHAC/+nJYys S4H65TRraZitAMXSWFrI9VLG2fiKCbRs5y7LmsoXquTpqmNvNn536GKi2feaUxkN yAm899nmD7mbTwhlmGTHM7r/rCXxC7V9CW9E19Jvg+GsnyVwaad6ZKZVKvPHC5wo coVlO7nMxiby43WAMeqVGshbj+bQAwkQ8BOENAPoK3djyn0W6N8UJQMNLkXG7zJ+ 0zRIMsfH =dMRD -----END PGP SIGNATURE----- --ESALR2nqcUcb10U9--