Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4986C4332F for ; Mon, 12 Dec 2022 15:03:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F0569853A9; Mon, 12 Dec 2022 16:03:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="E+RqbLgG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8D1F78533E; Mon, 12 Dec 2022 16:03:22 +0100 (CET) Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BBBAD8533E for ; Mon, 12 Dec 2022 16:03:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-3b48b139b46so149429147b3.12 for ; Mon, 12 Dec 2022 07:03:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=90TVicrzMi3fwcAlaW0cCqIS6VCxhEQViGR3GsekaOE=; b=E+RqbLgGDvPIp7fEh8MGUtdFJ7YGWXIjgZ7JJBwo8O5zUNWe19mL1pehkat+Ix37y0 OrOqDQUpuPlh/R5bhuqKQ2xa+GP/Csi9V0BrOKJjDck+po0EEn73bK/N+x7BdLWZvO/A VXb7fsNGPM9f71y8vm/DX1KoRUtnmgQwJoQJU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=90TVicrzMi3fwcAlaW0cCqIS6VCxhEQViGR3GsekaOE=; b=3nprrYa5fbwyxrlleV2pgqG92El7pK0s0pTeEvEsednGlQlN1SZbpef+9uTeh6bweH ouIGyUGkK8fYdjhKaON2BaEzm1abDq0uu7MH8H/PgKNXxjUHaRVxPiAxSkidLMU2Jy8F jbBFJ2IfxSD1j47taNT+WuHW2VQzZeK3qs+CDQEciwbU/b20WdmSTe4VuaJVpSlG/4tf EHIaJmRW/LLcgHMUcNGgfvf5LyeTIXLVeNSfEGKfJrz89fiqoEbNn47hqj9Yy9erITmE 9483qdves7C/I5IXTyDddeb0MYF1cZ2bNhv+i9QkXLo0gIXAFaO0/AENK3wQP6+fDEmz ruFA== X-Gm-Message-State: ANoB5pnhO5SnqjzrouiEGQzEdng90fM4Y5TEq6VnidtBMK6wdGBoMxED yS4dEGqU78Mq4ASkRw2+7ryx0w== X-Google-Smtp-Source: AA0mqf62K122x4XNmuhNqiABDADiydzS5Scjj4/b0JNg2x7g+BFXXrYc+yV1DPj3TZ9U4MIZNbxtVQ== X-Received: by 2002:a05:7500:6d18:b0:ea:7e91:fb03 with SMTP id kd24-20020a0575006d1800b000ea7e91fb03mr1573249gab.77.1670857398156; Mon, 12 Dec 2022 07:03:18 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-8c5e-02dc-44a6-fa90.res6.spectrum.com. [2603:6081:7b00:6400:8c5e:2dc:44a6:fa90]) by smtp.gmail.com with ESMTPSA id t14-20020a37ea0e000000b006fa7b5ea2d1sm5775876qkj.125.2022.12.12.07.03.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 07:03:17 -0800 (PST) Date: Mon, 12 Dec 2022 10:03:15 -0500 From: Tom Rini To: Rick Chen Cc: Sean Anderson , Rick Chen , ycliang@andestech.com, u-boot@lists.denx.de, sjg@chromium.org, xypron.glpk@gmx.de Subject: Re: [PATCH 1/4] riscv: spl: Introduce SPL_OPENSBI_OS_BOOT Message-ID: <20221212150315.GS3787616@bill-the-cat> References: <20221207062334.21292-1-rick@andestech.com> <1162c5df-dcfc-0908-1d07-32145e3a6aaa@gmail.com> <20221209220723.GS3787616@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cAg5yEESD88gv+LO" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --cAg5yEESD88gv+LO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 12, 2022 at 02:45:10PM +0800, Rick Chen wrote: > Hi Tom >=20 > > On Fri, Dec 09, 2022 at 08:48:37AM -0500, Sean Anderson wrote: > > > On 12/7/22 01:23, Rick Chen wrote: > > > > In RISC-V, it only provide normal mode booting currently. > > > > To speed up the booting process, here provide SPL_OPENSBI_OS_BOOT > > > > to achieve this feature which will be call Fast-Boot mode. By > > > > > > Can you name this something different. We already have something call= ed > > > fastboot in-tree (the Android-derived protocol) and there's a Microso= ft > > > technology called fastboot (some kind of hibernation). "OS Boot" isn't > > > very specific either, since we (almost always) boot an OS. Maybe "Eag= le > > > mode" by analogy to Falcon mode, which lets SPL directly boot an OS. > > > > > > (Is this substantially different from falcon mode anyway?) > > > > I was kind of wondering if this is different, really, from Falcon Mode. > > Falcon Mode didn't initially have to factor in other-firmware as that's > > not a hard requirement on arm32 like it is on arm64 or risc-v. But my > > first read of this was that it seems like the RISC-V specific side of > > doing Falcon Mode and dealing with the prior stage needs correctly. > > >=20 > Yes. It is a little bit different from the Falcon mode (SPL_OS_BOOT=3Dy). > When I try to enable SPL_OS_BOOT, it will encounter that SYS_SPL_ARGS_ADD= R and > jump_to_image_linux() shall be defined but they are un-necessary for RIS= C-V. > Because the flow of OpenSBI and SPL_OS_BOOT are totally different code > flow in board_init_r() of common/spl/spl.c. > That is why I added a new symbol called SPL_OPENSBI_OS_BOOT for this > RISC-V fast boot implementation. Those sound like fairly minor challenges for the same fundamental concept. We have SYS_SPL_ARGS_ADDR for "where is the device tree to pass along". We might need to do a little code re-factoring here. But maybe also a little bit of explaining why we wouldn't be booting to the OS directly but instead passing back to openSBI to do this? That's not normally how RISC-V boots the OS, right? Or am I miss-understanding something here? --=20 Tom --cAg5yEESD88gv+LO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOXQrAACgkQFHw5/5Y0 tyzmyAwAmvnMEAC9EBpDYRD+mcZ5VAMxrfQQCwzT92jw2DOSSrLzMrc9yJy1/PKP wcVCCEH0dB66n1ZIQ6Q+X2e6KqimKMo00ACVvXH4nVnMdrsrBHKtYnqvXElaDYdP NiFVxFPGNelSxY6JxdAfjcDRrv6gBkHMJpw/OHrvkRMvpyJ8mv6CbPUi02Y31RnW EvhXeRbid0HRD+uO68ToLDTrkJ0XzO1EjuZNuYOJEmrfm4ZD9trtgvTNp+CzRWsY 9FUsp5bnOsw0F3s8bI8EfLQPm0f2M9ZqnQWH4HQno3TbsaWVm7B5WcxfTxXkOf/V SmF3wWa+EOKq3vRRSt4KcoS24ytKSiuxDtXFwdnbHvcOKZurcEdafDkTt6m1dYea qmLP6OQTXJYCJMOYdiXCepx+0x34rNcCiBbYjx10iYuSa9I4srwbpquZAEFKTCII CO8c5I6a3ZeV+GAR4d7bDCo6FDO0wLdI5hGIFjbeNjAaRNmg0JeFSFEdpq3sNhRq SYi9/27v =3gZD -----END PGP SIGNATURE----- --cAg5yEESD88gv+LO--