Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2B57C4332F for ; Mon, 12 Dec 2022 16:53:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1C8CF85207; Mon, 12 Dec 2022 17:53:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="dW/RKcyM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AE6DF83622; Mon, 12 Dec 2022 17:53:11 +0100 (CET) Received: from mail-vs1-xe35.google.com (mail-vs1-xe35.google.com [IPv6:2607:f8b0:4864:20::e35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 935AA85207 for ; Mon, 12 Dec 2022 17:53:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-vs1-xe35.google.com with SMTP id c184so11854339vsc.3 for ; Mon, 12 Dec 2022 08:53:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hFrpvUhnFbmKdK3Nc1s5KuAvZBid1l3FQKZPbsO6/z0=; b=dW/RKcyMZjAqag1czNTBrhmVnAlmYwmEpKGaMYV6uzzyE0mRtaZyrKfZGJoAXIV7lt m/kNupYi8YnsSjqNqINBo5xZi9uStfG04jcU9MFV6jKITUb7rETmywAQbahcjsFirpwD DwE5EfAdsWtU9KpC4O+elIUX1NfEPBHBW7nYo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hFrpvUhnFbmKdK3Nc1s5KuAvZBid1l3FQKZPbsO6/z0=; b=QlJU8kzhBDSEZwOqJ+KS4slqgA6amCImGWkvJAaqtPiUPrKJ8HTYHjo4k8qqQuJtMH DqYTl5UcwUcGeWgc1w1R5FwE8HaL1A+nO7UOv0INWMlg8W99jTdJQmF7RlwVFDhcAVMp jivikxvKTi0gkPmc6AIZWUANB251BsJqpaEViEw244Me1IMC6u9gQ9upAJISSk6Tq/QA dn/R2ITXHNC91GEO7H2b9YEjp0Jh+x5EDsjunZZOmyOxUy7plLcQr2sVrF6ewvXdW5lF JxSLngf1HkuAUlGX5DBNFwqyLD2m/t/mGLhJHIZik1zJRZkm34YXhX0gPgVkHjxtr19E U/yg== X-Gm-Message-State: ANoB5pn6ogAXbafItMlpvuB74FmZws35qPOHo+Nxk1SsUFLuZiS8DIXL LqicYAmACyLCBYaLVj42Binzig== X-Google-Smtp-Source: AA0mqf7b0u4fMyVn4T4SA6gK9tegmyToXHD4YloJOGEkpHADV74LkQevFwQgOuQS3pHZCjrP/I7xgg== X-Received: by 2002:a05:6102:3e0d:b0:3b1:574e:2114 with SMTP id j13-20020a0561023e0d00b003b1574e2114mr10885698vsv.27.1670863987322; Mon, 12 Dec 2022 08:53:07 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-8c5e-02dc-44a6-fa90.res6.spectrum.com. [2603:6081:7b00:6400:8c5e:2dc:44a6:fa90]) by smtp.gmail.com with ESMTPSA id k12-20020a05620a414c00b006e42a8e9f9bsm6138696qko.121.2022.12.12.08.53.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 08:53:06 -0800 (PST) Date: Mon, 12 Dec 2022 11:53:04 -0500 From: Tom Rini To: Macpaul Lin Cc: Chunfeng Yun , "fparent @ baylibre . com" , "marex @ denx . de" , "sjg @ chromium . org" , "marcel . ziswiler @ toradex . com" , "aouledameur @ baylibre . com" , "frieder . schrempf @ kontron . de" , "philippe . reynes @ softathome . com" , "u-boot @ lists . denx . de" , GSS_MTK_Uboot_upstream , "william . zhang @ broadcom . com" , "samuel @ sholland . org" , "festevam @ denx . de" , Weijie Gao , Ryder Lee , "paul . liu @ linaro . org" , Miles Chen , Bear Wang , Pablo Sun , Macpaul Lin Subject: Re: [PATCH v3 2/2] board: mediatek: add mt8195 demo board Message-ID: <20221212165304.GA2141545@bill-the-cat> References: <20221108032149.22447-1-macpaul.lin@mediatek.com> <20221110073453.28110-1-macpaul.lin@mediatek.com> <20221110073453.28110-2-macpaul.lin@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rwEMma7ioTxnRzrJ" Content-Disposition: inline In-Reply-To: <20221110073453.28110-2-macpaul.lin@mediatek.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --rwEMma7ioTxnRzrJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 10, 2022 at 03:34:53PM +0800, Macpaul Lin wrote: > From: Fabien Parent >=20 > Add mt8195-demo board support. > This demo purpose board uses MediaTek's MT8195 SoC. >=20 > Signed-off-by: Fabien Parent > Signed-off-by: Amjad Ouled-Ameur > Signed-off-by: Macpaul Lin [snip] > +#include > + > +#define CONFIG_SYS_NS16550_SERIAL > +#define CONFIG_SYS_NS16550_REG_SIZE -4 > +#define CONFIG_SYS_NS16550_MEM32 > +#define CONFIG_SYS_NS16550_COM1 0x11002000 > +#define CONFIG_SYS_NS16550_CLK 26000000 This is unused, I believe. But when trying to build with current next I get: Error: Load Address must be set. Error: Bad parameters for image type Please rebase on top of current next and repost, thanks! --=20 Tom --rwEMma7ioTxnRzrJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOXXHAACgkQFHw5/5Y0 tywMnAv/VJA8jTsGHsRsZOSZicHyAsX4Hnl/ciZidaV+YeRTPgm9P5N5kAtX9tFT gE6ER5731HAeCYqC8wMYrwLiXV5PD2IDTqMLazir0p2Uv04SHm6g85qOZapNRg0H kBv1wMNuDHZwSEhBjFksGAD5rnmOo1VGWLyNdRzyKlYehG8xxs3BTaCSAua35Q6u IEBinW+TKwBrxQ4gdHLbCJ1+xcsncLB16PHng1XkyzwFe5DJTJ7ElzCmiEwT1OsX f7BMgaNgYq0r0j+AKsP6Lw8nXEmFrJ1TGAL4Mi2G7kb1TCTFFoyUv6BpGHLH4NJR rndU1lSFxXVYb2vEvm1RqQxLVjLBHCfLHd/zHE2Pkcf6ligWK9yYpNGu818/q5IU YGJ6Iam2fe3HWjIiy+aiAkiAJ4daSm+OhhScCBqj5SXMRZYkwhGqYKRvBAq3fTuP 614oHS+8sgbZF/+djbkMIAHkafBTZasisRPTg65Fr/c0hv8IX9zoCmFTC1iIqMO+ sttRML28 =8lXd -----END PGP SIGNATURE----- --rwEMma7ioTxnRzrJ--