Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17D8BC4332F for ; Mon, 12 Dec 2022 18:53:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 89C5A851C2; Mon, 12 Dec 2022 19:53:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="RClzMBUE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0E1A885439; Mon, 12 Dec 2022 19:53:13 +0100 (CET) Received: from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com [IPv6:2607:f8b0:4864:20::e2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 943EA81A19 for ; Mon, 12 Dec 2022 19:53:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-vs1-xe2d.google.com with SMTP id h26so12235138vsr.5 for ; Mon, 12 Dec 2022 10:53:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=u65kO5D1cqhdhM4NPjv0LcLPYtLk65ZV+a259cSV2JA=; b=RClzMBUEnwXPtfZeXc7BxgNG2T5Bdq/HyUzVb0uPfHu256qRD77GFXtEy59QpLvrrZ hBAEtUHwNm90+hcjlxGhi+qMpr6Pzckx1H49lQz0A2qz5MFrqq7Xru2bYA5xV/Lmfwe8 3bXxxyZ9+UcBadFXiFLJBv84LfwZ+xjTn/im8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=u65kO5D1cqhdhM4NPjv0LcLPYtLk65ZV+a259cSV2JA=; b=lJwbmGvlWR4Gf9bpVw1zkk/O4JgPSlpNAcTU1P3HXVtjCkdEFnWBe2a2A1Jtps2CdH VZxvDLE/Hrfo2aSCSKANo5o3HKF8Zykx4Z5iP5lHUwPGPSd3FChFZnxOAgaYp+u7lZ8U KU2skXDd3s+dxot9UrxqggeczelsnBCyEPHuPuetVk7QXTb9gaZ9FvSHFZFo2SY5UvXS Y1207S1snDaP26KQzfB8l1ske04acRe1ZYX8i6tMR5/kQxo7Bvv6COW7T6HF6AtuXKTB arFbGZEAL4kwWihK+cGjc0cshJGVxmINw18EDcfCZ+TlCE2keYvw9MHuVWnFcIqxdnTp 7l5Q== X-Gm-Message-State: ANoB5pne1N3DCbOQUv8Emi3CD6suf1xlU2YE+oMt0MlK6vyUPmDIeqLq 2h0wZ2z8dYqduWVAvaZ8nyJsGw== X-Google-Smtp-Source: AA0mqf5eznWUp58wTTqLaJEx0S0uYNumT82wl81x+46N62FVsQPep7B89xSY/Gaq6H+ILGXi0i7+kQ== X-Received: by 2002:a67:fc45:0:b0:3b2:d3f2:63bd with SMTP id p5-20020a67fc45000000b003b2d3f263bdmr8041200vsq.29.1670871188295; Mon, 12 Dec 2022 10:53:08 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-8c5e-02dc-44a6-fa90.res6.spectrum.com. [2603:6081:7b00:6400:8c5e:2dc:44a6:fa90]) by smtp.gmail.com with ESMTPSA id bm25-20020a05620a199900b006fa4cac54a5sm6313976qkb.72.2022.12.12.10.53.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 10:53:07 -0800 (PST) Date: Mon, 12 Dec 2022 13:53:05 -0500 From: Tom Rini To: Macpaul Lin Cc: Chunfeng Yun , "fparent @ baylibre . com" , "marex @ denx . de" , "sjg @ chromium . org" , "marcel . ziswiler @ toradex . com" , "aouledameur @ baylibre . com" , "frieder . schrempf @ kontron . de" , "philippe . reynes @ softathome . com" , "u-boot @ lists . denx . de" , GSS_MTK_Uboot_upstream , "william . zhang @ broadcom . com" , "samuel @ sholland . org" , "festevam @ denx . de" , Weijie Gao , Ryder Lee , "paul . liu @ linaro . org" , Miles Chen , Bear Wang , Pablo Sun , Macpaul Lin Subject: Re: [PATCH v3 2/2] board: mediatek: add mt8195 demo board Message-ID: <20221212185305.GA3787616@bill-the-cat> References: <20221108032149.22447-1-macpaul.lin@mediatek.com> <20221110073453.28110-1-macpaul.lin@mediatek.com> <20221110073453.28110-2-macpaul.lin@mediatek.com> <20221212165304.GA2141545@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VqeFf7QnnCuntuSs" Content-Disposition: inline In-Reply-To: <20221212165304.GA2141545@bill-the-cat> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --VqeFf7QnnCuntuSs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 12, 2022 at 11:53:04AM -0500, Tom Rini wrote: > On Thu, Nov 10, 2022 at 03:34:53PM +0800, Macpaul Lin wrote: >=20 > > From: Fabien Parent > >=20 > > Add mt8195-demo board support. > > This demo purpose board uses MediaTek's MT8195 SoC. > >=20 > > Signed-off-by: Fabien Parent > > Signed-off-by: Amjad Ouled-Ameur > > Signed-off-by: Macpaul Lin > [snip] > > +#include > > + > > +#define CONFIG_SYS_NS16550_SERIAL > > +#define CONFIG_SYS_NS16550_REG_SIZE -4 > > +#define CONFIG_SYS_NS16550_MEM32 > > +#define CONFIG_SYS_NS16550_COM1 0x11002000 > > +#define CONFIG_SYS_NS16550_CLK 26000000 >=20 > This is unused, I believe. But when trying to build with current next I > get: > Error: Load Address must be set. > Error: Bad parameters for image type >=20 > Please rebase on top of current next and repost, thanks! Sorry for the noise, this failed due to another patch that needs to be reworked instead. --=20 Tom --VqeFf7QnnCuntuSs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOXeI4ACgkQFHw5/5Y0 tyzjhgv/bXSBCVKgi5YcFHBp+AgJai6awr1w72VgsS8CpTVZREie2ZS6GMpeGgEY zFDk+j4W4P8cu/xwHW0dR9LsljXbRdtwQhJoEHSRe5ediJws65f78YI7pGHs9Mx3 jACHmQwgF8cLOluKvQXFyviu+pWdOc5e/mlUmgYzPn1chER9faHU3KTmXfMv/Cin 5ubDV1nGh9JoleIffKvoVgLTQd5idArnE7Kby2Mq19D6Rch6mzNaeUzti9HiiUge 7ydjcR1+Xj3HoPLW/ESAYLX3CFyOmYT6PDgl1c+K3dZMRndZQ10kQt2KeYsZ79Qv dpwnd6bGVLKgZr99h3y5DvPWrKmBca/AOKZJdKUZDqWEaFyBTH9vVgIZwYvWgvVI MKb6DMPDXX15pcZsIJKwvC/mJz8wZtFTqUQ5uR+ziSAy5L1j2zFqk4Lgg2vE7Esx 4vtRYVe0GcFFv9jSLySvv/xOlwpP2OaFHPyVT2wTAmNe+IoNiFhlwZ/hGVGWorbr JEDE49Ud =w2QZ -----END PGP SIGNATURE----- --VqeFf7QnnCuntuSs--