Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DACAC00145 for ; Mon, 12 Dec 2022 19:02:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A940E85455; Mon, 12 Dec 2022 20:02:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="IApbElsx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B53CF85440; Mon, 12 Dec 2022 20:02:27 +0100 (CET) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D994185439 for ; Mon, 12 Dec 2022 20:02:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x832.google.com with SMTP id jr11so9197360qtb.7 for ; Mon, 12 Dec 2022 11:02:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AQKz3zYKRh/bP/msYf1caYOo8fbP3lJCqMT/1X6AT+E=; b=IApbElsxP2gy/ZOGAUW7qMk4TqVaY1iIUwipPqLK/yKwTQ2SsANyTR1kTH7ijXZYrd 7FvihQUSjIWAAmPJ6hTH/NEl1T2VlVo3cvu96Y7WLGnJrRju1DIDAyy0ktJkKnkcaO4B uXRNFMkrgjS6r6d6v+6Oo99PoQjnW8FLxfY2E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AQKz3zYKRh/bP/msYf1caYOo8fbP3lJCqMT/1X6AT+E=; b=bc8OIGADozHk4G3TTA9FiZm/7STTfjOUEkH2gvcIMuVreZWudkXm/qCSX/p8Jj1lPt JSUXcQYUMAoFVUqSiFxGV3kA6t1W+rrasr2B9dzGT5plYgt7n5EJkClQoLPQEUUS7nNM qKM8W/GRa3QysxldsCnseK9m4UneegNus1UNzWGQ3vAtcnMEVfyMPt6OebsIVj+bfnfj x3mAECQD30r5XFOj9npvKLh2khqLALKQpdC0DH9IcRyxT1/EqQQhPH9z7hD7qNcxbQfS rPdqeri/cjaNkf8PjMGI1Or0NhVZR7iGWFvvTcHNyY5VrtY5RZHfYMPBYA0qSKM/T0An qiWg== X-Gm-Message-State: ANoB5pkoDpyKh9TIvWG5U3LtJ6cXBdmKFcX5P60kAaqdgckedwyKqMr6 Yq9/YgkjfzPGYKMIEfD1Kp8aQg== X-Google-Smtp-Source: AA0mqf6rg8JVGSu15DACjuOlOtLfwfXc7kl4MCcdChei/iFc4dObAKzWkAoyzT89DIXp1XIY7uPeng== X-Received: by 2002:a05:622a:1f8b:b0:39c:da20:d49a with SMTP id cb11-20020a05622a1f8b00b0039cda20d49amr23969984qtb.47.1670871742623; Mon, 12 Dec 2022 11:02:22 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-8c5e-02dc-44a6-fa90.res6.spectrum.com. [2603:6081:7b00:6400:8c5e:2dc:44a6:fa90]) by smtp.gmail.com with ESMTPSA id d1-20020ac84e21000000b003a7e9db074asm6124449qtw.67.2022.12.12.11.02.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 11:02:22 -0800 (PST) Date: Mon, 12 Dec 2022 14:02:19 -0500 From: Tom Rini To: Macpaul Lin Cc: Chunfeng Yun , "fparent @ baylibre . com" , "marex @ denx . de" , "sjg @ chromium . org" , "marcel . ziswiler @ toradex . com" , "aouledameur @ baylibre . com" , "frieder . schrempf @ kontron . de" , "philippe . reynes @ softathome . com" , "u-boot @ lists . denx . de" , GSS_MTK_Uboot_upstream , "william . zhang @ broadcom . com" , "samuel @ sholland . org" , "festevam @ denx . de" , Weijie Gao , Ryder Lee , "paul . liu @ linaro . org" , Miles Chen , Bear Wang , Pablo Sun , Macpaul Lin Subject: Re: [PATCH v3 2/2] board: mediatek: add mt8195 demo board Message-ID: <20221212190219.GC3787616@bill-the-cat> References: <20221108032149.22447-1-macpaul.lin@mediatek.com> <20221110073453.28110-1-macpaul.lin@mediatek.com> <20221110073453.28110-2-macpaul.lin@mediatek.com> <20221212165304.GA2141545@bill-the-cat> <20221212185305.GA3787616@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hzZFXzeAf5Qcld9Q" Content-Disposition: inline In-Reply-To: <20221212185305.GA3787616@bill-the-cat> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --hzZFXzeAf5Qcld9Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 12, 2022 at 01:53:05PM -0500, Tom Rini wrote: > On Mon, Dec 12, 2022 at 11:53:04AM -0500, Tom Rini wrote: > > On Thu, Nov 10, 2022 at 03:34:53PM +0800, Macpaul Lin wrote: > >=20 > > > From: Fabien Parent > > >=20 > > > Add mt8195-demo board support. > > > This demo purpose board uses MediaTek's MT8195 SoC. > > >=20 > > > Signed-off-by: Fabien Parent > > > Signed-off-by: Amjad Ouled-Ameur > > > Signed-off-by: Macpaul Lin > > [snip] > > > +#include > > > + > > > +#define CONFIG_SYS_NS16550_SERIAL > > > +#define CONFIG_SYS_NS16550_REG_SIZE -4 > > > +#define CONFIG_SYS_NS16550_MEM32 > > > +#define CONFIG_SYS_NS16550_COM1 0x11002000 > > > +#define CONFIG_SYS_NS16550_CLK 26000000 > >=20 > > This is unused, I believe. But when trying to build with current next I > > get: > > Error: Load Address must be set. > > Error: Bad parameters for image type > >=20 > > Please rebase on top of current next and repost, thanks! >=20 > Sorry for the noise, this failed due to another patch that needs to be > reworked instead. Welp, I should have finished my re-testing. The patch that broke phycore-rk3288 and I assumed broke this platform too, did not break this platform, there's still some other problem here. --=20 Tom --hzZFXzeAf5Qcld9Q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOXersACgkQFHw5/5Y0 tywMPwv7Bxkp1nEzgb75o+2wnu/aQY8KCageSLrEyJWEWTI/ri7yB+VadYDhbjPi wRVn/TRXVZ0u/mpEthLysbjvkcf9j8ZicZQrJIBJR0vFcyzFxDRHQ1J2/P0Hjd/4 20ukOC9hAbpX3hbfpcRKiQbji4drd3gn2HFY9DLNBxh5IXZf2sey0VRHraVgjeF/ LbMHT/fAFU1uqGUfp9gYpY8W5GyWjtQMKXSoKseMi0WWX2Uj9rbVnc0FnvQh+XgK eFw5/af25PNUAgtxRE7YI8YWuaXzTfAwR0jgSBy7hY5oevp+fb2Aw6/mqTJ1Js4S 4d9C2cmjNxlqVv7Lk59DqECOO5Vu1PJnHtCAtZk/5ta81dt3YW6n+oAGtH6L7f0l GDgJ5zIXmGW0FMA2weNJ6CIOVb35OhVZpflOrS1ZI24YdxKR3DWitl3u6MKXZ45V o4e6DgdUAtPy9iYmeO9yMiUnjZAdlwRzDY9qWzqnNQ7vQ8q0xNoJbPdSVQ7GJjV/ qbtMzcs9 =8Gy6 -----END PGP SIGNATURE----- --hzZFXzeAf5Qcld9Q--