Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AB89C4332F for ; Mon, 12 Dec 2022 23:43:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A576385207; Tue, 13 Dec 2022 00:43:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="CNPdu8D+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0F7548431A; Tue, 13 Dec 2022 00:43:44 +0100 (CET) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 53C1D8431A for ; Tue, 13 Dec 2022 00:43:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82c.google.com with SMTP id c7so2956504qtw.8 for ; Mon, 12 Dec 2022 15:43:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iz2vg7rBQYYyhz0hVcQAody2nWghZhORI/CAc2Ak8ZY=; b=CNPdu8D+IrJ7t/6BaBXkGzu3T0yTHbU9X6gFKiN/Br5jnmv6YlkKnq7oT4DEXMxb/o 9gnDCHRrTyiscOfsG+jFHK61NEoYMYU3WkOXRdcHqwgUWJgzOqWkc/L9eZIziPo2wGf9 ApOBnivEXGJb6RSdZXAG7wL79G6HhaJScVY3k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iz2vg7rBQYYyhz0hVcQAody2nWghZhORI/CAc2Ak8ZY=; b=YLQAhqNyvJaBDatVctH7bgIN3FWWq1xZbF4lt4RDJ3ewwAGCWbvdCu/T5cZWa1EnXo +qvtoMly1+TcQmRtButhMfXzm0jfKksZFQRC3G2aqQLhRNB1peSCunolil5y9iy8o60l Su8jlgVnVMYEygaJHjUl0qfpT3Bc5iJ9STHmljWFPo0jUS5Ny3KCH1JRd6yqgJs7CqXw jAdOj3HBRxW6Y20ayqP5IIPElStZjox1DMmCHSbBSRMVCQ20yS7c8hDsgAdGE6Z77aV1 lYmJEAPd2ss+XsTqKD3KN2x/Ox7Ce/D94GlunRv0kLQireVpwL9fR7sxabbdTVqi0wab fZYA== X-Gm-Message-State: ANoB5pn/mdiOEAx2Rwb7h6MY/m4QXULi14AbBuisFHc4vTR2dzf0NqSf ib+KL4ZGdqiAZLYmuDOKzS/Pag== X-Google-Smtp-Source: AA0mqf5voXg52hRRm5eUI737rhn0vdrjfpzhnDDNePVh3bAjFOgoWrVJli00H9ps9jXpDZvcALfVDQ== X-Received: by 2002:ac8:474b:0:b0:3a7:ef75:62c3 with SMTP id k11-20020ac8474b000000b003a7ef7562c3mr1546656qtp.44.1670888619027; Mon, 12 Dec 2022 15:43:39 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-8c5e-02dc-44a6-fa90.res6.spectrum.com. [2603:6081:7b00:6400:8c5e:2dc:44a6:fa90]) by smtp.gmail.com with ESMTPSA id l5-20020a05620a28c500b006fa84082b6dsm6865472qkp.128.2022.12.12.15.43.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 15:43:38 -0800 (PST) Date: Mon, 12 Dec 2022 18:43:36 -0500 From: Tom Rini To: Simon Glass Cc: u-boot@lists.denx.de, Peter Robinson Subject: Re: [PATCH] Makefile: With BINMAN_ALLOW_MISSING=1 don't error on missing Message-ID: <20221212234336.GP3787616@bill-the-cat> References: <20221206020336.315465-1-trini@konsulko.com> <20221206150337.GK3787616@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aMD8KmabcuokxXDr" Content-Disposition: inline In-Reply-To: <20221206150337.GK3787616@bill-the-cat> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --aMD8KmabcuokxXDr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 06, 2022 at 10:03:37AM -0500, Tom Rini wrote: > On Tue, Dec 06, 2022 at 03:36:49PM +1300, Simon Glass wrote: > > Hi Tom, > >=20 > > On Tue, 6 Dec 2022 at 15:03, Tom Rini wrote: > > > > > > When the user builds with BINMAN_ALLOW_MISSING=3D1 they're explicitly > > > setting the flag to allow for additional binaries to be missing and so > > > have acknowledged the output might not work. In this case we want to > > > default to not passing a non-zero exit code. > > > > > > Cc: Simon Glass > > > Reported-by: Peter Robinson > > > Signed-off-by: Tom Rini > > > --- > > > This passes CI as-is: > > > https://source.denx.de/u-boot/u-boot/-/pipelines/14340 > > > --- > > > Makefile | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/Makefile b/Makefile > > > index de5746399a63..03de1da1bfd0 100644 > > > --- a/Makefile > > > +++ b/Makefile > > > @@ -1334,7 +1334,7 @@ cmd_binman =3D $(srctree)/tools/binman/binman $= (if $(BINMAN_DEBUG),-D) \ > > > --toolpath $(objtree)/tools \ > > > $(if $(BINMAN_VERBOSE),-v$(BINMAN_VERBOSE)) \ > > > build -u -d u-boot.dtb -O . -m \ > > > - $(if $(BINMAN_ALLOW_MISSING),--allow-missing --fake-e= xt-blobs) \ > > > + $(if $(BINMAN_ALLOW_MISSING),--allow-missing --ignore= -missing) \ > > > -I . -I $(srctree) -I $(srctree)/board/$(BOARDDIR) \ > > > -I arch/$(ARCH)/dts -a of-list=3D$(CONFIG_OF_LIST) \ > > > $(foreach f,$(BINMAN_INDIRS),-I $(f)) \ > > > -- > > > 2.25.1 > > > > >=20 > > I believe we need the --fake-ext-blobs flag as well, since otherwise > > boards which use tools (like mkimage) on things that don't exist will > > not work. >=20 > So, we need to list out all the use cases perhaps, as we had missed one > before. In my mind we have: > - Board requires 1 or more blobs, developer will be running this on > hardware, expects output from U-Boot 'make' (or buildman) to boot. > Blobs must be present or non-zero exist status by default. > We didn't have this before, and we do now. > - Board requires 1 or more blobs AND has optional blobs, will be running > this on hardware, expects output from U-Boot 'make' (or buildman) to > boot. This is the case we had missed before as allwinner requires bl31 > and has optional PMIC firmware. This is the case Peter reported and we > had missed before, which this patch allows for, with the caveat that > if you forget BL31 you're not going to boot and make won't complain > exit-code wise. Another way to resolve this would be a property in the > binman node to mark a blob as optional and warn if missing, rather > than error if missing. > - Board requires 1 or more blobs, output will NOT be run. This is the CI > case and the compile testing lots of board cases. This is what CI > passes still, with the above. > - Board requires 1 or more blobs, developer will be running this on > hardware, BUT will be injecting the blobs later on. I think this is > the use case you're talking about? Simon, can you test this last case by chance? I think that's the one that's unclear about if this patch breaks or not and I want to know if I need to respin to still include the fake blobs flag still too or not. Or does anyone else use this case and can test? --=20 Tom --aMD8KmabcuokxXDr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOXvKUACgkQFHw5/5Y0 tyw3kgwAqNzTq2szY6JuNOt0c6T/QDJo8x51txbLdr65kRb05ODcFND7W4/6GxMn 9UajRrS6ifdUta6s4l9cvU5Cf635mOJiv1PZ2bOyxaXte0H2Vv18m/EgQhc3T0U7 yDSJtL9CohoDZo/xiS760fF1l4Eyzko6EcRACzJMUOgykzoCpPCUBp9DOH76ZyJG GGjXuI9No9RXUFdorXfRYfts8Sny8BLjs/XKVzLUoRoBPRHQifDYgVKyqSmL39gG sCKeHWUzgTHFBZGGCuFGPY6pCtgrnf1Qs4jiT3auhyR28HTPyEmJjQX7LzEJD/Ru OWpa1xbD08AaLikfYFGoRoFxv/Wna6k4TAektDWn02c1wa1jQFFthrMu290V/SH4 ZzQCG0QwMkm/jQ60IQa99PvVlxpfsx6D3CqhS6rrAh69A+efIpOgwAMu059w+sbE xjHnFIMUl/mg+ctY2+hqbkJbdYmEFUii97fFfxYGwqDa5c9JFz+Ih0lpnuhGuerO KeVYvZdQ =lfqP -----END PGP SIGNATURE----- --aMD8KmabcuokxXDr--