Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 447C1C4332F for ; Tue, 13 Dec 2022 14:22:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9215F854A2; Tue, 13 Dec 2022 15:22:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="bXrK3SWF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 520DD84F66; Tue, 13 Dec 2022 15:22:56 +0100 (CET) Received: from mail-vs1-xe34.google.com (mail-vs1-xe34.google.com [IPv6:2607:f8b0:4864:20::e34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 54D0D854A2 for ; Tue, 13 Dec 2022 15:22:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-vs1-xe34.google.com with SMTP id c184so14751788vsc.3 for ; Tue, 13 Dec 2022 06:22:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+wlKCevwGuprw4Fe6xnhWBpzFBDi3UDsNwhuMuV7iLo=; b=bXrK3SWFn87wNCMELYY/I7hlZgUe/vNpsusEXzdteoHTCiGCh/PegEoOdeKucOXYRA a/s1stYj6rODk3Bvky5054iqU5S1N7SXbybBUyz6JmQ39emzNFsWe4zG7kxRmlqSTito SsQhy0PiRquJZBAQo2y4uu/4qEh2TtOsvv72Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+wlKCevwGuprw4Fe6xnhWBpzFBDi3UDsNwhuMuV7iLo=; b=W4EuYn0eKOi6nYanjbzsU27szrTL+SufR7n4HDo38cbjMb0NRun6Pt4yj0oEbG5UV7 4/XQLMSO+6BptPBjlHcrMBhaPpPstM/KFJQZaDQoH2Vwulu6jR11JNUytGu14QbGBJF7 azTY7hdPAnvNcLBxS23REvJFfZUGSKmcz6L2CbPpkQ08MNeIUasLAyWm+8MiOtFJOXDv 3kd1p5wjRSnrJLh//3CMBfOSsx4er1uvAfo99Y44Hp/VlgXrtBSiu0y5l0TvnarylRAJ pEDcLYVdix1Qh20jTrMfEyhG6nX4kDnQVvrkZn6vQiGiRy52IFba4RWTMDgcq+aclWhS i/wA== X-Gm-Message-State: ANoB5pkS8a1Uk+G4F5D8vJ5REOPlJTMvJU9kYrblSMu5rDK8+jhx3V8A jQpmhYuVjmQuTI/40iiMvi6PEA== X-Google-Smtp-Source: AA0mqf48I7Ze4OJluE8Z1/KQPrK6yQPCJDyy9M8h6VioSKWQr+FBSKrQoicEfMU0lNqHAggTk8xk3g== X-Received: by 2002:a67:efdb:0:b0:3b0:796c:7a37 with SMTP id s27-20020a67efdb000000b003b0796c7a37mr13178420vsp.28.1670941372015; Tue, 13 Dec 2022 06:22:52 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-09de-b540-f7da-b28e.res6.spectrum.com. [2603:6081:7b00:6400:9de:b540:f7da:b28e]) by smtp.gmail.com with ESMTPSA id k5-20020a05620a414500b006fc7c5d456asm7767206qko.136.2022.12.13.06.22.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 06:22:51 -0800 (PST) Date: Tue, 13 Dec 2022 09:22:49 -0500 From: Tom Rini To: Neil Armstrong Cc: Quentin Schulz , u-boot@lists.denx.de, Patrick Delaunay Subject: Re: [PATCH] Revert "cmd: pxe: use strdup to copy config" et al Message-ID: <20221213142249.GV3787616@bill-the-cat> References: <20221213133748.1283705-1-trini@konsulko.com> <7ad03c00-30ab-6dbc-78bb-4265bc598476@theobroma-systems.com> <97435aa9-f263-9716-a2b9-c31cefd54b89@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4Le1Tldl75UwwRuo" Content-Disposition: inline In-Reply-To: <97435aa9-f263-9716-a2b9-c31cefd54b89@linaro.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --4Le1Tldl75UwwRuo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 13, 2022 at 03:14:43PM +0100, Neil Armstrong wrote: > On 13/12/2022 14:45, Quentin Schulz wrote: > > Hi Tom, > >=20 > > On 12/13/22 14:37, Tom Rini wrote: > > > This reverts commits > > > 51c5c28af59c ("cmd: pxe: use strdup to copy config"), > > > a5dacef7380e ("cmd: pxe: support INITRD and FDT selection with FIT") = and > > > f723c2778cf8 ("cmd: pxe: reorder kernel treatment in label_boot"). > > >=20 > > > As reported by Quentin Schulz, this introduces a regression with > > > previously generated and working extlinux.conf files. > > >=20 >=20 > The situation is much complex than that: > - Since the commit d5ba6188dfbf ("cmd: pxe_utils: Check fdtcontroladdr in= label_boot"),\ > all the extlinux.conf with only "KERNEL /fitImage" don't work anymore. > Those are generated by Poky/OE WIC bootimg-partition bootloader partition= generator. > - With the changeset introduced by Patrick, this doesn't permit booting > those images, but it solves the issue by explicitly specifying we want to > get the dtb from the fitImage with "FDT /fitImage", which is smart. > - If we start generating extlinux.conf with "FDT /fitImage", those won't > boot on previous u-boot versions (as I reported in the second link shared= by Quentin). >=20 > But honestly, as of today we need to patch by reverting d5ba6188dfbf to > use extlinux.conf with fitImage, so I'll vote to keep this solution and > go forward and implement the change in the Poky/OE bootimg-partition > bootloader partition generator with perhaps a check on the u-boot version. So, I'll post a revert for d5ba6188dfbf in a moment then, which of these should I use for Link's > > For reference: > > https://lore.kernel.org/u-boot/b7e891d1-d134-b489-eb2d-6125d4c7b6c6@the= obroma-systems.com/ for my worry > > https://lore.kernel.org/u-boot/f0dd213c-4a34-926d-3f3b-f2ed49bb92c3@lin= aro.org/ for confirmation from Neil it is breaking existing extlinux.conf Or something else? And then to be clear, you're saying the 3 changes here don't break anything really? --=20 Tom --4Le1Tldl75UwwRuo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOYirYACgkQFHw5/5Y0 tyyqfAv/SQtGGYr7mKt2VWMzpvu3dhTCMtCdyfN8tDYgtI35M05RCc0dhNboPjrU m0s9Ji8wYBUKdgiJQUZ2gwVsgrOCpOjJP8ZT4Jc0Tjf9R4Ru0pFu/KZWEHdaIB+h HEhIm11y803cOSNxyOKLqfsYcePn4pP5Yuxhr40P7gCHAFcXBYQlr1pUkfkZelgu pu41Z4i7kJltZERWpeQ1PgfDMrTycq9CeSrp8J7icq7ooc98B3yivbemCIFckwJ4 RTI8ky6KrbRMnAd8+sdTXrTBovybKhkxo9pWsszW+1Eh5QXUydynoQ4dh1juJQ1p wRugYrrENOphndQk38AC+SylAIiwOD8Fk7+qCQY3i4W60u2vmF7S+hoeJtNh+WwX 3jGIfcQggA26QwXpleY6qOlpDOMnsfsMvBRELRFXXxSh+bM/V/CzJuQnCTxWUITL omuh/RPGNaO9jG0wjQQIOabHeXykbCJHW3bsHV2+XrZIQdPaEIef3XBGsiY/37qN igvmSeOd =jTEY -----END PGP SIGNATURE----- --4Le1Tldl75UwwRuo--