Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 120D5C4332F for ; Tue, 13 Dec 2022 16:39:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DD66D850B7; Tue, 13 Dec 2022 17:39:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Ds2Yuz5x"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2F4BB85306; Tue, 13 Dec 2022 17:39:42 +0100 (CET) Received: from mail-vs1-xe36.google.com (mail-vs1-xe36.google.com [IPv6:2607:f8b0:4864:20::e36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2284885003 for ; Tue, 13 Dec 2022 17:39:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-vs1-xe36.google.com with SMTP id k185so15184238vsc.2 for ; Tue, 13 Dec 2022 08:39:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UCL+S6eteO/RwBjhoUWvEJnfjwhRO8PX1KGEjktdOx8=; b=Ds2Yuz5xaGnxgwd1ee4bdMcgFDmiMkPriHgclk2PYqxo6xwQAPOIE218jsp9Hz6/ls Qmi5A5Mi8V1qpLSfIlo3qLWF72AadHUikeAsUYSE1RVZFwaQwZrt87OPbkFgu6lJmwmU Nl+ydCmUhxLvDWmvXE916Y44ilDek7wmrTmVM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UCL+S6eteO/RwBjhoUWvEJnfjwhRO8PX1KGEjktdOx8=; b=JGBI/kyEktO5UoFLNlcEvbRNzg3Bl1RM7FQkVs5Fxj/KqTGzSN9tZ8yneITTSgRfXv 35SCDSS2BllZkfbTuMn+uOkCtqdIHzN1i+U0VLZNg8QOwWQvINTy8B3X3xYrMOs5Q8ai AuZ+PVf6HQclwoy6Kvo147/4FNkXrAQFL+yAR6HT1CgwAvbp+NkNuNbnOtv5baW5zkZI VamfDNU41OrpNnF9JQEzxn5Wwc8SYj2u0OMVzgn6IB2nlYBoWOmhgQCg+ORbS7zBPnDH iqYYInVJ9Orw5XKl9urITlW8c3uS05rDOYF/ODJo5k3VUUCA+thOqXZBcUKpNgYKMLIu jYYw== X-Gm-Message-State: ANoB5pnAPrNpOUQXC4Dk9s6w5IyH1YVXbnLj53fPf2KE58RW45voj/SD QQb9KcNFyL4VV6rAOZu7XRrzlg== X-Google-Smtp-Source: AA0mqf6O1L+s4OGj6CVPHzespEtcDKJIvxm8Hqz+Fb+e28Dhedqz2P0K9blNaQIj/n8y0PkdvFN6xA== X-Received: by 2002:a05:6102:149e:b0:3b5:1986:1914 with SMTP id d30-20020a056102149e00b003b519861914mr1752780vsv.17.1670949577827; Tue, 13 Dec 2022 08:39:37 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-09de-b540-f7da-b28e.res6.spectrum.com. [2603:6081:7b00:6400:9de:b540:f7da:b28e]) by smtp.gmail.com with ESMTPSA id f9-20020a05620a280900b006ff8a122a1asm5896040qkp.78.2022.12.13.08.39.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 08:39:37 -0800 (PST) Date: Tue, 13 Dec 2022 11:39:35 -0500 From: Tom Rini To: Simon Glass Cc: u-boot@lists.denx.de, Peter Robinson Subject: Re: [PATCH] Makefile: With BINMAN_ALLOW_MISSING=1 don't error on missing Message-ID: <20221213163935.GC3787616@bill-the-cat> References: <20221206020336.315465-1-trini@konsulko.com> <20221206150337.GK3787616@bill-the-cat> <20221212234336.GP3787616@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="c1ou7aKDSrDtRQqo" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --c1ou7aKDSrDtRQqo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 12, 2022 at 10:59:01PM -0700, Simon Glass wrote: > Hi Tom, >=20 > On Mon, 12 Dec 2022 at 16:43, Tom Rini wrote: > > > > On Tue, Dec 06, 2022 at 10:03:37AM -0500, Tom Rini wrote: > > > On Tue, Dec 06, 2022 at 03:36:49PM +1300, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Tue, 6 Dec 2022 at 15:03, Tom Rini wrote: > > > > > > > > > > When the user builds with BINMAN_ALLOW_MISSING=3D1 they're explic= itly > > > > > setting the flag to allow for additional binaries to be missing a= nd so > > > > > have acknowledged the output might not work. In this case we want= to > > > > > default to not passing a non-zero exit code. > > > > > > > > > > Cc: Simon Glass > > > > > Reported-by: Peter Robinson > > > > > Signed-off-by: Tom Rini > > > > > --- > > > > > This passes CI as-is: > > > > > https://source.denx.de/u-boot/u-boot/-/pipelines/14340 > > > > > --- > > > > > Makefile | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/Makefile b/Makefile > > > > > index de5746399a63..03de1da1bfd0 100644 > > > > > --- a/Makefile > > > > > +++ b/Makefile > > > > > @@ -1334,7 +1334,7 @@ cmd_binman =3D $(srctree)/tools/binman/binm= an $(if $(BINMAN_DEBUG),-D) \ > > > > > --toolpath $(objtree)/tools \ > > > > > $(if $(BINMAN_VERBOSE),-v$(BINMAN_VERBOSE)) \ > > > > > build -u -d u-boot.dtb -O . -m \ > > > > > - $(if $(BINMAN_ALLOW_MISSING),--allow-missing --fa= ke-ext-blobs) \ > > > > > + $(if $(BINMAN_ALLOW_MISSING),--allow-missing --ig= nore-missing) \ > > > > > -I . -I $(srctree) -I $(srctree)/board/$(BOARDDIR= ) \ > > > > > -I arch/$(ARCH)/dts -a of-list=3D$(CONFIG_OF_LIST= ) \ > > > > > $(foreach f,$(BINMAN_INDIRS),-I $(f)) \ > > > > > -- > > > > > 2.25.1 > > > > > > > > > > > > > I believe we need the --fake-ext-blobs flag as well, since otherwise > > > > boards which use tools (like mkimage) on things that don't exist wi= ll > > > > not work. > > > > > > So, we need to list out all the use cases perhaps, as we had missed o= ne > > > before. In my mind we have: > > > - Board requires 1 or more blobs, developer will be running this on > > > hardware, expects output from U-Boot 'make' (or buildman) to boot. > > > Blobs must be present or non-zero exist status by default. > > > We didn't have this before, and we do now. > > > - Board requires 1 or more blobs AND has optional blobs, will be runn= ing > > > this on hardware, expects output from U-Boot 'make' (or buildman) to > > > boot. This is the case we had missed before as allwinner requires b= l31 > > > and has optional PMIC firmware. This is the case Peter reported and= we > > > had missed before, which this patch allows for, with the caveat that > > > if you forget BL31 you're not going to boot and make won't complain > > > exit-code wise. Another way to resolve this would be a property in = the > > > binman node to mark a blob as optional and warn if missing, rather > > > than error if missing. > > > - Board requires 1 or more blobs, output will NOT be run. This is the= CI > > > case and the compile testing lots of board cases. This is what CI > > > passes still, with the above. > > > - Board requires 1 or more blobs, developer will be running this on > > > hardware, BUT will be injecting the blobs later on. I think this is > > > the use case you're talking about? > > > > Simon, can you test this last case by chance? I think that's the one > > that's unclear about if this patch breaks or not and I want to know if I > > need to respin to still include the fake blobs flag still too or not. > > Or does anyone else use this case and can test? >=20 > Yes I have your email printed out but travel and family things have > made it hard to get to it. I do think you need the flag, but the extra > case you mention need another look and probably a test, as you say. Yeah, understandable. My plan is to take this patch before the next -rc, so Fedora won't be broken and if we need the other flag (and I'll check in before release) we can follow up there and have a fixes tag on top of this one here. --=20 Tom --c1ou7aKDSrDtRQqo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOYqscACgkQFHw5/5Y0 tyzOCQv+OK/Ne/p58rgJrXjMVJbgEJ5BMUkVap2wqayQZqH4dmghARuOCbMhJDU+ FmQ2L44PV5LwzAm/QUuLAwpIH/Ulc7lw09Dz9FeaxFZ3umsbS/33i3G3BJLOiC8k wspFA4kwGw1Z4zeJL1jRRYlcNidYxgBxeChbyCEeqwf0NMHhuzyKD3S+ZbI+w+Dc y4rgqnl/QwfiwQ3XT1e5kym5B/bB3OL3bxKM/S3CgdUTTzRcqV01jnd7hPGW5g46 BjpRD+U06RYAkS3JHt/FUhN6I1/6ijzNHyG8mZxKqcz9EgWI0wSAUahT0TuXFo7G QxIY0XT4EEH9UFxdfqVksp/TD5jX0O1H/o9QQKE3067XazddHiAdc18EOnAPGN5M A7nry1ysZuLjhQxdVNxhfzfz7xAHhsjEZH+DxRexWvDnEhC9LI3WFo8UzfC0e8lv yw6YWzIvIFaPTalegh3Q1ZpFnYfC0nyVR41F7QqtFrIHifMNG+rxlcOaJb7L069I sX8SLd8+ =BrbI -----END PGP SIGNATURE----- --c1ou7aKDSrDtRQqo--