Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A59BEC4332F for ; Thu, 15 Dec 2022 06:37:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Byut7YcimaFNIYreP3dtkhWijjUQsQ9fX4n3lswcHjI=; b=M+B2qUPMwLV+PO iNyvfT06s0R1fe2WwT3frww+Il4UmtQoOKh4LMJemmd9atxZ33w0vVBuM7pX9yrsE4x9cDNQm2u8B M97nQ9eNHewPGy8wTiFeKGCOM8luPWvtOvt2DHGu0qtIjW2bPi6J7PT5DeNaGXS8sYG8pBOSWHW3h PFaN227M0zfq7GN9AgxqEFFbSEqm9CbFHstBu/JHWZJ1JmwDw8NIHahrfiilvdOfk6YrT3L8E1SOB TY/dYlh9ssikwWNMorMGflCBoTN7CuInXtpJIt9lb0AAaCio5IVRvXtagZaMQfgzWcMhtYS996rTg 35IZWO6TBxoHXftvsW2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5hqy-006rQg-7T; Thu, 15 Dec 2022 06:36:24 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5hqu-006rNf-SP for linux-arm-kernel@lists.infradead.org; Thu, 15 Dec 2022 06:36:22 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5hqt-00021b-2j; Thu, 15 Dec 2022 07:36:19 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1p5hqr-0000g3-O3; Thu, 15 Dec 2022 07:36:17 +0100 Date: Thu, 15 Dec 2022 07:36:17 +0100 From: Sascha Hauer To: Marek Vasut Cc: linux-arm-kernel@lists.infradead.org, Peng Fan , Benjamin Gaignard , Fabio Estevam , Paul Elder , Marco Felsch , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , Adam Ford , Lucas Stach Subject: Re: [PATCH 2/2] soc: imx: imx8mp-blk-ctrl: Fix NULL pointer dereference Message-ID: <20221215063617.GC11668@pengutronix.de> References: <20221215034800.275502-1-marex@denx.de> <20221215034800.275502-2-marex@denx.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221215034800.275502-2-marex@denx.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221214_223620_939092_F18A31C6 X-CRM114-Status: GOOD ( 25.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 15, 2022 at 04:48:00AM +0100, Marek Vasut wrote: > Check domain->power_dev = dev_pm_domain_attach_by_name() return value using > IS_ERR_OR_NULL() instead of plain IS_ERR(), and fail if domain->power_dev is > either error or NULL. > > In case a power domain attached by dev_pm_domain_attach_by_name() is not > described in DT, dev_pm_domain_attach_by_name() returns NULL, which is > then used a few lines below in dev_set_name(domain->power_dev, ...);, > which leads to NULL pointer dereference. > > Fixes: 556f5cf9568a ("soc: imx: add i.MX8MP HSIO blk-ctrl") > Signed-off-by: Marek Vasut > --- > Cc: Adam Ford > Cc: Benjamin Gaignard > Cc: Fabio Estevam > Cc: Lucas Stach > Cc: Marco Felsch > Cc: Marek Vasut > Cc: NXP Linux Team > Cc: Paul Elder > Cc: Peng Fan > Cc: Pengutronix Kernel Team > Cc: Sascha Hauer > Cc: Shawn Guo > To: linux-arm-kernel@lists.infradead.org > --- > drivers/soc/imx/imx8mp-blk-ctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c > index b7d4161fcda9c..916bf0b3bc975 100644 > --- a/drivers/soc/imx/imx8mp-blk-ctrl.c > +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c > @@ -553,7 +553,7 @@ static int imx8mp_blk_ctrl_probe(struct platform_device *pdev) > > domain->power_dev = > dev_pm_domain_attach_by_name(dev, data->gpc_name); > - if (IS_ERR(domain->power_dev)) { > + if (IS_ERR_OR_NULL(domain->power_dev)) { > dev_err_probe(dev, PTR_ERR(domain->power_dev), > "failed to attach power domain %s\n", > data->gpc_name); Same problem as with the other patch, you shouldn't use 0 as error value. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel