Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47D24568B for ; Thu, 15 Dec 2022 16:55:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95C4BC433D2; Thu, 15 Dec 2022 16:55:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671123330; bh=e0u79or8elEwsfwUpsz+c2l+wQJQhYf3g9q0SWliS3o=; h=From:To:Cc:Subject:Date:From; b=ZyCSXA/j9R+dQ0abQp+TVmCEjDUd7CT1NRuxnu/QKvU1RMGpcHhDXg1nZmDSVYMoH xiYgapFtnTkNpnnuEzBBkJA1xCDGz64P00EseuYDIjzAD2O9Fy/AmeZw/YCsw4Vq4A LwpzCAd6RYAh8G8NY900KKzQVFyBRLhXjVcgU+DbZc35YxAA6w0OYQMh4PZJVI4RJn PsFe4KAAM8NSEk9sUwaNUd86njS4LXQeLgVVdn64pEeT4xVuSbZZuHksTJ9vImeQc8 EeiUDOOt4QuD92+YoyWs9qpQ4EgMJOHjDFh7JnsuhGaulmo8qBSDa/LmFBD246j6NS s1ue4rzNpJ1UQ== From: Arnd Bergmann To: Hector Martin , Sven Peter , "Rafael J. Wysocki" , Viresh Kumar Cc: Arnd Bergmann , Alyssa Rosenzweig , Marc Zyngier , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] cpufreq: apple: remove duplicate intializer Date: Thu, 15 Dec 2022 17:55:15 +0100 Message-Id: <20221215165523.1920672-1-arnd@kernel.org> X-Mailer: git-send-email 2.35.1 Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnd Bergmann When -Woverride-init is enabled, gcc notices that the .attr field is initialized twice: drivers/cpufreq/apple-soc-cpufreq.c:331:27: error: initialized field overwritten [-Werror=override-init] 331 | .attr = apple_soc_cpufreq_hw_attr, | ^~~~~~~~~~~~~~~~~~~~~~~~~ Remove the first one, since this is not actually used. Signed-off-by: Arnd Bergmann --- drivers/cpufreq/apple-soc-cpufreq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/cpufreq/apple-soc-cpufreq.c b/drivers/cpufreq/apple-soc-cpufreq.c index d1801281cdd9..6f26395184c4 100644 --- a/drivers/cpufreq/apple-soc-cpufreq.c +++ b/drivers/cpufreq/apple-soc-cpufreq.c @@ -321,7 +321,6 @@ static struct cpufreq_driver apple_soc_cpufreq_driver = { .flags = CPUFREQ_HAVE_GOVERNOR_PER_POLICY | CPUFREQ_NEED_INITIAL_FREQ_CHECK | CPUFREQ_IS_COOLING_DEV, .verify = cpufreq_generic_frequency_table_verify, - .attr = cpufreq_generic_attr, .get = apple_soc_cpufreq_get_rate, .init = apple_soc_cpufreq_init, .exit = apple_soc_cpufreq_exit, -- 2.35.1