Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F08FFC4332F for ; Mon, 19 Dec 2022 01:52:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E4A71836CF; Mon, 19 Dec 2022 02:51:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="VM42HG1w"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E9F778363D; Mon, 19 Dec 2022 02:51:57 +0100 (CET) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F264685391 for ; Mon, 19 Dec 2022 02:51:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id h26so3404865qtu.2 for ; Sun, 18 Dec 2022 17:51:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/qi1AgcaUJAd+ELyz8dSfVa1Xao/hopX+pnVO/YzeIU=; b=VM42HG1wdZ9bwlxOfmkNJXGiKXqY8g3x8CjDH7FgmtKrJhdwJZUnz7YFi6iK6BQAxX PeNDfCU6lNHlaPUQhEVviJ5oAqxmFVU6ZmqlIFA9zKwKTUq0RERwFxjnLlwETx5BpT9y ROxzibh+F6Y5qG2AJUQGrA1j0Xfg0fq2wGV3Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/qi1AgcaUJAd+ELyz8dSfVa1Xao/hopX+pnVO/YzeIU=; b=qwiX9MUW0/BvYZ+VKmmyqzk/1B2xiMzblcjL8b8AV/+80QePSHmGkWphK9JxL7gBCR 8BpC2DNG1dEQAyV6YejENTXX2PeiUOEZMMBBBikoCC3vOkwY6VLDt3YIIr0U0EiiuszG qpmeCDOjh5zEvdnF4QjNReiJQDR28nTlSWq+0apYUNTP2ZEyHRhDoJ5xlZSfQvao4R8P bfJtRRhfzzk5C58jgSlvIYxzFm7skycvlJnQQpVOvAlmGiRm+xKN2pSKYk1D4lzXxI+K PfCGz5542+dE1oVFyeBVyIcwxTpycuXaRiWauqnoOii2BsI0ISe3NyKu1H6Iz87tkv78 p/fw== X-Gm-Message-State: ANoB5pnhsh5f4s8DqIfmsJMR+P2NaCLLJZLp9BBw5KVZbkYkKJh2UM1G ckc05zcPN6atHL+XUGuUuP2mhOfidWtMuxMAFSyt5g== X-Google-Smtp-Source: AA0mqf5UDIz4HyO+noP5nB7NrLzwAK0nUyjMtJKVuPRNRu5xGg7ZeWZP1nPwLkficrkhjOMNMPCtww== X-Received: by 2002:ac8:7418:0:b0:3a7:e599:1ee0 with SMTP id p24-20020ac87418000000b003a7e5991ee0mr51839130qtq.63.1671414709555; Sun, 18 Dec 2022 17:51:49 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-d5a0-abff-1b88-4d34.res6.spectrum.com. [2603:6081:7b00:6400:d5a0:abff:1b88:4d34]) by smtp.gmail.com with ESMTPSA id fy21-20020a05622a5a1500b0039cb59f00fcsm5373228qtb.30.2022.12.18.17.51.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Dec 2022 17:51:49 -0800 (PST) Date: Sun, 18 Dec 2022 20:51:47 -0500 From: Tom Rini To: Simon Glass Cc: u-boot@lists.denx.de, Peter Robinson Subject: Re: [PATCH] Makefile: With BINMAN_ALLOW_MISSING=1 don't error on missing Message-ID: <20221219015147.GH3787616@bill-the-cat> References: <20221206020336.315465-1-trini@konsulko.com> <20221206150337.GK3787616@bill-the-cat> <20221212234336.GP3787616@bill-the-cat> <20221213163935.GC3787616@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="M5nWC+an0z+3xV++" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --M5nWC+an0z+3xV++ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 17, 2022 at 02:40:36PM -0700, Simon Glass wrote: > Hi Tom, >=20 > On Tue, 13 Dec 2022 at 09:39, Tom Rini wrote: > > > > On Mon, Dec 12, 2022 at 10:59:01PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 12 Dec 2022 at 16:43, Tom Rini wrote: > > > > > > > > On Tue, Dec 06, 2022 at 10:03:37AM -0500, Tom Rini wrote: > > > > > On Tue, Dec 06, 2022 at 03:36:49PM +1300, Simon Glass wrote: > > > > > > Hi Tom, > > > > > > > > > > > > On Tue, 6 Dec 2022 at 15:03, Tom Rini wrot= e: > > > > > > > > > > > > > > When the user builds with BINMAN_ALLOW_MISSING=3D1 they're ex= plicitly > > > > > > > setting the flag to allow for additional binaries to be missi= ng and so > > > > > > > have acknowledged the output might not work. In this case we = want to > > > > > > > default to not passing a non-zero exit code. > > > > > > > > > > > > > > Cc: Simon Glass > > > > > > > Reported-by: Peter Robinson > > > > > > > Signed-off-by: Tom Rini > > > > > > > --- > > > > > > > This passes CI as-is: > > > > > > > https://source.denx.de/u-boot/u-boot/-/pipelines/14340 > > > > > > > --- > > > > > > > Makefile | 2 +- > > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > > > diff --git a/Makefile b/Makefile > > > > > > > index de5746399a63..03de1da1bfd0 100644 > > > > > > > --- a/Makefile > > > > > > > +++ b/Makefile > > > > > > > @@ -1334,7 +1334,7 @@ cmd_binman =3D $(srctree)/tools/binman/= binman $(if $(BINMAN_DEBUG),-D) \ > > > > > > > --toolpath $(objtree)/tools \ > > > > > > > $(if $(BINMAN_VERBOSE),-v$(BINMAN_VERBOSE)) \ > > > > > > > build -u -d u-boot.dtb -O . -m \ > > > > > > > - $(if $(BINMAN_ALLOW_MISSING),--allow-missing = --fake-ext-blobs) \ > > > > > > > + $(if $(BINMAN_ALLOW_MISSING),--allow-missing = --ignore-missing) \ > > > > > > > -I . -I $(srctree) -I $(srctree)/board/$(BOAR= DDIR) \ > > > > > > > -I arch/$(ARCH)/dts -a of-list=3D$(CONFIG_OF_= LIST) \ > > > > > > > $(foreach f,$(BINMAN_INDIRS),-I $(f)) \ > > > > > > > -- > > > > > > > 2.25.1 > > > > > > > > > > > > > > > > > > > I believe we need the --fake-ext-blobs flag as well, since othe= rwise > > > > > > boards which use tools (like mkimage) on things that don't exis= t will > > > > > > not work. > > > > > > > > > > So, we need to list out all the use cases perhaps, as we had miss= ed one > > > > > before. In my mind we have: > > > > > - Board requires 1 or more blobs, developer will be running this = on > > > > > hardware, expects output from U-Boot 'make' (or buildman) to bo= ot. > > > > > Blobs must be present or non-zero exist status by default. > > > > > We didn't have this before, and we do now. > > > > > - Board requires 1 or more blobs AND has optional blobs, will be = running > > > > > this on hardware, expects output from U-Boot 'make' (or buildma= n) to > > > > > boot. This is the case we had missed before as allwinner requir= es bl31 > > > > > and has optional PMIC firmware. This is the case Peter reported= and we > > > > > had missed before, which this patch allows for, with the caveat= that > > > > > if you forget BL31 you're not going to boot and make won't comp= lain > > > > > exit-code wise. Another way to resolve this would be a property= in the > > > > > binman node to mark a blob as optional and warn if missing, rat= her > > > > > than error if missing. > > > > > - Board requires 1 or more blobs, output will NOT be run. This is= the CI > > > > > case and the compile testing lots of board cases. This is what = CI > > > > > passes still, with the above. > > > > > - Board requires 1 or more blobs, developer will be running this = on > > > > > hardware, BUT will be injecting the blobs later on. I think thi= s is > > > > > the use case you're talking about? > > > > > > > > Simon, can you test this last case by chance? I think that's the one > > > > that's unclear about if this patch breaks or not and I want to know= if I > > > > need to respin to still include the fake blobs flag still too or no= t. > > > > Or does anyone else use this case and can test? > > > > > > Yes I have your email printed out but travel and family things have > > > made it hard to get to it. I do think you need the flag, but the extra > > > case you mention need another look and probably a test, as you say. > > > > Yeah, understandable. My plan is to take this patch before the next -rc, > > so Fedora won't be broken and if we need the other flag (and I'll check > > in before release) we can follow up there and have a fixes tag on top of > > this one here. >=20 > I just sent a patch that allows entries (with external blobs) to be > marked as optional. I believe this covers the remaining case. >=20 > You still need to keep --fake-ext-blobs (in this case) since otherwise > boards that rely on faked blobs will not build - e.g. will get an > error in the mkimage step if an input file is missing. OK thanks, we'll pick that up after the next rc. --=20 Tom --M5nWC+an0z+3xV++ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOfw6MACgkQFHw5/5Y0 tyzchQv/VpyVBeplG7BLxhIQfRxpbgUO2sHZCLsG6UOMDvGi5NEFXzsqP0BFDaCi 2UsxZQt0uAe/6aWkcn2srgFEIRlK5hhAWEVj1oC/nVygxnsvDBLHNsXPllvqvLS6 lZ3fcXJF0F8pgSmvqr28nZlKVNLaJZgY1VMUFERlxgDT7uxbMNqJcKZcYAIUvDK1 4d3WyTXirtwoS5XYGOhQ8iCpJVYtIJCvLi61zKUxIfdmf7CmHIzDl+mEuBsJS1TZ ycab3pLDY0HiBcO/fnrgPBu3jcAiO/Wu3EwLZw6Tz+5PgM+gOrjUx3k7UhlSU9v/ vCxlJREM+rjbJKzbghIOqjhXBVxm8Y1fA2hTHbeYvVJw5N21MD0HoIFSNlc2G6zr OLx/8vwEv4619XgG20AGcLOnYPYG5gt5aQ/dSBX/vavzu7Pao+dvZxiLzjVyJsAS l8NA0fczMz9B3KAS1YipjX7OYTV0L3qrW/qieUEpShuZWGAXcoVgNym9+NTgY0fo mezdlK99 =Arr9 -----END PGP SIGNATURE----- --M5nWC+an0z+3xV++--