Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DCDDC4332F for ; Tue, 20 Dec 2022 08:00:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233194AbiLTIAq (ORCPT ); Tue, 20 Dec 2022 03:00:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233295AbiLTIAi (ORCPT ); Tue, 20 Dec 2022 03:00:38 -0500 X-Greylist: delayed 1879 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 20 Dec 2022 00:00:36 PST Received: from m126.mail.126.com (m126.mail.126.com [220.181.12.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7E4C9D106 for ; Tue, 20 Dec 2022 00:00:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version: Content-Type; bh=a8f9jHLGSU6GKTT+G2bdn7m6o60FMwWFVpWddddotCE=; b=EKGzBcUgIPoBgVoJgi95PspR9rRVz6MS0Uvgs11El8Flp3gG5QfWlpDZ2T0fv2 1FzlwgzVXaHwdNqZzEJ323DD4tRx8xUZXdkpkybFr/NQqnOCd7Q17eYsmeBaH5Zn GNJLeQiNtW+lvwIck/4hDYGG7Yy80FsnTHEl8CNe4hIw8= Received: from localhost.localdomain (unknown [116.128.244.169]) by zwqz-smtp-mta-g0-1 (Coremail) with SMTP id _____wA3MPI+ZKFjE64QAA--.28631S2; Tue, 20 Dec 2022 15:29:04 +0800 (CST) From: lingfuyi To: viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, lingfuyi Subject: [PATCH] fs: add macro when api not used Date: Tue, 20 Dec 2022 15:28:58 +0800 Message-Id: <20221220072858.32439-1-lingfuyi@126.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CM-TRANSID: _____wA3MPI+ZKFjE64QAA--.28631S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7XFyfKF18Wr1xXw4kuFWUtwb_yoWDJFg_ur 1Iva1rCr4kuF1Sqw4UW3sFv34UWr1DJrs3Cws5KwnYyFWDJay7Ar4DAFyrJw1kWwnF934U Ca4ktayrJF1j9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7sRCQ6LJUUUUU== X-Originating-IP: [116.128.244.169] X-CM-SenderInfo: polqwwxx1lqiyswou0bp/1tbiqAfdR1pD-RQ4ZgAAsb Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org when CONFIG_ELF_CORE not defined but dump_emit_page only used in dump_user_range(),will case some error like this: fs/coredump.c:841:12: error: ‘dump_emit_page’ defined but not used [-Werror=unused-function] static int dump_emit_page(struct coredump_params *cprm, struct page *page) Signed-off-by: lingfuyi --- fs/coredump.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/coredump.c b/fs/coredump.c index de78bde2991b..95390a73b912 100644 --- a/fs/coredump.c +++ b/fs/coredump.c @@ -838,6 +838,7 @@ static int __dump_skip(struct coredump_params *cprm, size_t nr) } } +#ifdef CONFIG_ELF_CORE static int dump_emit_page(struct coredump_params *cprm, struct page *page) { struct bio_vec bvec = { @@ -870,6 +871,7 @@ static int dump_emit_page(struct coredump_params *cprm, struct page *page) return 1; } +#endif int dump_emit(struct coredump_params *cprm, const void *addr, int nr) { -- 2.20.1