Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 183C7C10F1B for ; Wed, 21 Dec 2022 11:51:27 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7xcP-00017c-Sw; Wed, 21 Dec 2022 06:50:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7xcG-00016e-W5 for qemu-devel@nongnu.org; Wed, 21 Dec 2022 06:50:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7xcF-00074q-9H for qemu-devel@nongnu.org; Wed, 21 Dec 2022 06:50:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671623430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7fenJrDj8A1XX5EKozpAXTRcyje3SGKhw4GiXE0egAk=; b=D96vUiJFEgh/Yv8q/dtmL4+iq/UrX4EoAmaC9VutLYNDRz28tf8ppIW0WDr3hlSr/5lu4D 9Alm3YmgPz2skD2h5a7t017+Rl8xjzfJ8tBieCiCTHMCYOkGgWUZFEEO1Jz5Sx6OxPdsbb AquUv+lL+u0E12/4OeOeJn8Bma8b7Lc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-503-tcF-fK-gNjiGLxc-lMCW8A-1; Wed, 21 Dec 2022 06:50:26 -0500 X-MC-Unique: tcF-fK-gNjiGLxc-lMCW8A-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BD61E80234E; Wed, 21 Dec 2022 11:50:25 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.192.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id E6D13492C14; Wed, 21 Dec 2022 11:50:22 +0000 (UTC) From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: qemu-devel@nongnu.org Cc: Stefano Garzarella , Lei Yang , Zhu Lingshan , Eli Cohen , "Michael S. Tsirkin" , Gautam Dawar , Jason Wang , Parav Pandit , Laurent Vivier , Si-Wei Liu , Harpreet Singh Anand , Liuxiangdong , Cindy Lu Subject: [PATCH v3 0/4] Guest announce feature emulation using Shadow VirtQueue Date: Wed, 21 Dec 2022 12:50:11 +0100 Message-Id: <20221221115015.1400889-1-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.129.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org A gratuitous ARP is recommended after a live migration to reduce the amount= of=0D time needed by the network links to be aware of the new location. A hypervi= sor=0D may not have the knowledge of the guest network configuration, and this is= =0D especially true on passthrough devices, so its simpler to ask the guest to= =0D do it.=0D =0D However, the device control part of this feature can be totally emulated by= =0D qemu and shadow virtqueue, not needing any special feature from the actual= =0D vdpa device.=0D =0D The vdpa device must offer VIRTIO_NET_F_STATUS for the guest to access the= =0D status of virtio net config where announcement status bit is set. It is=0D possible to emulate it as always active in case backend does not support it= ,=0D but this is left for the future, as there are not many devices not offering= it=0D anyway.=0D =0D Patch 1 is less useful now that we don't emulate _F_STATUS anymore but QEMU= =0D coding style seems to prefer early return so leaving it in this version.=0D =0D v3:=0D * Properly byte swap status field of config space exposed to the guest.=0D * Fix comment (s/dont/don't)=0D =0D v2:=0D * Actually remove VIRTIO_NET_F_STATUS emulation. Comparing with v1, we offe= r=0D the feature with virtio instead of using virtio/vhost-vdpa.=0D =0D v1:=0D * Move code from vhost_net_get_config to virtio_net_get_config.=0D =0D RFC v2:=0D * Add VIRTIO_NET_F_STATUS emulation.=0D =0D Eugenio P=C3=A9rez (4):=0D virtio_net: Modify virtio_net_get_config to early return=0D virtio_net: copy VIRTIO_NET_S_ANNOUNCE if device model has it=0D vdpa: handle VIRTIO_NET_CTRL_ANNOUNCE in=0D vhost_vdpa_net_handle_ctrl_avail=0D vdpa: do not handle VIRTIO_NET_F_GUEST_ANNOUNCE in vhost-vdpa=0D =0D hw/net/virtio-net.c | 30 +++++++++++++++++-------------=0D net/vhost-vdpa.c | 16 ++++++++++++----=0D 2 files changed, 29 insertions(+), 17 deletions(-)=0D =0D -- =0D 2.31.1=0D =0D