Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EE01C4332F for ; Wed, 21 Dec 2022 21:56:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 39F20851D3; Wed, 21 Dec 2022 22:56:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="p/M5HJOF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E731484F87; Wed, 21 Dec 2022 22:56:44 +0100 (CET) Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D5CA4851D3 for ; Wed, 21 Dec 2022 22:56:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf36.google.com with SMTP id pp21so68334qvb.5 for ; Wed, 21 Dec 2022 13:56:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iWIBwyztRxMQD7/n8gzRkPQmUPok1BK6rHkIPKFcIoY=; b=p/M5HJOFAGiR+9wQm+0RjFyWblpY1giNrKnQZp+XsL12ANNl3ZMcvGuPNna9wfuotu 0qOA3Nh1iblIZNVPglwuUetJb4iVxI4C8dW1q5zzPJyWLopO2sftzOkpY7MpZZxC5y+N NZIoWTpYQW53BsTI5hSjdSOxZMYXWMFavGnx8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iWIBwyztRxMQD7/n8gzRkPQmUPok1BK6rHkIPKFcIoY=; b=gh39j+wVgtmmQ02Fsl4uphtgkNa3at7KzFqwl4ScsgB+I/PMqzKBf8Q17VyFIXYiMN 14gLDnQfRfB1hWvKrVm7gIc56EeUnWKRcXdhuklLnjeXJwibZxolM4FdAY8L/adgLySn ysyYy1YNx8x0SyWftCO+OP87Keclme5fa9pGiplO/pkiSvdQeP9zQXJN4gdD3gpvPEPf CU0UpiHun3VIcL1liwJb8uk4XHnc2NyRj1ZR/GZ426UbUVsjAGCAYQ4HKEM4OQWVD7BU aLR6wYd3LDVMZ0ZQuy5tePhT0mrq8MvSSWfpfRP9K8e8ZeI7ag1cyOnPvkSly9fRfZM8 R+ow== X-Gm-Message-State: AFqh2krBWOzF3HsSHeix5+ovqdLEFiBt37/xcjtYJq02W/VSOCyhG6ZU 6to1lexgHPkmyNQjMetEoO8kjQ== X-Google-Smtp-Source: AMrXdXvYtZ9Y/edheSmrSzVbTorDuInxrxZ/vUfs9a61kJYk3hpq4IAhQ7zgr0/mrEn+pudi9O/NBQ== X-Received: by 2002:a05:6214:5e91:b0:503:2b00:e5cc with SMTP id mm17-20020a0562145e9100b005032b00e5ccmr23917214qvb.2.1671659799644; Wed, 21 Dec 2022 13:56:39 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-24f0-bc4b-7894-230e.res6.spectrum.com. [2603:6081:7b00:6400:24f0:bc4b:7894:230e]) by smtp.gmail.com with ESMTPSA id w10-20020a05620a424a00b006a6ebde4799sm11526284qko.90.2022.12.21.13.56.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Dec 2022 13:56:39 -0800 (PST) Date: Wed, 21 Dec 2022 16:56:37 -0500 From: Tom Rini To: Mark Kettenis Cc: Eugen Hristev , u-boot@lists.denx.de, sjg@chromium.org, xypron.glpk@gmx.de, michal.simek@amd.com, daniel.schwierzeck@gmail.com, marex@denx.de, alpernebiyasak@gmail.com Subject: Re: [PATCH] lds: align u-boot-nodtb with 8 bytes boundary Message-ID: <20221221215637.GA3787616@bill-the-cat> References: <20221215115825.827111-1-eugen.hristev@microchip.com> <87edsx4qzy.fsf@bloch.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="v27ZICOpnx4tSes6" Content-Disposition: inline In-Reply-To: <87edsx4qzy.fsf@bloch.sibelius.xs4all.nl> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --v27ZICOpnx4tSes6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 17, 2022 at 11:14:41PM +0100, Mark Kettenis wrote: > > From: Eugen Hristev > > Date: Thu, 15 Dec 2022 13:58:25 +0200 > >=20 > > Newer DTC require that the DTB start address is aligned at 8 bytes. > > In the u-boot.bin case, the u-boot-nodtb.bin is concatenated with the > > DTB, but there is no alignment/padding to the next 8byte aligned addres= s. > > This causes the board to fail booting, because the FDT will claim > > that the DTB inside u-boot.bin is not a valid DTB, it will fail with > > -FDT_ERR_ALIGNMENT. > > To solve this, have the u-boot binary `_end` aligned with 8 bytes. > > The objcopy in the Makefile will create the u-boot-nodtb.bin and it has= to > > be truncated to 8 bytes to correspond to the u-boot.map file which will > > have the `_end` aligned to 8 bytes. > > The lds files which use devicetrees have been changed to align the `_en= d` > > tag with 8 bytes. > >=20 > > This patch is also a prerequisite to have the possibility to update the > > dtc inside u-boot to newer versions (1.6.1+) > >=20 > > Signed-off-by: Eugen Hristev > > --- > > Hi, > >=20 > > I could not test all affected boards, it's an impossible task. > > I tried this on at91 boards which I have, and ran the CI on denx. > > I cannot guarantee that no other boards are affected, so this patch is = a bit > > of an RFC. > > If the u-boot-nodtb.bin does not have the size equal with the correspon= ding > > one in u-boot.map, the binary_size_check will fail at build time with > > something like this: > >=20 > > u-boot.map shows a binary size of 502684 > > but u-boot-nodtb.bin shows 502688 > >=20 > > Thanks, > > Eugen > >=20 > > Makefile | 2 ++ > > arch/arm/cpu/armv8/u-boot.lds | 4 ++-- > > arch/arm/cpu/u-boot-spl.lds | 1 + > > arch/arm/cpu/u-boot.lds | 1 + > > arch/arm/lib/elf_arm_efi.lds | 5 +++++ > > arch/arm/mach-at91/arm926ejs/u-boot-spl.lds | 2 +- > > arch/arm/mach-at91/armv7/u-boot-spl.lds | 2 +- > > arch/arm/mach-zynq/u-boot-spl.lds | 2 +- > > arch/mips/cpu/u-boot.lds | 2 +- > > arch/sandbox/cpu/u-boot.lds | 6 ++++++ > > arch/sh/cpu/u-boot.lds | 2 ++ > > board/ti/am335x/u-boot.lds | 1 + > > tools/binman/test/u_boot_binman_embed.lds | 2 +- > > 13 files changed, 25 insertions(+), 7 deletions(-) > >=20 > > diff --git a/Makefile b/Makefile > > index 9d84f96481..b4d387bcce 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -1317,6 +1317,8 @@ endif > > =20 > > u-boot-nodtb.bin: u-boot FORCE > > $(call if_changed,objcopy_uboot) > > +# Make sure the size is 8 byte-aligned. > > + @truncate -s %8 $@ >=20 > $ truncate > ksh: truncate: not found >=20 > In other words: truncate(1) isn't a standard UNIX utility and not > present on OpenBSD for example. It isn't part of POSIX and therefore > its usage is unportable. >=20 > Please find a different solution. Ah yes. Can this perhaps be done with dd? A bit of looking around suggests that this might be a portable way to truncate a file to say 512 bytes: dd if=3D/dev/urandom of=3Dtestfile bs=3D1 count=3D500 dd if=3D/dev/null of=3Dtestfile bs=3D1 count=3D512 And then hexdump or whatever to see that the last 12 bytes are zero. Can you please test this on OpenBSD? We'll need some shell work to get current byte size and make it 8-byte aligned, but that should be portable at least. Thanks! --=20 Tom --v27ZICOpnx4tSes6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOjgRUACgkQFHw5/5Y0 tyxp+Qv9Gbqv0C5HwfZoEJXJxqx6F+p3cM4UlUbMXvFnPsjX+G/elUN+U+fuoEww T9xrYg88+xpinid1OBsZV7M+IDyEGmaUevbJnfhCzruJ9xHN9pzicklN0AGZCmrJ OBALNcAfb3PyfoH5dvokS2ejV3nckVO1/8znnByqBz2lOcuZKpaGvITGVHOo2q2d QA9uiSXhW9NT9GkteIuBT9oMPuc+kwqGf9h8M6mCOJFF1KfsAu4WwpwpQUbwSI2a dtcNuA6F5+mW+L2AHfI1D9piGVyZvMoY9MF+XFm9Dg3seE0i0QxKfTeFUjB5cOVf LVRfdD5BOFJsxMCsygr1MbZNUVzUeTkM+a5mRF3IZvIHPvY2Rnqv8EIl/wWtyBw3 xeBSnmBRSFnW8osP8k0q0DcRS716MZO/2lkAzPnHb+52cnl8kQqcAAR5WWy+d9l0 p3vY3xtE/x8r0IFREFJyEwZpZC23KsC95nCaanZ37/6z+eD0/YZE9j6GQxXLDIwk WqVtYzrY =Ey35 -----END PGP SIGNATURE----- --v27ZICOpnx4tSes6--