Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CE848F63 for ; Fri, 23 Dec 2022 15:51:46 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 85B4668AA6; Fri, 23 Dec 2022 16:51:41 +0100 (CET) Date: Fri, 23 Dec 2022 16:51:41 +0100 From: Christoph Hellwig To: Manivannan Sadhasivam Cc: Christoph Hellwig , Andy Gross , Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , Andrew Morton , Uladzislau Rezki , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux.dev Subject: Re: [PATCH 1/2] Revert "remoteproc: qcom_q6v5_mss: map/unmap metadata region before/after use" Message-ID: <20221223155141.GB30339@lst.de> References: <20221223092703.61927-1-hch@lst.de> <20221223092703.61927-2-hch@lst.de> <20221223144731.GA4587@thinkpad> <20221223145722.GA29401@lst.de> <20221223154039.GD4587@thinkpad> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221223154039.GD4587@thinkpad> User-Agent: Mutt/1.5.17 (2007-11-01) On Fri, Dec 23, 2022 at 09:10:39PM +0530, Manivannan Sadhasivam wrote: > On Fri, Dec 23, 2022 at 03:57:22PM +0100, Christoph Hellwig wrote: > > On Fri, Dec 23, 2022 at 08:17:31PM +0530, Manivannan Sadhasivam wrote: > > > Acked-by: Manivannan Sadhasivam > > > > Btw, if the hardware really does not like a kernel mapping, the > > right way is to just keep using the normal dma allocator, but make > > sure that there shared-dma-pool with the no-map property for the > > device. > > Sibi posted a series that uses a separate no-map carveout for this usecase: > https://lore.kernel.org/lkml/20221213140724.8612-1-quic_sibis@quicinc.com/ Oh, I've missed that entire thread. I actually stumbled over this today while finding it during a vmap audit..