Return-Path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: From: Parav Pandit Date: Sun, 25 Dec 2022 02:11:32 +0200 Message-ID: <20221225001132.92694-1-parav@nvidia.com> MIME-Version: 1.0 Subject: [virtio-comment] [PATCH] virtio-network: Clarify VLAN filter table configuration Content-Type: text/plain Content-Transfer-Encoding: quoted-printable To: mst@redhat.com, virtio-dev@lists.oasis-open.org Cc: virtio-comment@lists.oasis-open.org, si-wei.liu@oracle.com, Parav Pandit List-ID: The filtering behavior of the VLAN filter commands is not very clear as discussed in thread [1]. Hence, add the command description and device requirements for it. [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg912392.html Fixes: https://github.com/oasis-tcs/virtio-spec/issues/147 Suggested-by: Si-Wei Liu Signed-off-by: Parav Pandit --- virtio-network.tex | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/virtio-network.tex b/virtio-network.tex index b05ce61..e2b28d9 100644 --- a/virtio-network.tex +++ b/virtio-network.tex @@ -1210,6 +1210,29 @@ \subsubsection{Control Virtqueue}\label{sec:Device T= ypes / Network Device / Devi Both the VIRTIO_NET_CTRL_VLAN_ADD and VIRTIO_NET_CTRL_VLAN_DEL command take a little-endian 16-bit VLAN id as the command-specific-data. =20 +VIRTIO_NET_CTRL_VLAN_ADD command adds the specified VLAN to the VLAN +filtering table. + +VIRTIO_NET_CTRL_VLAN_DEL command removes specified VLAN from the VLAN +filtering table which was previously added using +VIRTIO_NET_CTRL_VLAN_ADD command. + +\devicenormative{\subparagraph}{VLAN Filtering}{Device Types / Network Dev= ice / Device Operation / Control Virtqueue / VLAN Filtering} + +When VIRTIO_NET_F_CTRL_VLAN is not negotiated, the device accepts all +VLAN tagged packets which matches device's filter configuration. + +When VIRTIO_NET_F_CTRL_VLAN is negotiated, the device starts with empty +VLAN filtering table. + +When VIRTIO_NET_F_CTRL_VLAN is negotiated, the device accepts all the +VLAN tagged packets whose VLAN tag is found in the VLAN filtering table; +device should drop all VLAN tagged packets whose VLAN tag is not found +in the VLAN filtering table. + +When VIRTIO_NET_F_CTRL_VLAN is negotiated, the device accepts all +untagged packets which matches device's filter configuration. + \subparagraph{Legacy Interface: VLAN Filtering}\label{sec:Device Types / N= etwork Device / Device Operation / Control Virtqueue / VLAN Filtering / Leg= acy Interface: VLAN Filtering} When using the legacy interface, transitional devices and drivers MUST format the VLAN id --=20 2.26.2 This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lis= ts Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/