Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1156EC4332F for ; Wed, 4 Jan 2023 19:18:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A7F7B85574; Wed, 4 Jan 2023 20:18:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="Jt0F2aok"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9A3B285248; Wed, 4 Jan 2023 20:18:18 +0100 (CET) Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DCF508555F for ; Wed, 4 Jan 2023 20:18:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jagan@amarulasolutions.com Received: by mail-pf1-x435.google.com with SMTP id g20so15317621pfb.3 for ; Wed, 04 Jan 2023 11:18:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=RwOyg6CtVDtfp5yJj/L25mumQN9YkkUpU9YshNcch9M=; b=Jt0F2aok3M1Jjz4ZGwjkl1CqjIUq1kBgGB40Is3veGrP9EWRRQB9y1/UoCSWcCsM/O 8LXFbSkLeRN1lCtC8dsF2DW7b9GhQ59xaPSWjK40mBTBVdEXp9oUXCEuWXMoTEMEY5Vq qg9XprBQk0VhyGb8UgPBuSALowUD30gssFRX0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RwOyg6CtVDtfp5yJj/L25mumQN9YkkUpU9YshNcch9M=; b=exHQ22Nuu1EWRfb8AERFmlhgTrppbZoQQK1yu6bTD1MIPQbrqAm33iMqo2FVIMQQ0T y3a8zw2P40bodO4Spd74fh3eIc1udzQUE/CNv4P6k6I2lUwfI3D+pV9r32OjpsP1+eff Ib1t1R5efbezlzS8Lvk6inI85HJsZepmvb7AbXG+wJ/HoHMq/TbPmS+T/JgeB5gMAcgb WxdtPQ/VTQLG4JxHVmpyDN8cWJ3tDWCQ6Z8uQm1zQEXSEBWUr7BK2Xz2thPka8JCdc0Y oqlQ9Hwsc4fIzG3fqasw5Q+r0WyD0cLHn0JT3DCPRI3dVBzsrOKK1VXRx418fmKo3t0W eGOg== X-Gm-Message-State: AFqh2kpiGMJ/3NPof0dbC5KtiNa2XiQD7TPynDaOV4HquGJldvy9et30 469gGYWbgLXYYEDjfxG6XtvHQw== X-Google-Smtp-Source: AMrXdXud3byg4OeiNJH4CgWJIVosMte6GIZYaRlLmKTXSwepk30l12rQz/UHsPuasWapdi8o9IlFTQ== X-Received: by 2002:a62:2744:0:b0:581:140:f3b6 with SMTP id n65-20020a622744000000b005810140f3b6mr33396876pfn.34.1672859893219; Wed, 04 Jan 2023 11:18:13 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a15f:f638:8355:8500:b2a7]) by smtp.gmail.com with ESMTPSA id c14-20020a621c0e000000b0056bcb102e7bsm22789490pfc.68.2023.01.04.11.18.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 11:18:12 -0800 (PST) From: Jagan Teki To: Kever Yang , Philipp Tomsich , Simon Glass , Tom Rini Cc: u-boot@lists.denx.de, linux-amarula@amarulasolutions.com, Jagan Teki , Quentin Schulz Subject: [PATCH] arm: rockchip: Fix binman_init failure on RK3568 Date: Thu, 5 Jan 2023 00:48:04 +0530 Message-Id: <20230104191804.259256-1-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean For some newer SoCs like RK3568, the Rockchip has not released any DDR drivers yet so idbloader needs to create manually using DDR binaries offered by rkbin. This indeed no requirement to enable TPL in the U-Boot source code. If we mark TPL disabled and mark BINMAN enabled by default then there would be an issue of binman_init failure during board relocation. This is true as binman failed to find the top-level node like u-boot-tpl here. Here is the boot issue observed in RK3566 board, U-Boot 2023.01-rc4-00057-gac2505d463-dirty (Jan 04 2023 - 23:44:18 +0530) Model: Radxa Compute Module 3(CM3) IO Board DRAM: 2 GiB binman_init failed:-2 initcall sequence 000000007ffd2008 failed at call 0000000000a18cac (err=-2) ### ERROR ### Please RESET the board ### This might be fixed via binman node in rockchip-u-boot.dtsi however disable binman for rk3568 for now as we are at the end of the release cycle. Fixes: 05713d570762 ("rockchip: generate u-boot-rockchip.bin with binman for ARM64 boards") Cc: Quentin Schulz Signed-off-by: Jagan Teki --- arch/arm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index cac4fa09fd..0e7a511c79 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1934,7 +1934,7 @@ config ARCH_STM32MP config ARCH_ROCKCHIP bool "Support Rockchip SoCs" select BLK - select BINMAN if SPL_OPTEE || SPL + select BINMAN if SPL_OPTEE || (SPL && !ROCKCHIP_RK3568) select DM select DM_GPIO select DM_I2C -- 2.25.1