Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4F55C5479D for ; Fri, 6 Jan 2023 16:52:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 64B96852C4; Fri, 6 Jan 2023 17:52:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="RfLDY/AF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C4E6D852C4; Fri, 6 Jan 2023 17:52:18 +0100 (CET) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2836F8549F for ; Fri, 6 Jan 2023 17:52:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id jr11so2486413qtb.7 for ; Fri, 06 Jan 2023 08:52:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XH/M5QB802o+4t6ZbpttBATH6tKdErIpZfR3rdfG1rE=; b=RfLDY/AF/24VRaSpqMyJ1ykEeCfH08a5ZDyfy49IfpSCIdzjAjCU8c0YgLk1QxWmp4 Kr3f8ZrYWmQD/zPjBLiPHNVsGidR0q01YaFRjBJx4XnaP1nbB+L5iMzUHh/7BqoN0ZFH wj2mp5asalxivOkCuKcB1wYxJSp34PJC2Aj+M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XH/M5QB802o+4t6ZbpttBATH6tKdErIpZfR3rdfG1rE=; b=Ay1Fd+USXbHXkKSPh9xxC4wFMLuylRqZ6rUmfXsqf1kt5GkLUVDxGCKTV+5dZCC2iF DWJBl37pjfj27kG7sCe9kJ/qurSe1Sm3oAUccQaZuRtt27WjWxPIckqYTs5zKXpNRszG 9dPNHEnzYAarzhW3A4g5cVgpB5ZiAWjJ8/RQMqpppYbM7jVAdJ/OQWsf++ClElaQPxFU SsFp4K6Gwhc4U9MV64JH/1A7mi6CW5DgQXn/S8hinmVfuObDkA4yGS55OP1YGyKpxapK ZvqbCzH12a5LTFghDcHDanHNruSZUhcOEpyDjsbdEPxi5wocvupCzY5hu2qcQ982v44F Hnng== X-Gm-Message-State: AFqh2kpba3i/Sphrah/fNU7SDLOqvAEPC4xZ5v6C7pedLTgaxnRoOFV/ Kl170jNI2N0j6Xjq85Tli8FiJA== X-Google-Smtp-Source: AMrXdXtU8twOzMcIMMR9IIGae3T3fEPRMN2anE5zWkTRDWoOmrwSKnLCJcnSjAjsb+KcMy49XjhAAg== X-Received: by 2002:a05:622a:4d98:b0:3a5:24ac:a175 with SMTP id ff24-20020a05622a4d9800b003a524aca175mr83444999qtb.56.1673023931924; Fri, 06 Jan 2023 08:52:11 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-9162-adb5-1773-34c0.res6.spectrum.com. [2603:6081:7b00:6400:9162:adb5:1773:34c0]) by smtp.gmail.com with ESMTPSA id m8-20020a05620a290800b006fb8239db65sm783171qkp.43.2023.01.06.08.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 08:52:11 -0800 (PST) Date: Fri, 6 Jan 2023 11:52:09 -0500 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, Peter Hoyes , Ramon Fried , Simon Glass Subject: Re: [PATCH v2] cmd: pxe_utils: Limit fdtcontroladdr usage to non-fitImage Message-ID: <20230106165209.GV3787616@bill-the-cat> References: <20221214064518.753432-1-marex@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="r1CdGX93mYOTnwsW" Content-Disposition: inline In-Reply-To: <20221214064518.753432-1-marex@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --r1CdGX93mYOTnwsW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 14, 2022 at 07:45:18AM +0100, Marek Vasut wrote: > Commit d5ba6188dfb ("cmd: pxe_utils: Check fdtcontroladdr in label_boot") > forces '$fdtcontroladdr' DT address as a third parameter of bootm command > even if the PXE transfer pulls in a fitImage which contains configuration > node with its own DT that is preferrable to be passed to Linux. Limit the > $fdtcontroladdr fallback utilization to non-fitImages, since it is highly > likely a fitImage would come with its own DT, while single-file images do > need a separate DT. >=20 > Fixes: d5ba6188dfb ("cmd: pxe_utils: Check fdtcontroladdr in label_boot") > Signed-off-by: Marek Vasut > Reviewed-by: Quentin Schulz > Tested-by: Quentin Schulz > Reviewed-by: Simon Glass > Reviewed-by: Peter Hoyes > Tested-by: Peter Hoyes > Reviewed-by: Neil Armstrong Applied to u-boot/master, thanks! --=20 Tom --r1CdGX93mYOTnwsW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmO4UbkACgkQFHw5/5Y0 tywYBQwAojmu9/ONkxsOQfFehJkJMs+3jKnlP9gbA1UNupRHKi1eUgAk+b1LrM3l y1zHvu5gcQxiUewVYXwV5oEZ0yZumDBgweGfnZNe4lPtujQBBxjtT0nk3RlsITr+ m+jzHKETjPyJyNd3gZc7CiOXxPtiNaVKfejsDiPK0+ELcM7O+k/JcqWxwBgwwBhf WBgcrfMB5PeZ/m5N15kbS3otwbV/IBmNhjlqcfEcFlkV9NUSSGSbQpr5Zr+hTso4 XCAvaxw+SUtGM+ZOrOf5VYlgkctaItGFiRYzqhbdzEw6vC08J49ABxCmlfSlTfX0 5B3y58MOjoWYZpnht1wkiurZYyIQ8vBjg6LimL0Nul/6IxzZ9CJyYYw+Ws6KiTma 3URCC1wVZsueY8UfJ8nnFA/dWoM48QSI/aROOWpzBFkTxDXFQ6jev+XnwuWPh0bB uMcG8wB1jGjRZ/LzwtHLF0NRdp8n3BVJayRtA4sT+bQwjwm0xWzHqcHMBb/WK7PY 1onerCdK =wa0G -----END PGP SIGNATURE----- --r1CdGX93mYOTnwsW--