Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18C96C54EBD for ; Fri, 6 Jan 2023 18:29:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8D15C853B1; Fri, 6 Jan 2023 19:29:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="YzAYRVE/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EBB71853EB; Fri, 6 Jan 2023 19:29:34 +0100 (CET) Received: from mail-vs1-xe2b.google.com (mail-vs1-xe2b.google.com [IPv6:2607:f8b0:4864:20::e2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EFDDF85343 for ; Fri, 6 Jan 2023 19:29:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-vs1-xe2b.google.com with SMTP id m2so2315900vsv.9 for ; Fri, 06 Jan 2023 10:29:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jHe9tG1YPLTctqnrrpbZVEUJNn8ejWxUU2tiX9BcBGw=; b=YzAYRVE/FXo/YV1XAE55lz+1LrZNHp2e+IQSGhhKfpVUnx2w/sWS//SkQ/+G3sFHBK gtdXMjcZPvL5Zl9+8Tn2eLqoqu+kYx1NWUu4/z/60D62Xh+ZC1KLb0HkBl4QOmhMJ+fG Ga7ifQ18qWT4aJ/VG5NGvUmkmMj1XZBzDQlCg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jHe9tG1YPLTctqnrrpbZVEUJNn8ejWxUU2tiX9BcBGw=; b=PwE7T/sJLeaUGTKHTFsrSZ2jWSW6t1Db1W270BiKbbD33HChAQbuSxD1Ml5ADwcR/f OL0VVZygt1kJ+RhKpbRG1WkhNPZGjXrGsYp0K9xqOuNePoKKYAGaCRADN7T1XjjpXL+M wk/USicC4C9Z4CFXNu0+jzextWAc4zV8DTtepYlkXBqZe0ydp+cFAUBFzoIyP51VFQNv S6Q5q46PPI6mawuD+uHN9w64QKwZMqamkRaJFJlZvHikPbaMvUjnTzBhc/v7aCEo8R1o BPpB37OuqlS/PCrclGkJbBJ0lrJsvqzgRW5lDU//4rJANfn8HoTn4YQV/ncGnbY6UFZf mVPA== X-Gm-Message-State: AFqh2kqcJPDvFYRTMtPbMIR+cy2CtOKmmIcHL1sEKJyFGa67y8r5PMWw vQHakbfm8haoj2VO+bPDvJOdlA== X-Google-Smtp-Source: AMrXdXvWfXTLujTJVsehtTmr0DViOfG+aOuXGi/OijXwTPyREtkJKlFS+BY98XlDB5Ih3+3JFJBPag== X-Received: by 2002:a67:ea0b:0:b0:3ce:e4fd:ff16 with SMTP id g11-20020a67ea0b000000b003cee4fdff16mr1540342vso.12.1673029770580; Fri, 06 Jan 2023 10:29:30 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-9162-adb5-1773-34c0.res6.spectrum.com. [2603:6081:7b00:6400:9162:adb5:1773:34c0]) by smtp.gmail.com with ESMTPSA id s11-20020a05620a0bcb00b00704a9942708sm893064qki.73.2023.01.06.10.29.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 10:29:29 -0800 (PST) Date: Fri, 6 Jan 2023 13:29:28 -0500 From: Tom Rini To: Andrew Davis Cc: Derald Woods , Simon Glass , u-boot@lists.denx.de Subject: Re: [PATCH] ARM: omap3: evm: Name this directory omap3 Message-ID: <20230106182928.GF3787616@bill-the-cat> References: <20221007173314.27808-1-afd@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aFNB+Z4Xfdve4YxP" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --aFNB+Z4Xfdve4YxP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 06, 2023 at 12:13:12PM -0600, Andrew Davis wrote: > On 10/7/22 10:21 PM, Derald Woods wrote: > > On Fri, Oct 07, 2022 at 12:33:14PM -0500, Andrew Davis wrote: > > > Before this was named just evm, which doesn't match the naming > > > of the other TI board file directory and makes it look like a > > > common directory for evms. Name this omap3. > > >=20 > > > Signed-off-by: Andrew Davis > > > --- > > > arch/arm/mach-omap2/omap3/Kconfig | 2 +- > > > board/ti/{evm =3D> omap3}/Kconfig | 2 +- > > > board/ti/{evm =3D> omap3}/MAINTAINERS | 2 +- > > > board/ti/{evm =3D> omap3}/Makefile | 0 > > > board/ti/{evm =3D> omap3}/evm.c | 0 > > > board/ti/{evm =3D> omap3}/evm.h | 0 > > > 6 files changed, 3 insertions(+), 3 deletions(-) > > > rename board/ti/{evm =3D> omap3}/Kconfig (87%) > > > rename board/ti/{evm =3D> omap3}/MAINTAINERS (87%) > > > rename board/ti/{evm =3D> omap3}/Makefile (100%) > > > rename board/ti/{evm =3D> omap3}/evm.c (100%) > > > rename board/ti/{evm =3D> omap3}/evm.h (100%) > > >=20 > > > diff --git a/arch/arm/mach-omap2/omap3/Kconfig b/arch/arm/mach-omap2/= omap3/Kconfig > > > index 3e97ec2629..4e9924faf7 100644 > > > --- a/arch/arm/mach-omap2/omap3/Kconfig > > > +++ b/arch/arm/mach-omap2/omap3/Kconfig > > > @@ -163,7 +163,7 @@ config SYS_SOC > > > source "board/logicpd/am3517evm/Kconfig" > > > source "board/ti/beagle/Kconfig" > > > source "board/timll/devkit8000/Kconfig" > > > -source "board/ti/evm/Kconfig" > > > +source "board/ti/omap3/Kconfig" > > > source "board/isee/igep00x0/Kconfig" > > > source "board/logicpd/omap3som/Kconfig" > > > source "board/nokia/rx51/Kconfig" > > > diff --git a/board/ti/evm/Kconfig b/board/ti/omap3/Kconfig > > > similarity index 87% > > > rename from board/ti/evm/Kconfig > > > rename to board/ti/omap3/Kconfig > > > index 4f490ddd9d..d60b229a4e 100644 > > > --- a/board/ti/evm/Kconfig > > > +++ b/board/ti/omap3/Kconfig > > > @@ -1,7 +1,7 @@ > > > if TARGET_OMAP3_EVM > > >=20 > > > config SYS_BOARD > > > - default "evm" > > > + default "omap3" > > >=20 > > > config SYS_VENDOR > > > default "ti" > > > diff --git a/board/ti/evm/MAINTAINERS b/board/ti/omap3/MAINTAINERS > > > similarity index 87% > > > rename from board/ti/evm/MAINTAINERS > > > rename to board/ti/omap3/MAINTAINERS > > > index cd315c1635..95b34bbd11 100644 > > > --- a/board/ti/evm/MAINTAINERS > > > +++ b/board/ti/omap3/MAINTAINERS > > > @@ -1,6 +1,6 @@ > > > EVM BOARD > > > M: Derald D. Woods > > > S: Maintained > > > -F: board/ti/evm/ > > > +F: board/ti/omap3/ > > > F: include/configs/omap3_evm.h > > > F: configs/omap3_evm_defconfig > > > diff --git a/board/ti/evm/Makefile b/board/ti/omap3/Makefile > > > similarity index 100% > > > rename from board/ti/evm/Makefile > > > rename to board/ti/omap3/Makefile > > > diff --git a/board/ti/evm/evm.c b/board/ti/omap3/evm.c > > > similarity index 100% > > > rename from board/ti/evm/evm.c > > > rename to board/ti/omap3/evm.c > > > diff --git a/board/ti/evm/evm.h b/board/ti/omap3/evm.h > > > similarity index 100% > > > rename from board/ti/evm/evm.h > > > rename to board/ti/omap3/evm.h > > > -- > > > 2.37.3 > > >=20 > >=20 > > It seems to me that something like 'omap3evm' would be more appropriate > > for a directory name. Using just 'omap3' may be too generic. The actual > > EVM configurations are TMDSEVM3530 [1] and TMDSEVM3730 [2], with the > > corresponding processor boards attached. It would also align with the > > TARGET_OMAP3_EVM definition still in use. These are my observations. > >=20 >=20 > I'm not sure about that, the convention seems to be the directory name > matches the SoC, then the source files match for each type/name of > board. This is at least true for some newer TI boards, but I agree it > is not always followed for the older devices. I have no strong preference > either way, just as long as we can not call it "board/ti/evm" like it > is now.. >=20 > This patch still applies to the latest u-boot, or I can send a v2. I'd like a v2 of "omap3evm" please, we have other omap3 platforms still so it would just be a different confusion I feel (and most of the other board/ti/SOC/ directories support the EVM + SK + other stuff model, while this is just the 3530/3730 boards that are iirc otherwise very similar). Thanks! --=20 Tom --aFNB+Z4Xfdve4YxP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmO4aIQACgkQFHw5/5Y0 tyxRgQv+PmJFKzoDRljruq35htrmUWLgfxFoqTqFh9N6GRzvxaXHwZak8zdegDvX P7EucL0ioXfxwYbVDKql3+xmNVXuoJOHWSjyFKXeguPrePRk6Dm37mO2ryvsLmo5 9MoWhQhGhkZgwp6sR2Vuytxx4dkS0OUVJvrfsvG6PSeIj6uQepTqHDryzOflV8Hc RY0stYN6LqZvoAB5Hs/F1lxwrslad5LjiOMZLYAc6qTUIC2JpWleGdNtbJxtehKn w4JbhpIotvi9UxVv/uTm0jFM6SSF1k4A/czTPbjwtp54lYmf8d0JAcJSoVZACGQl 0QXncIf/TT2VGa232Lp0m8GQMIUyk3MLJu1ZKCKgQBA5ncX1L9o/EqN2PkUpzjhO bFLBe9gOKPphX0PeA6ZnLAhOxMS8dE2tW8lLc40T2vsqugrFfIsICPC/rfg0hFjp EUr5pf0NWUkGEufU/lUXZOE3vUmeLYVKIom3AKpq/MinBC2s7hPwIXnY/5QMkXHI ocWEYfvf =U5qe -----END PGP SIGNATURE----- --aFNB+Z4Xfdve4YxP--