Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B34DC5479D for ; Mon, 9 Jan 2023 13:29:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0AEAF8533E; Mon, 9 Jan 2023 14:29:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="W+ej9YhT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9687B85345; Mon, 9 Jan 2023 14:29:40 +0100 (CET) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 70A0E8526A for ; Mon, 9 Jan 2023 14:29:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82d.google.com with SMTP id h21so7654591qta.12 for ; Mon, 09 Jan 2023 05:29:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BCm2350m1SYdrSdrJkA4O9UOw/7tY3WieQOy1cQLJ1k=; b=W+ej9YhT8eHQjXHX97DhxQu4499yxt8i6rI7azfuaxqoxqhYhnQcAmuO9eqzVw83/1 KdR0O9m8OsBL3vtITcf249YNjd+v7vTxhkKhiD23xfTZSzk4SoLYdmXDTRK4uadjy1wV Fvli1hHARphNSc1MGJsSPYT3hgzbJ14y+CuS8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BCm2350m1SYdrSdrJkA4O9UOw/7tY3WieQOy1cQLJ1k=; b=FhXNyoTtrvfUaMyBWeud3Qy64rP01PyuvXdUFuNUfIBXmYYtbLTCec2SWGUTs3GmnH fuT9SCAv9sumo5Mo6wPErt8/hZfUBCtByEJ14syAVd5lGAoHjTXeUVvwWHsaDLATRymG NJgHLhERvaFkGHrzZEyUJ9/vtGZ0gjswKVSWdibhCNXO5Hhr36iV/LCgQEptyxJ6GEQ9 174+ntESK3UJeQH+/pBvHVKbwqQP+ueX8MYc/IUikIsBHoOcumVxbs/z8UIW5UEQhQ6K XLpg3RCxQ/12mTFhijSiS8q+Rrx5pVMOHvI5Wkf/MTOfvTkbnHo/Ev9V+i2pC6ee9cB6 r6eg== X-Gm-Message-State: AFqh2kpc+T/kwuoGKiSah3NtTgj3HwXEGOGm/PC9mhWwYhSZCqiKkQzI iJcJho50G5746SfBEaGEyjarng== X-Google-Smtp-Source: AMrXdXtIyL1CwDBpia6ZZebwBk+muyiOSWdDSy1k8PEK4QLrgsIw+OmoS1om2mVos9zMkA1b8Z77bw== X-Received: by 2002:a05:622a:1e06:b0:3a8:28a4:c4bc with SMTP id br6-20020a05622a1e0600b003a828a4c4bcmr89325234qtb.11.1673270976077; Mon, 09 Jan 2023 05:29:36 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0159-9ce3-e1a8-fcba.res6.spectrum.com. [2603:6081:7b00:6400:159:9ce3:e1a8:fcba]) by smtp.gmail.com with ESMTPSA id t2-20020a37ea02000000b006fb9bbb071fsm5344467qkj.29.2023.01.09.05.29.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 05:29:35 -0800 (PST) Date: Mon, 9 Jan 2023 08:29:33 -0500 From: Tom Rini To: Jagan Teki Cc: Kever Yang , Philipp Tomsich , Simon Glass , u-boot@lists.denx.de, linux-amarula@amarulasolutions.com, Quentin Schulz Subject: Re: [PATCH v2] board: rockchip: Fix binman_init failure on EVB-RK3568 Message-ID: <20230109132933.GH3787616@bill-the-cat> References: <20230108161734.50094-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IBga1O7x0mkV3MEu" Content-Disposition: inline In-Reply-To: <20230108161734.50094-1-jagan@amarulasolutions.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --IBga1O7x0mkV3MEu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 08, 2023 at 09:47:34PM +0530, Jagan Teki wrote: > For some newer SoCs like RK3568, the Rockchip has not released > any DDR drivers yet so idbloader needs to create manually using > DDR binaries offered by rkbin. This indeed no requirement to > enable TPL in the U-Boot source code. >=20 > If we mark TPL disabled and mark BINMAN enabled by default then > there would be an issue of binman_init failure during board > relocation. This is true as binman failed to find the top-level > node like u-boot-tpl here. >=20 > Here is the boot issue observed in Radxa-CM3 RK3566 board, >=20 > U-Boot 2023.01-rc4-00057-gac2505d463-dirty (Jan 04 2023 - 23:44:18 +0530) >=20 > Model: Radxa Compute Module 3(CM3) IO Board > DRAM: 2 GiB > binman_init failed:-2 > initcall sequence 000000007ffd2008 failed at call 0000000000a18cac (err= =3D-2) > ### ERROR ### Please RESET the board ### >=20 > This might be fixed via binman node in rockchip-u-boot.dtsi however > disable BINMAN_FDT for evb-rk3568 defconfig for now as we are at the > end of the release cycle. >=20 > Fixes: 05713d570762 ("rockchip: generate u-boot-rockchip.bin with binman > for ARM64 boards") > Cc: Quentin Schulz > Signed-off-by: Jagan Teki > Reviewed-by: Kever Yang Applied to u-boot/master, thanks! --=20 Tom --IBga1O7x0mkV3MEu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGyBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmO8FrcACgkQFHw5/5Y0 tyz/Jwv3aL3/pUztT9euIiPEst0P7+ByqmCEQgJhqMhem+iW9eEOL4AaUtdUNdHo e1SXaaSj4l893NrV2PM3sbhYjNyFLl0sXF7PnsslzO4OPjZl7UPmxn0YAUGQYvsa B/ivUAwR4q+tXjM4jGGVTUlN2gZ3vAuIIHzXZwXQfzD3/feVEqjacUPKWSIvDAJV b0QqxNX7royjI7SvVKKWpYVfjYKZoMAtWlIX7v1pr8oeoStzD+dDqrSiuvaxP+M6 TmiI7CnJfgb5At1/rJCfkZ+UF7MJiInVIhvKf8BaraUJzvroPeTl/HztsjYNNLaD 2ysVGzDU7tuU7t5Rcij12wX9t0DhpxiUMvAOqtb9lIXcUudJegfkD+RJaAItinEd ryk4Eq5BJvTXlfajP+LLGqjtJn22mXiT4ubBcodiTDpRsAXsTDvBHt/Q3qDV6e9z vP5VEjO9wwF8a6CrC4vVkd+Y6naZJrtS47ZEmaO6BS2gnKnOPjBNpCpYytuNr5YS dI/pNnk= =Vzbl -----END PGP SIGNATURE----- --IBga1O7x0mkV3MEu--