Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 324F1C5479D for ; Mon, 9 Jan 2023 15:11:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c0ffuRAaWhVrFXrdUt3sViQ74hh4zeGkT8tFLtcS9fM=; b=BRjTN/5KJ3wpVr 53OqpzVUNgToxQqc7QlgPRSOGQWs7MRcxUacSVTvDW33CVifmtyA/B9mDLK1+Tu4FO6NkJB1kxLyP 08MSXZKmNifceMtUZ4vOJiwaZKG4tCooyqf4GEymK2kdCcaf5gZ68oAMACg2PZGO4PPQxqJXNlb1h BNSrxb1eVwMNC+xVZn1kObhoYlcy0IUW3eV9au/iJaPfMMAjy5KWRwXxGz8XT9Ep7Eb1iuerphjED G4Fk2M/yMIupgW84a3jziDTg8xxZTEJizVRCRmfAs2VyM/5M/dBcyLHWNVaUqAnVHrbOi1e3F9HAv eZl4svDF4C/l8hcWC7fQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEtmi-0027cB-PV; Mon, 09 Jan 2023 15:10:00 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEtme-0027ay-Et for linux-arm-kernel@lists.infradead.org; Mon, 09 Jan 2023 15:09:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 23ABA6118C; Mon, 9 Jan 2023 15:09:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53BACC433EF; Mon, 9 Jan 2023 15:09:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673276993; bh=2kIP3L1wWIjQqgSeLLlnsvTS3fRCyU9DXUFZ/TVnjuw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uxz94DM+mEx2aL2SgllefcbUc7VO+xh4J41AqR/r+FbyYqVKMqwZZ2k1XNXZNmb23 ZbaRpnU4h61VM6jhwqOOQsp7sruisQfql3o8/70L7pBNPj8yT0IZ3W4SRnBCc1uX46 z5cv7pfbwqJvVxCx/s9qIYu0gfp5SgEQILukmYtqdxtaOGB9frtlbn1cfeiRyVQxGD NpHWSNa2NiTKHTbzhIkUO0dlUe6RMGPfRe/NZBF/FS9q0D1WDHPo5++nmH2AsA8OPk xfeQRB7xdu35KElolRlRAzO/uhokgXBRg4EHUDq3TazpJ0eg7bR0RV1nRQn7MT4glP MrTfwII91QT9w== Date: Mon, 9 Jan 2023 09:09:51 -0600 From: Bjorn Andersson To: Souradeep Chowdhury Cc: Masami Hiramatsu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Sai Prakash Ranjan , Sibi Sankar , Rajendra Nayak Subject: Re: [PATCH V0 1/1] bootconfig: Increase max size of bootconfig from 32 KB to 256 KB for DCC support Message-ID: <20230109150951.ikdlkr6lmiapesmu@builder.lan> References: <654357bcbfd3974072a558c494a51edafaa73e1a.1673261071.git.quic_schowdhu@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <654357bcbfd3974072a558c494a51edafaa73e1a.1673261071.git.quic_schowdhu@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230109_070956_606188_AF18190D X-CRM114-Status: GOOD ( 21.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 09, 2023 at 08:01:05PM +0530, Souradeep Chowdhury wrote: > Increasing the memory size of bootconfig to be able to handle a max number of > 8192 nodes to be fitted in memory size of 256KB. > This states what the patch does, but not why. The description you put in the cover letter does capture the why, but the cover-letter won't be part of the git history (and if it was, there's no reason to keep the motivation separate from the change). So please move the motivation into the commit message. Also, there's generally no reason to have a cover-letter for a single patch "series". So please skip the --cover-letter. Regards, Bjorn > Signed-off-by: Souradeep Chowdhury > --- > include/linux/bootconfig.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/bootconfig.h b/include/linux/bootconfig.h > index 1611f9d..64d233b 100644 > --- a/include/linux/bootconfig.h > +++ b/include/linux/bootconfig.h > @@ -55,11 +55,11 @@ struct xbc_node { > } __attribute__ ((__packed__)); > > #define XBC_KEY 0 > -#define XBC_VALUE (1 << 15) > -/* Maximum size of boot config is 32KB - 1 */ > +#define XBC_VALUE (1 << 18) > +/* Maximum size of boot config is 256KB - 1 */ > #define XBC_DATA_MAX (XBC_VALUE - 1) > > -#define XBC_NODE_MAX 1024 > +#define XBC_NODE_MAX 8192 > #define XBC_KEYLEN_MAX 256 > #define XBC_DEPTH_MAX 16 > > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel