Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FFF4C54EBD for ; Mon, 9 Jan 2023 17:30:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 07589851A8; Mon, 9 Jan 2023 18:30:10 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="l8q4MPMu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3FC4581F28; Mon, 9 Jan 2023 18:29:44 +0100 (CET) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D09B08504C for ; Mon, 9 Jan 2023 18:29:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x836.google.com with SMTP id z12so8387558qtv.5 for ; Mon, 09 Jan 2023 09:29:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1nuWGseVJDw8Q8/UMxDq10+IRRBCtLzwcMc52QSAw1g=; b=l8q4MPMuQZzG6q4+5FnJwOitIQe0Vj6qecuNK2adB+jkdZRTeZjWE+Ct3vHduw4vt/ zA6G/19RuVQO0Ux8uUWsdmkj4TN8eLoc5Hjc8xS6iygHmjkd2XPdwPZGqXvu806O68jU p2uvCvTzGeVDoNKkdOwB3CCqFaIAQ7uFnoGs0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1nuWGseVJDw8Q8/UMxDq10+IRRBCtLzwcMc52QSAw1g=; b=K3Od5Fxz16HsoAVaKuMy9J8OsWWdWq8FMrl+VZa3vpbhUuvyqdciCZvYQLepCvMQxK ZMe3H40hST1/SkwJTovH/umWoaijeh+62DNw7hmXrWLvZhx4+ZRwx20aLfLIRbtrE3cV 0BB0m7PjN8HOSAT7VIiwhs64vjbJiBenGQGOQ2oDGUh5Ei7zZqewM4mIg/m/jaqs+KNh AtTdCmw5aXuYCeII/flWM6qeQlxBe+KbRcVnfz9hvxT7mk2sk3M2AX104+OukDt2BOLY dJlhebuO6sBq2M+GYUiAwCFpO1oiQLvXS8tMqUfSrvgCFVkHVVu/rIHzFU1ocPI3yMEv /TNg== X-Gm-Message-State: AFqh2ko59/9fmM4nveA52K80dKHSAtb3shQk144LFZZomR9lLjDNahfH uLltf3ln4Eg8weDeDPOlX3PeGw== X-Google-Smtp-Source: AMrXdXsTdzUmbXaBhOl3qAAHwbaXTlmNOfPBEN9Yd1rYFz/sIC4sxQGhSx7WX9h+mY4XaKqGymy7Ng== X-Received: by 2002:ac8:72d7:0:b0:3ae:c953:a716 with SMTP id o23-20020ac872d7000000b003aec953a716mr1167383qtp.32.1673285372063; Mon, 09 Jan 2023 09:29:32 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0159-9ce3-e1a8-fcba.res6.spectrum.com. [2603:6081:7b00:6400:159:9ce3:e1a8:fcba]) by smtp.gmail.com with ESMTPSA id i14-20020ac871ce000000b003a4f22c6507sm4854175qtp.48.2023.01.09.09.29.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 09:29:31 -0800 (PST) Date: Mon, 9 Jan 2023 12:29:29 -0500 From: Tom Rini To: Sinthu Raja Cc: u-boot@lists.denx.de, Marcel Ziswiler , Marek Vasut , Vignesh Raghavendra , Sinthu Raja Subject: Re: [PATCH V4 06/12] board: ti: j721s2: Add support for detecting multiple device trees Message-ID: <20230109172929.GW3787616@bill-the-cat> References: <20230104094350.19394-1-sinthu.raja@ti.com> <20230104094350.19394-7-sinthu.raja@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9eBA50N2Wg1hnvq7" Content-Disposition: inline In-Reply-To: <20230104094350.19394-7-sinthu.raja@ti.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --9eBA50N2Wg1hnvq7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 04, 2023 at 03:13:44PM +0530, Sinthu Raja wrote: [snip] > +#ifdef CONFIG_SPL_LOAD_FIT > +int board_fit_config_name_match(const char *name) > +{ > + bool eeprom_read =3D board_ti_was_eeprom_read(); > + > + if (!eeprom_read || board_is_j721s2_som()) { > + if (!strcmp(name, "k3-j721s2-common-proc-board")) > + return 0; What I'd like to see is a comment above this part noting that this is the safe default for the SoC. --=20 Tom --9eBA50N2Wg1hnvq7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmO8TvkACgkQFHw5/5Y0 tywLGQwAg/zCyMQJ2LWy1hrT2wPqnsbql3/hcPiO4lSWxTa/vhfNy6iRtmlTS7Nf qhMuLVNqk8IzYkl+B3MmQFLBC6iUQCdPirO21NwB9IiJGP76rHH9R0Q72Gs/uLj8 mfsBxxJ3qsZrvCikKt8RtJ0yoNJadvXJR1Xu9mLxGTGuzTY1l//jsXU6mHoTGrwz gXAKnxocJ/9kGZSkwdaa0xeyrnH/JJWG388+Uxg5im3s8G9ILFLEd6wk9zVtMf3E MsA5OVhrMlfpEIj/7FBc6fTM6pS5Y6o0m8nfKPs0CA9StFGPGvaIyNDJ+/ah10BW s3Qr4BoJDYLfs40zbXAA2DjzYPi029MZQrtfwezYoBQD96bnaVKANFuo/nuiuTb4 KFjhOubF5LhIp/NOaTEuNi3Lr3jSuUMyFAkl/tMBMRZ7S8Qn71YAGwygt3TYetGx B06VpKFsuniFtUgh7cmOw0mSynBMmacXYhveoy5EW1SLtiYcTUZlvmV5L7fu6zzq iMFOoPEH =/1G5 -----END PGP SIGNATURE----- --9eBA50N2Wg1hnvq7--