Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 876DFC5479D for ; Mon, 9 Jan 2023 19:00:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6B52683014; Mon, 9 Jan 2023 20:00:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="hEJOKSuV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8265583014; Mon, 9 Jan 2023 20:00:15 +0100 (CET) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8832282FE7 for ; Mon, 9 Jan 2023 20:00:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x830.google.com with SMTP id x11so8510262qtv.13 for ; Mon, 09 Jan 2023 11:00:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v1ojxqJgQ4oLI0lis/d5Z70/X3TQHNd8T3hy1iSJyPI=; b=hEJOKSuVog3nsRppfajMZ2rNTmi1ZY7bIz/lC7SgKdIG3m0lT0w1LrqUwmDR+KS3Qj DU4Q+MKBIC/CPHTHXyCTyOxgYb/wCowkUokm+BCrmV2l1wwvMZYc0aTpDV/LtCOTjnXv S+Z0H7vDYzCYEdahZyDhdpKcaft9C97gO/y4Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v1ojxqJgQ4oLI0lis/d5Z70/X3TQHNd8T3hy1iSJyPI=; b=6FOZgTT5sDxcQrOi2GgKBvHmfDMKZvZ6sLeQyMd8+fKgcWp8WkXSXrbLNRbZ0adtcu n0KOWW9/rjfP2OOX4Xl7X6e3utQebSTiIXi9qFrrWf0Mo9LAFHtm1FEfPPthYxfUicge +/6/LD6KOJLTQZbh4qVoAnCJNI/5p81cVMAyPkrwL4Fnr9ByU9Rg4p/7uvboiZmf5aoZ XgGZHYD0i7LTgNRWZcWtCrPgxtHQ3jYXeDwelpvS9FhW0wWgwjXwDrfSGDvSc5H4yM3a 8cv6NyYVkp3LWBB5+rEIhfZMDc5IUpJWmjcwFhJxHdvIdqAN0JDjgmbJ54o1BFJZuk3+ UHpA== X-Gm-Message-State: AFqh2kr5gJf8H3DuLzqIzu4eXS2XHkSd9TkuUeuL1//fqL4U+N3TZObf RB8vJYnnXL8GQig2dKHYBB0UG2ufjvucZVAT1LY= X-Google-Smtp-Source: AMrXdXsERPyv3G1fE7ape/sVT2My8LIS4JB9Ats30UZgm9rkFEumd/DNrmAYR0RAOlD8Ko1dv9adhg== X-Received: by 2002:ac8:7cc:0:b0:3ab:67cc:e8fe with SMTP id m12-20020ac807cc000000b003ab67cce8femr81347400qth.27.1673290808311; Mon, 09 Jan 2023 11:00:08 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0159-9ce3-e1a8-fcba.res6.spectrum.com. [2603:6081:7b00:6400:159:9ce3:e1a8:fcba]) by smtp.gmail.com with ESMTPSA id u12-20020a05622a198c00b003ade7d4ad7asm1225601qtc.10.2023.01.09.11.00.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 11:00:07 -0800 (PST) Date: Mon, 9 Jan 2023 14:00:05 -0500 From: Tom Rini To: Fabio Estevam Cc: sbabic@denx.de, u-boot@lists.denx.de Subject: Re: [PATCH] imx8mm-phg: Add board support Message-ID: <20230109190005.GD3787616@bill-the-cat> References: <20230109175955.1007160-1-festevam@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="18pjMHifPfmAdTuL" Content-Disposition: inline In-Reply-To: <20230109175955.1007160-1-festevam@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --18pjMHifPfmAdTuL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 09, 2023 at 02:59:55PM -0300, Fabio Estevam wrote: > Add the board support for the i.MX8MM Cloos PHG board. > =20 > This board uses a imx8mm-tqma8mqml SoM from TQ-Group. >=20 > imx8mm-phg.dts and imx8mm-tqma8mqml.dtsi are taken > directly from Linux 6.2-rc3. This is going to need to be rebased on top of current master due to CONFIG -> CFG or Kconfig migration. On top of that: [snip] > create mode 100644 board/cloos/imx8mm_phg/README This needs to be doc/board/cloos/imx8mm_phg.rst (and related index, etc changes). [snip] > +#ifndef CONFIG_SPL_BUILD > +#define BOOT_TARGET_DEVICES(func) \ > + func(MMC, mmc, 1) \ > + func(MMC, mmc, 2) \ > + func(DHCP, dhcp, na) > + > +#include > +#endif No, you cannot guard stuff with CONFIG_SPL_BUILD as that way leads to inconsistencies. There should be no size impact in SPL from having this. > +/* Initial environment variables */ > +#define CONFIG_EXTRA_ENV_SETTINGS \ > + BOOTENV \ > + "scriptaddr=3D" __stringify(CONFIG_SYS_LOAD_ADDR) "\0" \ > + "kernel_addr_r=3D" __stringify(CONFIG_SYS_LOAD_ADDR) "\0" \ > + "image=3DImage\0" \ > + "console=3Dttymxc1,115200\0" \ > + "fdt_addr_r=3D0x43000000\0" \ > + "boot_fit=3Dno\0" \ > + "fdtfile=3Dimx8mm-phg.dtb\0" \ > + "initrd_addr=3D0x43800000\0" \ > + "bootm_size=3D0x10000000\0" \ > + "mmcdev=3D0\0" \ > + "mmcargs=3Dsetenv bootargs console=3Dttymxc1,115200 root=3D/dev/mmcblk$= {mmcdev}p${mmcpart} rw rootwait quiet\0" \ > + "bootcmd=3Denv exists mmcpart || setenv mmcpart 1; run mmcargs; \ > + mmc dev ${mmcdev}; \ > + load mmc ${mmcdev}:${mmcpart} ${loadaddr} boot/Image; \ > + load mmc ${mmcdev}:${mmcpart} ${fdt_addr_r} boot/${fdtfile}; \ > + booti ${loadaddr} - ${fdt_addr_r}\0" And all of this should be in a text based environment instead. The macros from distro boot have to stay in the header, for now, but the rest does not. > +#define CONFIG_SYS_SDRAM_BASE 0x40000000 > +#define PHYS_SDRAM 0x40000000 > +#define PHYS_SDRAM_SIZE 0x80000000 /* 2GB DDR */ Please make sure we need to define PHYS_SDRAM* at all. Thanks! --=20 Tom --18pjMHifPfmAdTuL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmO8ZDUACgkQFHw5/5Y0 tyyGfQv/dfF0QL3F7UocmR6K95v2i8Gr8wRxozbuG88YFCfcM7YFNE1PCm/XauJY yFt3lF5UCU8jDhr64wWkhD3EF33ShwaKubM9YpkVRaLSdY8X/loZvJZC6eaXZIvi wNqb9znlER05rfyxQjxUJxbGPMlrzc9B4iHbM8Eaf3VMeZPcU/IOIxoto5BCicEj TZIzT2EkjP4N4HDl7FCB9htgCOfzXfVK1/dj+7I7whMDHQn01Me93srdzfsfjFCI hpiEyFK47zf6E0tnMZzo1Wn5D4xsWrNyJK9a8nuqd/we8DhFhmOcoaQ8cMVmRmKW tMJigHxGdHJLoVqeCzZyqWBfkx90AQ26WrZ9N7/8DtEG57a0dH4KV7P2Wp7ikHwq 6ONPxfMpXXhz8B5C6HEsbYNeZE+Oy1rjznmYdGvJk8qdNi64HihtEP3GbxEDnQ5B RfMWEO9sIS3LBYOH30H9Xcnalp2Hb4xvw98BEpizxJsay7rE76evFJ7KUPG6qQVd gN7KRxrj =thsY -----END PGP SIGNATURE----- --18pjMHifPfmAdTuL--