Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C08B1C5479D for ; Mon, 9 Jan 2023 20:39:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C37DD8431A; Mon, 9 Jan 2023 21:39:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="AxGZZZc3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AF6B28431A; Mon, 9 Jan 2023 21:39:10 +0100 (CET) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 99B9183D17 for ; Mon, 9 Jan 2023 21:39:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x830.google.com with SMTP id jr10so1755993qtb.7 for ; Mon, 09 Jan 2023 12:39:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1p7iM90bZAletbENXlR/8C9NkqFcBvix5F3bYXS+Vl8=; b=AxGZZZc3xQkV/KKJJYMt7ozRcLdaqCP8YDGEeP2S1f5rJ386qt/ZzA6PI1dO995ptT VwAedPJX4RX3WtMorKUk9aKbCWk62UvA4DM++/qH/6NE/1QLIvN1lGtfevaMiXebLL1S MvKxN7mWixYbLqwgibMmRs90obx+UosC/ZMWA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1p7iM90bZAletbENXlR/8C9NkqFcBvix5F3bYXS+Vl8=; b=axcPL0U84P5hHZFhlMl0Xd4ZDv9fvUqIpok8leeQrzvVAXEGHEDeOuLz4w7xKtaSdR rOe11eApg4/KSj86Mn0bKDkc7JqHGQ6E47/WGGBTPYdkwjXwmu0GwT8px4a/q2o4+sR5 3Y3cDRrGSTgzqKnf14Q4eOO2EljgIb3iNX8VnMysaV0yC/fDeTk62LcdmJY+Dcad/egi dlvbFHwAqBjoEFxFmGWC0wSSmFje1J4XQF/BI3CGcxYOtogq7QFiTcG8YS/97FpxIyES uBwAXzxhFmef9y5JdCAF+DSf9o6khjlE+z78C/XHNbzICkzNQk7X2E4AlhSy9e4tmFDP 51gQ== X-Gm-Message-State: AFqh2kpdE14FONjw09sYkbSgvDVSJ5aUXMHYzCEUiWDdwBR155ZhjhOW 1cb89/7Qh741IFETV7gHcdDgTKJhKwgs0+RkRRM= X-Google-Smtp-Source: AMrXdXvss9sslhhUFuVdBz4OTuAlsQ2gYE2zMojI5LxEo5MFeo1ml4rQAUA8ssLHciKd1PoFT7mQOQ== X-Received: by 2002:ac8:490c:0:b0:3ac:fba0:cde with SMTP id e12-20020ac8490c000000b003acfba00cdemr6958829qtq.22.1673296746239; Mon, 09 Jan 2023 12:39:06 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0159-9ce3-e1a8-fcba.res6.spectrum.com. [2603:6081:7b00:6400:159:9ce3:e1a8:fcba]) by smtp.gmail.com with ESMTPSA id r3-20020ac87943000000b003a7f597dc60sm2821411qtt.72.2023.01.09.12.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 12:39:05 -0800 (PST) Date: Mon, 9 Jan 2023 15:39:03 -0500 From: Tom Rini To: Fabio Estevam Cc: sbabic@denx.de, u-boot@lists.denx.de Subject: Re: [PATCH] imx8mm-phg: Add board support Message-ID: <20230109203903.GG3787616@bill-the-cat> References: <20230109175955.1007160-1-festevam@denx.de> <20230109190005.GD3787616@bill-the-cat> <44817526eb70304eeb1f1d9c227e0cf1@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nyluY2s9hhGu3PrS" Content-Disposition: inline In-Reply-To: <44817526eb70304eeb1f1d9c227e0cf1@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --nyluY2s9hhGu3PrS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 09, 2023 at 04:35:07PM -0300, Fabio Estevam wrote: > Hi Tom, >=20 > On 09/01/2023 16:00, Tom Rini wrote: >=20 > > This is going to need to be rebased on top of current master due to > > CONFIG -> CFG or Kconfig migration. On top of that: >=20 > Ok, I will rebase on top of the current master. >=20 > > > +#define CONFIG_SYS_SDRAM_BASE 0x40000000 > > > +#define PHYS_SDRAM 0x40000000 > > > +#define PHYS_SDRAM_SIZE 0x80000000 /* 2GB DDR */ > >=20 > > Please make sure we need to define PHYS_SDRAM* at all. Thanks! >=20 > Sorry, I don't understand this comment. >=20 > PHYS_SDRAM and PHYS_SDRAM_SIZE are used by arch/arm/mach-imx/imx8m/soc.c. OK, so those defines are used. There's a surprising amount of unused defines that end up in include/configs/ so I want to be sure when I see a new one pop up. As a tangent, are these actually board specific? My first glance is that we're just saying where memory could be, rather than is all of memory and so it should just be a static "starts here, takes up the remaining 2GB of address space". --=20 Tom --nyluY2s9hhGu3PrS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmO8e2QACgkQFHw5/5Y0 tyyluAv7BJmNR7AoDgroLqCZITeOmpBTrqmxF1amoBVTNYD8sYR6ooDiQS9AP28D ucUi3YDiU70aPkmSTEoP3Gx2UCJfbesA/NKCt/n2Tr1yMiVEGODm7XJa+UbRnekv NQ8t7uF94NoTMycsBnRpj+NOvLbLAcDaN8LAh6pIYapdTRNW+nLdppwsBWYDSmfU +ovAJp5iqaM/e6yV+UcyBcnjNjGrxyJbaZTtowbYOsfUpDyF2px0aKRD089yTFtN YmCHk9iRhTlCz7FOwWSSide/hYH5o1/5BmtyJI/R4r3y5ksLeEfRmqActI5jPENQ Eqa5MM/O/V2d4tHUaDsL24EMZHuXedJD4m/isYL8de2wZ0QnHhQteoZYtU5VLYA9 DHi1Jq1xZlxIABnQ4X4QoXbtH9sqm+zQDhxYJlIC5YkYwrLHKiOB8eGdN0F+67RZ 8dY04axyRm3sXErfcjx2yuGmp3rlAAKRhaGLkBezOTlYHSglEk43ADLje0IbWr/B /CbjUFQJ =LvHt -----END PGP SIGNATURE----- --nyluY2s9hhGu3PrS--