Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C3CDC54EBD for ; Thu, 12 Jan 2023 15:20:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CA1888549F; Thu, 12 Jan 2023 16:19:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="aOrh2Opg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 40177852B5; Thu, 12 Jan 2023 16:18:55 +0100 (CET) Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6A68085477 for ; Thu, 12 Jan 2023 16:18:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-4b6255ce5baso243283607b3.11 for ; Thu, 12 Jan 2023 07:18:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jCDHL4GdTq3O0xPJ0zsU6J5qyBzLf7hWMWx426Pgiac=; b=aOrh2OpgJXLZW0t+Svn+p3cLrI81YtA01jguXy7yVtBpRQTS9do6N5zaGZFR1GIRpE UBIBPL4v0Md3+lcz75birhKU9r6u9eoXfIHgHvtSnDEn4lHIVI8BM92AvC4BalyuMWYa seieYQDND0kqY7+jVv0mVP9cQv6fAqeMvJNUY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jCDHL4GdTq3O0xPJ0zsU6J5qyBzLf7hWMWx426Pgiac=; b=j7edRXGJN6bR9tgZJb9keygFkJIKhaVeSoueftyDdRXYVqknToTjWdZrlEP2UW99U5 vYYaZjCTi8kD5eGrwhVbSWRo6xbtde9qbnaiTvvvXtANfaNlMtXctMK0k3ZJDqHg/I/3 UDcxtIvYLMe95W8Xvpburtp9CxPD6tqVs0eihKCRybuyPbbv1DuKCt8cc2zOu5H3xo93 LciMD+7N8Ye6T8A9Lav4dQnbfEgkINuuViGnCBFkNk1fDi+dpfeqDlr+FYChnAMnxvQh K1qYB+izgcjoY6jZmn5rKCF3UxC3I8Er2ILarVjoHk1fxnPS2vCQ5XIUrGL6BHX47xI9 9pGA== X-Gm-Message-State: AFqh2krNYfwxE3o4Wo0ZfPaJO5lzp96oep/qaU4Ar/uRlWVO/pWF1lCN AMVvjbTRVeJOSreJc2WL5oIGMg== X-Google-Smtp-Source: AMrXdXvmLkOhXzl9ykB63G0it5qDLjviN37HEmehzXTs+YxarLNn1SVX/rxL808i5xwe0y7HIucVUQ== X-Received: by 2002:a05:7500:2c0a:b0:f1:9862:ed72 with SMTP id ep10-20020a0575002c0a00b000f19862ed72mr136250gab.12.1673536731121; Thu, 12 Jan 2023 07:18:51 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-38c4-8177-7e9d-a94f.res6.spectrum.com. [2603:6081:7b00:6400:38c4:8177:7e9d:a94f]) by smtp.gmail.com with ESMTPSA id h9-20020a05620a244900b006cf38fd659asm11066520qkn.103.2023.01.12.07.18.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jan 2023 07:18:50 -0800 (PST) Date: Thu, 12 Jan 2023 10:18:48 -0500 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, Hector Palacios , Adrian Vovk , Pantelis Antoniou , Simon Glass Subject: Re: [PATCH v2 1/2] cmd: exit: Fix return value propagation out of environment scripts Message-ID: <20230112151848.GG3787616@bill-the-cat> References: <20221220062600.809064-1-marex@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="O+HvS4AZO7TEzAdz" Content-Disposition: inline In-Reply-To: <20221220062600.809064-1-marex@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --O+HvS4AZO7TEzAdz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 20, 2022 at 07:25:59AM +0100, Marek Vasut wrote: > Make sure the 'exit' command as well as 'exit $val' command exits > from environment scripts immediately and propagates return value > out of those scripts fully. That means the following behavior is > expected: >=20 > " > =3D> setenv foo 'echo bar ; exit 1' ; run foo ; echo $? > bar > 1 > =3D> setenv foo 'echo bar ; exit 0' ; run foo ; echo $? > bar > 0 > =3D> setenv foo 'echo bar ; exit -2' ; run foo ; echo $? > bar > 0 > " >=20 > As well as the followin behavior: >=20 > " > =3D> setenv foo 'echo bar ; exit 3 ; echo fail'; run foo; echo $? > bar > 3 > =3D> setenv foo 'echo bar ; exit 1 ; echo fail'; run foo; echo $? > bar > 1 > =3D> setenv foo 'echo bar ; exit 0 ; echo fail'; run foo; echo $? > bar > 0 > =3D> setenv foo 'echo bar ; exit -1 ; echo fail'; run foo; echo $? > bar > 0 > =3D> setenv foo 'echo bar ; exit -2 ; echo fail'; run foo; echo $? > bar > 0 > =3D> setenv foo 'echo bar ; exit ; echo fail'; run foo; echo $? > bar > 0 > " >=20 > Fixes: 8c4e3b79bd0 ("cmd: exit: Fix return value") > Reviewed-by: Hector Palacios > Signed-off-by: Marek Vasut Applied to u-boot/master, thanks! --=20 Tom --O+HvS4AZO7TEzAdz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPAJNgACgkQFHw5/5Y0 tyw2ggv+Ji0g4gQBmNcnGkrP8HIXetJURKOIqeAhsm4tq1uYgIbNRp76M38D5afT yghBdOgBNgmU6E1Py5EJms95k23l5tJ+hFDomQf8p2lubCtn9V/1AOkhqPs21yPQ CkwY003sPABUhj5zxN9q8BB0PXCXD2pzfDzhUmaewHDz793QDdacKp+eu6KRUIj+ e+x5mk+Osd43Q59kVL/l5Wu9/oYnUI8jtQkNsYLTp4wOPAgnkJeZaEpx0Mrr61A9 aa0puh/XBLYIr9z5A6Q1msXp/vE9cTvKb4G+1F4ovqybJgLoSbQCeX87RxLwqxTK NpUrVvyhbER5U2CGu7Zvm7M2QZEnDtyuhz8yEMzt57tV5KHsAAbRwDBEVyVbEY7J 0i0VbdCmOJGUyySYYOc6eljYB+FY6jk94PT8rj5VnI5pLb6bh7pIaGgV+10SB73n WG93ZkcmpXSc/gRtUS74ACF/ySAA07LdOniDBOmdl8R3Jind4Cp8FlOczVR75ktF UUnxGap8 =K5gA -----END PGP SIGNATURE----- --O+HvS4AZO7TEzAdz--