Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 202A2C54EBD for ; Thu, 12 Jan 2023 15:21:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D2ADD85560; Thu, 12 Jan 2023 16:19:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="oUZLyfqH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EEA6E8551B; Thu, 12 Jan 2023 16:19:22 +0100 (CET) Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E4B53854D1 for ; Thu, 12 Jan 2023 16:19:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-4db05a4db9bso21106857b3.10 for ; Thu, 12 Jan 2023 07:19:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HRPiutleFKzU384gg3rgspI3GlyDe7r/Q1LWlnEjviA=; b=oUZLyfqHnoyaytmrGMIQg5VEPD3WLxmshU907KaP69K4d5yEriMC24SqJw3yQpwzWM MNPnaG5XnZ/S1dtf+0H5rRJrKx2gpFU1G55OrpRtjWg04dv/YXKrty2WK747ay9nAx83 mXRsHv0tp0yZj07fsAnIsAG9YqHXyc77b/9HY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HRPiutleFKzU384gg3rgspI3GlyDe7r/Q1LWlnEjviA=; b=5rd+URLfO0UUkNcHl6L7JeoQ7piKl0s/4wH96OjA78I85m/RMZyWQMHu/tKVD33/Nv 7kiAMGkjR8Sm00moaxsJFqACh/HroyGcxkACg5EA56ySvS+uGLrNM7Km4steTm52bfKt PsNgWcRV1Sjz5QyM8UC1xo8czMfKIj0aNVeLGYKfqP16f5sshkPY7d597Ntwbfrj/+BE z4tYnGzKn2hBZDHA55DKL2xgchBZGWb10IxnRkYnUJOyQEY8ehbwAEH7LN9xCzt/Vm+T 1Xmvt1HoRdRiko+3Y9qHly3jV6BCriefdlc6o74fa2Lug3NXgzLOCAaTQBeU5srIdMxU aNGg== X-Gm-Message-State: AFqh2koN2F2XIeDtVNyQpaYn8wupIpmP7fZioQwjnr9v4/HKLWcBLR1F Shk1jwGcqg5UPLurqW+t99VAPg== X-Google-Smtp-Source: AMrXdXsB62V1/TLiBTl78pNYIW5BqF2QlXNsesojUFwYeIK3FTx2SdGBtDvw9Tizj2Hj2pokDKA0/Q== X-Received: by 2002:a05:7500:e0c:b0:f1:9d6b:20e4 with SMTP id ks12-20020a0575000e0c00b000f19d6b20e4mr145924gab.48.1673536758576; Thu, 12 Jan 2023 07:19:18 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-38c4-8177-7e9d-a94f.res6.spectrum.com. [2603:6081:7b00:6400:38c4:8177:7e9d:a94f]) by smtp.gmail.com with ESMTPSA id q6-20020a05620a0d8600b006fa43e139b5sm10926071qkl.59.2023.01.12.07.19.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jan 2023 07:19:18 -0800 (PST) Date: Thu, 12 Jan 2023 10:19:16 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , Stefan Roese , u-boot@lists.denx.de Subject: Re: [PATCH u-boot] ata: Fix dependency for CONFIG_SATA_SIL Message-ID: <20230112151916.GL3787616@bill-the-cat> References: <20221229171535.29846-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hwsqe4jH3GAadLT+" Content-Disposition: inline In-Reply-To: <20221229171535.29846-1-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --hwsqe4jH3GAadLT+ Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 29, 2022 at 06:15:35PM +0100, Pali Roh=E1r wrote: > sata_sil.c is PCI driver and without CONFIG_PCI is building of U-Boot fai= ling: >=20 > LD u-boot > ld.bfd: drivers/ata/sata_sil.o: in function `sil_exec_cmd': > drivers/ata/sata_sil.c:148: undefined reference to `dm_pci_phys_to_bu= s' > ld.bfd: drivers/ata/sata_sil.o: in function `sil_pci_probe': > drivers/ata/sata_sil.c:687: undefined reference to `dm_pci_get_bdf' > ld.bfd: drivers/ata/sata_sil.c:691: undefined reference to `dm_pci_re= ad_config16' > ld.bfd: drivers/ata/sata_sil.c:701: undefined reference to `dm_pci_ma= p_bar' > ld.bfd: drivers/ata/sata_sil.c:704: undefined reference to `dm_pci_ma= p_bar' > ld.bfd: drivers/ata/sata_sil.c:713: undefined reference to `dm_pci_wr= ite_config16' > ld.bfd: drivers/ata/sata_sil.c:717: undefined reference to `dm_pci_re= ad_config16' > ld.bfd: drivers/ata/sata_sil.o: in function `sil_cmd_identify_device': > drivers/ata/sata_sil.c:256: undefined reference to `dm_pci_phys_to_bu= s' > ld.bfd: drivers/ata/sata_sil.o: in function `sil_sata_rw_cmd': > drivers/ata/sata_sil.c:330: undefined reference to `dm_pci_phys_to_bu= s' > ld.bfd: drivers/ata/sata_sil.o: in function `sil_sata_rw_cmd_ext': > drivers/ata/sata_sil.c:377: undefined reference to `dm_pci_phys_to_bu= s' > make: *** [Makefile:1778: u-boot] Error 1 >=20 > Signed-off-by: Pali Roh=E1r > Reviewed-by: Simon Glass > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! --=20 Tom --hwsqe4jH3GAadLT+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPAJPQACgkQFHw5/5Y0 tyzYhgv+MXukvP6sIzwjP9J16w1Eqwuo2z/h8Zag/iSzrlCl/zlbFRhTe9PtUTX+ 0CRjKBO7ngKtrpD8NWsYNHrfkCtvN1YWUOhp2DdCAzCD85RAXTrq4KxGWQC3XVVX PZ+GKtQRd/4NcV7DPyB5CKOnBoKcieJYYMKMh5sidnmEAMeXG27NV75RyqVYbc8M 3k9eR5wj5Uee2Tj6iC8+UzuM+YP3QU1oT4IZNVe5H5fIBaSpsStcpGKngM9QW+t0 1dmTNgR3qfOZXYFD2Nv86Hcti8MrrJSr7RR9LAb1Uhn99QxvvIBU3Cb1qN8lTLwn mffrOjXylVjcetJk8XhjIIrfHRdBzJuz68/mITeIRyIVqnIoUaAPhvUsif5jIdE2 PUBbkox0V4yGLwPUk1zgIPSciz0rIUyDmaEW2wIc+lP2bD6I6bPFUdO/pM19TyEP TrZ6dZiV2IowGL5qlfvPIp9yWU8whc/syQYJk9FdZtwKjpDp2YmnbZlyFIMx3Lsj BQZqTdds =dezn -----END PGP SIGNATURE----- --hwsqe4jH3GAadLT+--