Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D16CC54EBD for ; Thu, 12 Jan 2023 16:22:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5EBAB8532C; Thu, 12 Jan 2023 17:22:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="MIAs8NJf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A0AD98532C; Thu, 12 Jan 2023 17:22:40 +0100 (CET) Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 18787852C4 for ; Thu, 12 Jan 2023 17:22:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-4b6255ce5baso246347377b3.11 for ; Thu, 12 Jan 2023 08:22:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rbY4z8uwA04jl1OXYBpuZq9GmHAx6cAB2t5APXR4XKo=; b=MIAs8NJfFrTQNQENJckpx4S+QilLG2byOnY7amX9bY07DkNaQPYm7XZOUnVMoFNrHM ZRAmKNvm0vjRbHYPObxTHAUahTPBcgIfVp2Y89oD+CEuL0Mhv29P/xX55XuR2E00APQ7 +k5eRBckmATZVkcQcG5YlzsKWtxmYYCbYeXQk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rbY4z8uwA04jl1OXYBpuZq9GmHAx6cAB2t5APXR4XKo=; b=drq0NjtcrdVC3k/ZfUxUzRkr2a2eak0eUr3clo1jMxhTb1bynfvsJpmQs6PUiTarQG RPBZYVqTarGoOC2l2Tkigia4V64sGvtJewmvE4OOiJhqC9lQXSoqRgfOhhNRkQFoJyl5 8W9ntghw9OsBGECiZzilvDPr1p35+0j/3ozAi72s+97lL3RcZeCkpJDr2ddn+qHklule KyiSoTpmNGLcckiessyfcpu/8pTrcOlTtRjXU+MJgn4n3iaVCW4fABEuQlurSyS0/9Nt nM9rJWSG9GVep+trEmIfCzlOUtNlW1Nj7qzMUUzBaZ0b8eYzFRkvLcZoHA8scnwz/EVt Re8Q== X-Gm-Message-State: AFqh2kqBLEqmagFf+/+EnxpuXNaLeAbXcHOeq0/EZ346q3T1ifGUCrNf Pyw+hTJ9MZeuov41Yb5m5W3nlA== X-Google-Smtp-Source: AMrXdXt5vTrdUUJYSR9k7C1FVrhMz6k3vkeEIFKv83R/fKi+xkmo5nb/B8DwG/lAzPPQ1pElDH4lUw== X-Received: by 2002:a05:690c:30c:b0:45b:d6fc:81fb with SMTP id bg12-20020a05690c030c00b0045bd6fc81fbmr29841275ywb.15.1673540555811; Thu, 12 Jan 2023 08:22:35 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-38c4-8177-7e9d-a94f.res6.spectrum.com. [2603:6081:7b00:6400:38c4:8177:7e9d:a94f]) by smtp.gmail.com with ESMTPSA id d6-20020a05620a240600b006fc2f74ad12sm11205770qkn.92.2023.01.12.08.22.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jan 2023 08:22:35 -0800 (PST) Date: Thu, 12 Jan 2023 11:22:33 -0500 From: Tom Rini To: "Maier, Brandon L Collins" Cc: Simon Glass , "u-boot@lists.denx.de" Subject: Re: [PATCH v2 1/2] lib: zstd: update to latest Linux zstd 1.5.2 Message-ID: <20230112162233.GR3787616@bill-the-cat> References: <20221227144613.48752-1-brandon.maier@collins.com> <20230102163006.GM3787616@bill-the-cat> <20230107173842.GO3787616@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XHeMxdqO3tRxhhDC" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --XHeMxdqO3tRxhhDC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 12, 2023 at 04:20:45PM +0000, Maier, Brandon L = Collins wrote: > Hi Tom >=20 > > On Fri, Jan 06, 2023 at 11:26:36PM +0000, Maier, Brandon L: > > > > From: Tom Rini > > > > It's all not ideal, yes, but it looks like BTRFS is the main user, = right now, which > > > > isn't widely enabled. So maybe we can look towards improving upstre= am a > > > > bit here, if motivated. > > > > > > I can't speak for the BTRFS code as I don't have a suitable platform > > > to test it on. But the zstd code does appear to be broken on master. > > > Running the zstd compression test in sandbox or sandbox64 both > > > segfault. And I have similar problems trying to decompress FIT images > > > on our AARCH64 platform. The primary motivation to this patch is that > > > the new version does work. And this seems like the appropriate fix > > > given Linux has abandoned the original version of this code. > >=20 > > Well, I guess in the end, non-functional smaller code is factually worse > > than larger functional code, so, I'll pick this up post v2023.01, > > thanks! >=20 > I did some deeper investigation and discovered a bunch of functions were = being inlined that caused about 3k of growth. As well as a BMI2 feature tha= t can be disabled to save about 800B on x86 platforms. With those it brings= the code size change to about -3k for arm64, and +1k for arm. I'll send a = v4 patch series shortly. Oh nice, thanks! --=20 Tom --XHeMxdqO3tRxhhDC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPAM8IACgkQFHw5/5Y0 tyy8qAwAoC0035ab/0MXe52bjedG8ILK1Sh2XjV7RWun+28sEayNzK9IYbzvi+Tb qv+1Q3xnCTl6UxB6zGy5+Tuq/SRW79FRcqUeuU6xF8SLAfc9etIQesRZWRBLekI9 mcQpazvHylGb8XJkXung6P19DgIoyU7JFeWqPO3V+v5+26kEWOAQxPnb86XpFo7q 7ZMvx57ZbdYM34eM67o6QpAQOjRsKybfpDTtx189NMbE1HW5tP8jS4gAc/lWHCf5 jADe49MDRqH14rPbqHzu97IGJZv+Jb8Yt5uQltEsdY+JhpDan7HEwRC4sYFA8Pik +Rw8G+mydkO2Av6ezT4iKeu8+bwfEYkye4EhIf1O4Xk/7sFuf73J2A8n0Epum55g W4tGNcXId/UpPP+PvYLw/ZMB+pPuxBv4Dah88ammGTZuE1cZ/e43qzgWNQp/7tpm CQ3809yviYpuSZvtRpr/f/6ccjEh9FNPUdqxnRMeYtJvfgA2elygIe/kxzQowT8i h6TLXDVk =JGgv -----END PGP SIGNATURE----- --XHeMxdqO3tRxhhDC--