From: Alexander Aring Date: Thu, 12 Jan 2023 17:10:33 -0500 Subject: [Cluster-devel] [PATCH dlm/next 3/7] fs: dlm: be sure to call dlm_send_queue_flush() In-Reply-To: <20230112221037.1882548-1-aahringo@redhat.com> References: <20230112221037.1882548-1-aahringo@redhat.com> Message-ID: <20230112221037.1882548-3-aahringo@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit If we release a midcomms node structure there should be nothing left inside the dlm midcomms send queue. However sometimes we have this case because I believe some DLM_FIN message didn't got acked... if we run into a timeout handling then we should be sure there is no pending send dlm message inside this queue when releasing midcomms node structure. Cc: stable at vger.kernel.org Fixes: 489d8e559c65 ("fs: dlm: add reliable connection if reconnect") Signed-off-by: Alexander Aring --- fs/dlm/midcomms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/dlm/midcomms.c b/fs/dlm/midcomms.c index 2e60d9a2c883..a3eb19c8cec5 100644 --- a/fs/dlm/midcomms.c +++ b/fs/dlm/midcomms.c @@ -1402,6 +1402,7 @@ static void midcomms_node_release(struct rcu_head *rcu) struct midcomms_node *node = container_of(rcu, struct midcomms_node, rcu); WARN_ON_ONCE(atomic_read(&node->send_queue_cnt)); + dlm_send_queue_flush(node); kfree(node); } -- 2.31.1