From: Alexander Aring Date: Thu, 12 Jan 2023 17:18:47 -0500 Subject: [Cluster-devel] [PATCH dlm/next 6/8] fs: dlm: remove newline in log_print In-Reply-To: <20230112221849.1883104-1-aahringo@redhat.com> References: <20230112221849.1883104-1-aahringo@redhat.com> Message-ID: <20230112221849.1883104-7-aahringo@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit There is an API difference between log_print() and other printk()s to put a newline or not. This one was introduced by mistake because log_print() adds a newline. Signed-off-by: Alexander Aring --- fs/dlm/midcomms.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/dlm/midcomms.c b/fs/dlm/midcomms.c index 3932c7cf0e7a..b5720042ef9d 100644 --- a/fs/dlm/midcomms.c +++ b/fs/dlm/midcomms.c @@ -467,7 +467,7 @@ static void dlm_pas_fin_ack_rcv(struct midcomms_node *node) break; default: spin_unlock(&node->state_lock); - log_print("%s: unexpected state: %d\n", + log_print("%s: unexpected state: %d", __func__, node->state); WARN_ON_ONCE(1); return; @@ -540,7 +540,7 @@ static void dlm_midcomms_receive_buffer(union dlm_packet *p, break; default: spin_unlock(&node->state_lock); - log_print("%s: unexpected state: %d\n", + log_print("%s: unexpected state: %d", __func__, node->state); WARN_ON_ONCE(1); return; @@ -1269,7 +1269,7 @@ static void dlm_act_fin_ack_rcv(struct midcomms_node *node) break; default: spin_unlock(&node->state_lock); - log_print("%s: unexpected state: %d\n", + log_print("%s: unexpected state: %d", __func__, node->state); WARN_ON_ONCE(1); return; @@ -1369,7 +1369,7 @@ void dlm_midcomms_remove_member(int nodeid) /* already gone, do nothing */ break; default: - log_print("%s: unexpected state: %d\n", + log_print("%s: unexpected state: %d", __func__, node->state); break; } -- 2.31.1