From: Alexander Aring Date: Thu, 12 Jan 2023 17:18:49 -0500 Subject: [Cluster-devel] [PATCH dlm/next 8/8] fs: dlm: remove unnecessary waker_up() calls In-Reply-To: <20230112221849.1883104-1-aahringo@redhat.com> References: <20230112221849.1883104-1-aahringo@redhat.com> Message-ID: <20230112221849.1883104-9-aahringo@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit The wake_up() is already handled inside of midcomms_node_reset() when switching the state to CLOSED state. So there is not need to call it after midcomms_node_reset() again. Signed-off-by: Alexander Aring --- fs/dlm/midcomms.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/dlm/midcomms.c b/fs/dlm/midcomms.c index 2a9177f3d468..42ab77f0b28b 100644 --- a/fs/dlm/midcomms.c +++ b/fs/dlm/midcomms.c @@ -534,7 +534,6 @@ static void dlm_midcomms_receive_buffer(union dlm_packet *p, midcomms_node_reset(node); pr_debug("switch node %d to state %s\n", node->nodeid, dlm_state_str(node->state)); - wake_up(&node->shutdown_wait); break; case DLM_LAST_ACK: /* probably remove_member caught it, do nothing */ @@ -1262,7 +1261,6 @@ static void dlm_act_fin_ack_rcv(struct midcomms_node *node) midcomms_node_reset(node); pr_debug("switch node %d to state %s\n", node->nodeid, dlm_state_str(node->state)); - wake_up(&node->shutdown_wait); break; case DLM_CLOSED: /* not valid but somehow we got what we want */ -- 2.31.1