Received: by 2002:a17:907:c68a:b0:84d:2074:29bb with SMTP id ue10csp415216ejc; Fri, 13 Jan 2023 06:07:53 -0800 (PST) X-Google-Smtp-Source: AMrXdXvvzDTYJP3JHAWgH4Vpomd9Npmd3zc6nqw9Su9MGgbxUXzrNdyPWYPWlo7432BF7Iohoodc X-Received: by 2002:a05:600c:4e07:b0:3d3:5319:b6d3 with SMTP id b7-20020a05600c4e0700b003d35319b6d3mr58852422wmq.38.1673618873051; Fri, 13 Jan 2023 06:07:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673618873; cv=none; d=google.com; s=arc-20160816; b=NYumKlIeEGxEiOwn/iJw1E41wifCfM1o0pXBhpzMnbRUbJA90laRlOcY3HZXd0Tdlq kmLVsresaKkqrDLrAXyf7ZUHf8cRHuyP35zIPuV9HQZavmYhgfKpyMYVkUB6FUR1qlhU q7kgoKACK9XdJSJ09963aupd7ID8jcf8tdPrEFltRbsjPJxAVCMdM/+iy359ECBNEjHR bQl6q5mi/U0Jum0sOrQJr/10HcTf4dVg04QKQtZOehZgDHQ2oiRPPg6jI19nDw+d/9np XZzJQ5HmxIQJYS4LAVFwOisFH/Z0nM9yg1z5u1VNgqhxTEPdVcs5aEUufcybxaWGIE5R H84g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature; bh=C56PoPNICwIYCT3/f+wk8ZKNvqt6JkfVufjT+8YFQcE=; b=DPLCiQec9NoPbWvkqOTRUHa0/JF09FfhiXkaiNLsuxX+NBBLrd3uma5P2QRNbQU1Iu Fsy7+sFRfYxGCVYGBBYhInCYqEolIpeswrE7+IgZwnN+KPKNml1FxD0jd1++ts0RVtIo 30oM19NMQTaOyDcwYtu+9mn2OZsCla3iuP+T91toEcZVwfJ6b6IFP1BySeV6whg4l1AA /XjWDlWXj4qIzPuAahODApSM+vMH0EAJ4Mb4jXTEIypZ1M3GztA93Ixi1fmKO8tyDFs+ j1VRAYaalr8/07BP9YrCUDwZicr33Ad8tNz0vHf4oPAHU/h1gJGMYWl0zo442qYi8Mct 6WIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=cOv0H6BB; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=5AY2GUxn; spf=pass (google.com: domain of farosas@suse.de designates 2001:67c:2178:6::1c as permitted sender) smtp.mailfrom=farosas@suse.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de. [2001:67c:2178:6::1c]) by mx.google.com with ESMTPS id m2-20020a7bce02000000b003cf6ab0ce6asi16878933wmc.30.2023.01.13.06.07.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 06:07:53 -0800 (PST) Received-SPF: pass (google.com: domain of farosas@suse.de designates 2001:67c:2178:6::1c as permitted sender) client-ip=2001:67c:2178:6::1c; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=cOv0H6BB; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=5AY2GUxn; spf=pass (google.com: domain of farosas@suse.de designates 2001:67c:2178:6::1c as permitted sender) smtp.mailfrom=farosas@suse.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 897494E6A0; Fri, 13 Jan 2023 14:07:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1673618872; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C56PoPNICwIYCT3/f+wk8ZKNvqt6JkfVufjT+8YFQcE=; b=cOv0H6BBLVlzyES4dztOibocw0JUkLcpr08CfUIshY32g7CBKlVvzKjOlXu/wYm4/2F4PN dsWQHlPc48mqzGc+kMKxOjX3IBvm6GdQh2mALhyDfbRnofT9ezGSAhCOmZvSLH9E02SXO7 Ka575DaqfJp8UIu1S30De1JAhTh8vbg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1673618872; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C56PoPNICwIYCT3/f+wk8ZKNvqt6JkfVufjT+8YFQcE=; b=5AY2GUxn1zGF2GyF9KymzGo5jeyftPns84yr4e7iQbwbKcUmcuKtjVNQ5FxJkT6Pbef3KY sH/4qi7h64ajT/Dg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E59151358A; Fri, 13 Jan 2023 14:07:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id gKA7K7VlwWP8DQAAMHmgww (envelope-from ); Fri, 13 Jan 2023 14:07:49 +0000 From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Claudio Fontana , Eduardo Habkost , Alexander Graf Subject: [RFC PATCH v3 27/28] arm/Kconfig: Always select SEMIHOSTING when TCG is present Date: Fri, 13 Jan 2023 11:04:18 -0300 Message-Id: <20230113140419.4013-28-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230113140419.4013-1-farosas@suse.de> References: <20230113140419.4013-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: nB/NBBcw1OaL We are about to enable the build without TCG, so CONFIG_SEMIHOSTING and CONFIG_ARM_COMPATIBLE_SEMIHOSTING cannot be unconditionally set in default.mak anymore. So reflect the change in a Kconfig. Instead of using semihosting/Kconfig, use a target-specific file, so that the change doesn't affect other architectures which might implement semihosting in a way compatible with KVM. The selection from ARM_v7M needs to be removed to avoid a cycle during parsing. Signed-off-by: Fabiano Rosas --- configs/devices/arm-softmmu/default.mak | 2 -- hw/arm/Kconfig | 1 - target/arm/Kconfig | 7 +++++++ 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/configs/devices/arm-softmmu/default.mak b/configs/devices/arm-softmmu/default.mak index 6985a25377..24fb5f0366 100644 --- a/configs/devices/arm-softmmu/default.mak +++ b/configs/devices/arm-softmmu/default.mak @@ -39,6 +39,4 @@ CONFIG_MICROBIT=y CONFIG_FSL_IMX25=y CONFIG_FSL_IMX7=y CONFIG_FSL_IMX6UL=y -CONFIG_SEMIHOSTING=y -CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y CONFIG_ALLWINNER_H3=y diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 17fcde8e1c..e6f984fea8 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -312,7 +312,6 @@ config ARM_V7M # currently v7M must be included in a TCG build due to translate.c default y if TCG && (ARM || AARCH64) select PTIMER - select ARM_COMPATIBLE_SEMIHOSTING config ALLWINNER_A10 bool diff --git a/target/arm/Kconfig b/target/arm/Kconfig index 3f3394a22b..60278ea9f7 100644 --- a/target/arm/Kconfig +++ b/target/arm/Kconfig @@ -4,3 +4,10 @@ config ARM config AARCH64 bool select ARM + +# This config exists just so we can make SEMIHOSTING default when TCG +# is selected without also changing it for other architectures. +config ARM_SEMIHOSTING + bool + default y if TCG && (ARM || AARCH64) + select ARM_COMPATIBLE_SEMIHOSTING -- 2.35.3