Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BA4FC3DA78 for ; Sat, 14 Jan 2023 02:00:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 62412854E2; Sat, 14 Jan 2023 03:00:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="opFUQ9Fb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 37FAE85405; Sat, 14 Jan 2023 03:00:28 +0100 (CET) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 02D87854E2 for ; Sat, 14 Jan 2023 03:00:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x829.google.com with SMTP id k11so3427891qth.3 for ; Fri, 13 Jan 2023 18:00:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=raW6Tr6LBC6a6p0uT/7t2iDAf+7lAt7fqG0lZOjHeUk=; b=opFUQ9FbCnGeAGyk8eyQN/gmV5dJti5u/CVK7PynAMmz9VhXCH1LMzmww2LmB6CxGX Rf6KmZYhirQeW6pS2ex0WJPAeCsr3QEeFVAci7xnx7BgkHaxzeioMl+dsu1O1TzOEDuH s8reTycBt6tY0YSC/Ih5R+88mg49GtPBHsvwQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=raW6Tr6LBC6a6p0uT/7t2iDAf+7lAt7fqG0lZOjHeUk=; b=hqe/LK/ivlDnxCkLtDywMO/OM7ups5bRY4p16HkYhXWo3LLio65f4qnjwXvjIaDpYU SRavPHd0hgxe8ZD1/ufoWnOmheTtUAvKKu02+ndc21eXHQZg3K8lCJdsNeichr+5czhc Yb4DkO6ZiAG+Qr12p4YR3+eTAdmnx8ix7YM+eOUITUwZj/lrU70R1cHyG49T7aK/+ck8 mIxfx7ABcEGwGPBMunT79AOx1yCpfQwJl8ixGsBkCUr5nCdzG2bBb+IoG/iIefXPy3j7 TUjafD3fkW3MchQr+JRuxwt33LuE8eFIA+Y5O0t+SeRe+wNyfXCsRujWzkoRX+rIySYb I5WQ== X-Gm-Message-State: AFqh2ko/fOQgZwqyU8SS0I6ZHPQ36Eucjk/dJ0dkopL4YNUCKGaew8v1 MxtlFtST3Iw7S6F18BlWDS7Uwg== X-Google-Smtp-Source: AMrXdXsjYSnWcZLmZCTLQqy+L0erCRhm4Ri3tnUx2wY/GNylGzwgcR80tcsf5A0sF5EZks5wHalMVg== X-Received: by 2002:ac8:554c:0:b0:3a5:25d4:2f2d with SMTP id o12-20020ac8554c000000b003a525d42f2dmr96620679qtr.65.1673661623683; Fri, 13 Jan 2023 18:00:23 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-a538-813d-bada-d144.res6.spectrum.com. [2603:6081:7b00:6400:a538:813d:bada:d144]) by smtp.gmail.com with ESMTPSA id s10-20020a05620a29ca00b006fcb77f3bd6sm13841084qkp.98.2023.01.13.18.00.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 18:00:23 -0800 (PST) Date: Fri, 13 Jan 2023 21:00:21 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Tony Dinh , U-Boot Mailing List , Stefan Roese , Marek =?utf-8?B?QmVo77+9bg==?= , Chris Packham , Michael Trimarchi , Mark Kettenis , Simon Glass , Jaehoon Chung , Marek =?iso-8859-1?B?QmVow7pu?= Subject: Re: [PATCH] ddr: marvell: a38x: Add support for DDR4 from Marvell mv-ddr-marvell repository Message-ID: <20230114020021.GA3880571@bill-the-cat> References: <20230114003856.9208-1-mibodhi@gmail.com> <20230114014132.mtv5r7kbdl4z4zsf@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CE+1k2dSO48ffgeK" Content-Disposition: inline In-Reply-To: <20230114014132.mtv5r7kbdl4z4zsf@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --CE+1k2dSO48ffgeK Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 14, 2023 at 02:41:32AM +0100, Pali Roh=E1r wrote: > On Friday 13 January 2023 16:38:55 Tony Dinh wrote: > > @@ -16,4 +19,9 @@ obj-$(CONFIG_SPL_BUILD) +=3D mv_ddr_build_message.o > > obj-$(CONFIG_SPL_BUILD) +=3D mv_ddr_common.o > > obj-$(CONFIG_SPL_BUILD) +=3D mv_ddr_spd.o > > obj-$(CONFIG_SPL_BUILD) +=3D mv_ddr_topology.o > > +obj-$(CONFIG_SPL_BUILD) +=3D mv_ddr4_mpr_pda_if.o > > +obj-$(CONFIG_SPL_BUILD) +=3D mv_ddr4_training.o > > +obj-$(CONFIG_SPL_BUILD) +=3D mv_ddr4_training_calibration.o > > +obj-$(CONFIG_SPL_BUILD) +=3D mv_ddr4_training_db.o > > +obj-$(CONFIG_SPL_BUILD) +=3D mv_ddr4_training_leveling.o > > obj-$(CONFIG_SPL_BUILD) +=3D xor.o >=20 > And all these new files are ddr4 specific, so should be wrapped in makefi= le section: > ifdef CONFIG_DDR4 Looking at the Makefile in question, I think we might want to make the whole thing ifdef CONFIG_SPL_BUILD ... endif and then more finely control building of what objects are built. Perhaps: drivers/Makefile:obj-$(CONFIG_ARMADA_38X) +=3D ddr/marvell/a38x/ should only be for SPL instead, even? --=20 Tom --CE+1k2dSO48ffgeK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPCDKwACgkQFHw5/5Y0 tyywTQv/bIRn15Lb5eVYi/QpsBhJ8Wc0OJSddM9EUN5nvRG1CcyYMkpudCHSZfSa 4MsxU/G51ST97pLa4Pwj/zyDa/xJkSBZAtksRxp3kIisWcRguuntpvX0Q7f7BBUB EekiqOyHJ2cUfmrnHWgrzO6HS291zF4fUcU5FCtRIf/D1XM48npUbhTQ8Rp0tpTz DSP3+21xt2dyKLIF/2Tv4RvYMV6jEnXyj4j9S2XO6CSpyqkswPzsUKACS+Um0ero ncBiaKJg225rBchFLwrLEZiwg3FTEYZOizWIlIl0pXltLRs88IqsS9sMwWC0+ipG mW7JeVCIIldpF5DoebBY+qehRNYeoNuBDVeZ9OMw1+2iKQ7MDckocyBqVzAL3eXz sFoDcj72C/Y1x1vCwtOEDa871RTykgYnT3hZpx40W3SE6qErKwBfoQFy51GxU7PD VagexiSBkilBBCrqjaQ+Nj0tUbL56WOwdHjndl69BI0ZrTEaKQH9s74awDectbDb ndd6WM35 =ovkN -----END PGP SIGNATURE----- --CE+1k2dSO48ffgeK--