Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98217C63797 for ; Tue, 17 Jan 2023 13:57:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A653C85479; Tue, 17 Jan 2023 14:57:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="jXZGvLl2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C0A8885479; Tue, 17 Jan 2023 14:57:23 +0100 (CET) Received: from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com [IPv6:2607:f8b0:4864:20::e2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E898A8555D for ; Tue, 17 Jan 2023 14:57:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-vs1-xe2c.google.com with SMTP id 187so1558199vsv.10 for ; Tue, 17 Jan 2023 05:57:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sTu49pshl1JWdzQTBR1+KF12ZwbKDBsk89bINL6yuOU=; b=jXZGvLl2XvrlpAYEt6ztPkGH1ET/UsOfjMGWLcLme31r5t9LG2jRP2hNsUUTmbpHrV X+xPUMAbGM66CqhCAPARRhKbMMBJLtRw07bDJzYUSjxmM+Jd9absaS47nhPRRyVGIy2C J7oLH88z0OOaiCkAWMJGU8cjmrLUzoCrsDk8U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sTu49pshl1JWdzQTBR1+KF12ZwbKDBsk89bINL6yuOU=; b=S8EhmJsY5pnRpJgEJ6zgH5bebhGAW/u3tqsuvIpE3ofrVvqlC43dlMrfBLu3dji49F RR3bERXf8JkxqiR3pWd3vzofw0KxUj44LEEluqMCqtlijHNhuEOhw6bTgzbifOeOO5+/ Fy//lpU2sRspvKeUn7jRezYsx4GSZt18eGNLe0VWx3ZDUY2uk17NrDXqJ/TBa+gvzYYm Kk2l30WQMl2KoZXEDXpJhdwCYESWa7CvyIP7rId2CC92UNTcKU6j3c7EMu4lpflBSx/8 zt/tjd3tcr2sXSUWskjOUfS4y+8ws0tb1WcrTn2EVRwe+1Nbu+ThPXv6hMJPzIRsU3VR dDEw== X-Gm-Message-State: AFqh2kp5PonQxRUMLgxMJ2FTu5+hz1i6u9+xe7cVcmkuQA7fvUlgp9/R 4wnY4YsCywGgCf7wYFh04u/Nxg== X-Google-Smtp-Source: AMrXdXsNTmCVRMWnhrnS+mbx9QFbg0Yk+8Ah593Ml9EHYIgwiMuvGSs5zD44V0KUK5D7Gy13tCtajQ== X-Received: by 2002:a05:6102:5582:b0:3ce:eac6:f52b with SMTP id dc2-20020a056102558200b003ceeac6f52bmr1291617vsb.12.1673963836669; Tue, 17 Jan 2023 05:57:16 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-3487-94a5-6d7e-19f3.res6.spectrum.com. [2603:6081:7b00:6400:3487:94a5:6d7e:19f3]) by smtp.gmail.com with ESMTPSA id r18-20020a05620a299200b006cebda00630sm20336322qkp.60.2023.01.17.05.57.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 05:57:16 -0800 (PST) Date: Tue, 17 Jan 2023 08:57:14 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Anatolij Gustschin , Heinrich Schuchardt , Joe Hershberger , Marek Vasut Subject: Re: [PATCH v3 00/25] bootstd: Add a boot menu Message-ID: <20230117135714.GC3880571@bill-the-cat> References: <20230106145243.411626-1-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eUqGrSc0O7wKBRnC" Content-Disposition: inline In-Reply-To: <20230106145243.411626-1-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --eUqGrSc0O7wKBRnC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 06, 2023 at 08:52:18AM -0600, Simon Glass wrote: > So far standard boot lacks a boot menu, although it is possible to create > a rudimentary one using the existing 'bootmenu' command. >=20 > Even then, this text-based menu offer only basic functionality and does > not take full advantage of the displays which are common on many devices. >=20 > This series provides a 'bootflow menu' command which allows the user to > select from the available bootflows. An attempt is made to show the name > of the available operating systems, by reading more information into the > bootflow. A logo can be read also, where supported, so that this can be > presented to the user when an option is highlighted. >=20 > Full use is made of TrueType fonts, if enabled. For cases where only a > serial console is available, it falls back to a simple text-based menu. >=20 > All of this is implementing using a new 'expo' construct, a collection of > scenes (like menu screens) which can be navigated by the user to view > information and select options. This is fairly general and should be able > to cope with a wider array of use cases, with less hacking of the menu > code, such as is currently needed for CMD_BOOTEFI_BOOTMGR. >=20 > Of course it would be possible to enhance the existing menu rather than > creating a new setup. Instead it seems better to make the existing menu > use expo, if code space permits. It avoids the event-loop problem and > should be more extensible, given its loosely coupled components and use of > IDs instead of pointers. Further motivation is provided in the > documentation. >=20 > For now the CLI keypress-decoding code is split out to be used by the new > menu. The key codes defined by menu.h are reused also. >=20 > This is of course just a starting point. Some ideas for future work are > included in the documentation. >=20 > Changes in v3: > - Rebase to master With a minor change to add a doc comment to include/expo.h, this has been applied to u-boot/master, thanks! --=20 Tom --eUqGrSc0O7wKBRnC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPGqToACgkQFHw5/5Y0 tyxJfwv/ZDOCrWGA4zQWlYdfrfV4uA5wVbVEEhfYoA5vetoqFMMPGK32BJoBipqh OcgO9B+gxD/ukXFHOL6l3Gu0NLWLlOI/IxrhT8ncyORu+sKQUHod3jeNazVAzqcB 3TSc/5ytYVtvDZ2AbyLVjabuDTloYxtxn4ShX/XfROB/u8wNyDDUh3b9cv3PovLu DJ5IOyGOmJG6BycDGUnyx1kjHiCj2d+4WCiBgguhaC4DbIMcYz/s/gkakryhDzxs 1v7Ld4T5wUK4bVdVJWksQCedGLh0aqReFQgaKN82OPG1KbFeWlKsnO1XT5Z763Pw xp0ToMSrlGNvpEEgnlzgaFq3ISLV38Ph59IEE+jvgUz/eRBIHVmsqpKeMRBy8ajK xF+KbYBUNEQThGiC42YfNH1NTPjuKuobg9lLo4DWcfcQknsaux6B8Bp+kDs0A8al Dbvm0QZR8OG95Ydn0Uc0Df6zKEWy6qVgMbeP9Wm8pK4PCYITg+7smSubUlwHBVyg F9RrqlO/ =Vpue -----END PGP SIGNATURE----- --eUqGrSc0O7wKBRnC--