Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B8EDC32793 for ; Wed, 18 Jan 2023 18:36:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231157AbjARSgr (ORCPT ); Wed, 18 Jan 2023 13:36:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230509AbjARSgW (ORCPT ); Wed, 18 Jan 2023 13:36:22 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0104C56880 for ; Wed, 18 Jan 2023 10:36:20 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 802E0B81E9D for ; Wed, 18 Jan 2023 18:36:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23584C433EF; Wed, 18 Jan 2023 18:36:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674066978; bh=1wDgrUABev5KcpnNy1JLDVFONe7DixRkGZmFQej7Deo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PxCEkivWDpW7lgQC3PCe/Z1xqd9NnSMtXxyioXD9cXQnIpJfomQPBEoLBS+Zrn1XX +HsPdf1mO1ubA3by0d/Knri85PDuKX26mxFdgGpPJqKwzDbN4rZ073lIa7c0VoRQyr wZBOVc13TDlbzimQ6GLTKdBPYTYxovCG9bkwr/LF14dIwh6AdZpXoKV761qAegu1Ui +j6hb+aue+aD5znWooHq3UhUsAmJx3pWux+sTlqkIL0z5wig1nzLiGl2m4z1+r7k+w d1VMfnY0t8SIvakOgRTecWsk/BhwyCKssVP+DX9IUwIm25TimrwcJH6FguEB3aJpVl bqAnmV4o51OZg== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Roi Dayan , Maor Dickman Subject: [net-next 11/15] net/mlx5e: Warn when destroying mod hdr hash table that is not empty Date: Wed, 18 Jan 2023 10:35:58 -0800 Message-Id: <20230118183602.124323-12-saeed@kernel.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230118183602.124323-1-saeed@kernel.org> References: <20230118183602.124323-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Roi Dayan To avoid memory leaks add a warn when destroying mod hdr hash table but the hash table is not empty. Signed-off-by: Roi Dayan Reviewed-by: Maor Dickman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/mod_hdr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/mod_hdr.c b/drivers/net/ethernet/mellanox/mlx5/core/en/mod_hdr.c index 17325c5d6516..cf60f0a3ff23 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/mod_hdr.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/mod_hdr.c @@ -47,6 +47,7 @@ void mlx5e_mod_hdr_tbl_init(struct mod_hdr_tbl *tbl) void mlx5e_mod_hdr_tbl_destroy(struct mod_hdr_tbl *tbl) { + WARN_ON(!hash_empty(tbl->hlist)); mutex_destroy(&tbl->lock); } -- 2.39.0