Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E830EC00A5A for ; Thu, 19 Jan 2023 16:37:03 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B1EE1DF5; Thu, 19 Jan 2023 17:36:11 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B1EE1DF5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1674146221; bh=7BqGXbp+0MXrBCi9UBVE06meqnRc4ODle+NYJ7NGtkk=; h=From:To:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=mCkHZ38VGT/L24mir4p64dl940c9GFwMviY3l2C0Y1bLEpZJzSgfbnD2N8HhlLfye PJWY2JsH+3+vqXVeT06XM7/H3zqALEd5Mk6z92aMsSYIOba6OghDQbR3iRWPGUdHfK QKzq7zUUnpudLWh1x+AJMnmPlh/WdQmnGBLzh54E= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5E98CF804DE; Thu, 19 Jan 2023 17:36:11 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 70A49F804EC; Thu, 19 Jan 2023 17:36:09 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 10AF2F80083 for ; Thu, 19 Jan 2023 17:36:04 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 10AF2F80083 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=dpkpA/7K DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674146166; x=1705682166; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7BqGXbp+0MXrBCi9UBVE06meqnRc4ODle+NYJ7NGtkk=; b=dpkpA/7Ksr7C/3v7Ge+LB+Ju7XzfiZJvS8YHDlgetRgLSzsx6i/7L6dK AqP7jsFPKem1Lt1HIA5D5B4khegsvVn/QOvtKywwX3gbifwGicmRKccAc bYK0bHGSFAObNmlqCBYCWK7m67231Jl3D3uSbVzYy/Q2IPn/gUOtTsWlO VBVGo/V76+uxlaLjeh12VYVxHVLjckmFy5XjfLhPaWvonbJ4/9WB/rm70 YnJYwbksnHm0UO0p9qUXvYdxmf6drg5Kr7YfMUJQq+nQonC5dOb+40rEq rBC6Wsh3FB5L2tBUAz0MsXsqrOcGFx7MsD5Xw+1kfSrjlBGifvT/T/GwB w==; X-IronPort-AV: E=McAfee;i="6500,9779,10595"; a="323029595" X-IronPort-AV: E=Sophos;i="5.97,229,1669104000"; d="scan'208";a="323029595" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2023 08:36:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10595"; a="662162976" X-IronPort-AV: E=Sophos;i="5.97,229,1669104000"; d="scan'208";a="662162976" Received: from eliteleevi.tm.intel.com ([10.237.54.20]) by fmsmga007.fm.intel.com with ESMTP; 19 Jan 2023 08:35:58 -0800 From: Kai Vehmanen To: alsa-devel@alsa-project.org, broonie@kernel.org Subject: [PATCH 1/4] ASoC: Intel: sof_rt5682: always set dpcm_capture for amplifiers Date: Thu, 19 Jan 2023 18:34:56 +0200 Message-Id: <20230119163459.2235843-2-kai.vehmanen@linux.intel.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230119163459.2235843-1-kai.vehmanen@linux.intel.com> References: <20230119163459.2235843-1-kai.vehmanen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kai.vehmanen@linux.intel.com, yung-chuan.liao@linux.intel.com, lgirdwood@gmail.com, peter.ujfalusi@linux.intel.com, pierre-louis.bossart@linux.intel.com, ranjani.sridharan@linux.intel.com, daniel.baluta@nxp.com Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Pierre-Louis Bossart The amplifier may provide hardware support for I/V feedback, or alternatively the firmware may generate an echo reference attached to the SSP and dailink used for the amplifier. To avoid any issues with invalid/NULL substreams in the latter case, always unconditionally set dpcm_capture. Link: https://github.com/thesofproject/linux/issues/4083 Signed-off-by: Pierre-Louis Bossart Reviewed-by: Ranjani Sridharan Reviewed-by: Péter Ujfalusi Reviewed-by: Bard Liao Signed-off-by: Kai Vehmanen --- sound/soc/intel/boards/sof_rt5682.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/boards/sof_rt5682.c b/sound/soc/intel/boards/sof_rt5682.c index 2eabc4b0fafa..71a11d747622 100644 --- a/sound/soc/intel/boards/sof_rt5682.c +++ b/sound/soc/intel/boards/sof_rt5682.c @@ -761,8 +761,6 @@ static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev, links[id].num_codecs = ARRAY_SIZE(max_98373_components); links[id].init = max_98373_spk_codec_init; links[id].ops = &max_98373_ops; - /* feedback stream */ - links[id].dpcm_capture = 1; } else if (sof_rt5682_quirk & SOF_MAX98360A_SPEAKER_AMP_PRESENT) { max_98360a_dai_link(&links[id]); @@ -789,6 +787,9 @@ static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev, links[id].platforms = platform_component; links[id].num_platforms = ARRAY_SIZE(platform_component); links[id].dpcm_playback = 1; + /* feedback stream or firmware-generated echo reference */ + links[id].dpcm_capture = 1; + links[id].no_pcm = 1; links[id].cpus = &cpus[id]; links[id].num_cpus = 1; -- 2.39.0