Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 567A6C05027 for ; Mon, 23 Jan 2023 07:47:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230040AbjAWHr2 (ORCPT ); Mon, 23 Jan 2023 02:47:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229989AbjAWHr1 (ORCPT ); Mon, 23 Jan 2023 02:47:27 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C49DA5E3 for ; Sun, 22 Jan 2023 23:47:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=bzz7JaksZDKcHo94Mdn5kYAvotNtBXiOtl7bTdgyn8s=; b=bwTty7r5OnHPaCKqAKUl3UjVx7 +pkpYjcBDVigQXzRVHqVZrf5dxK0oD28Y8M5BDwqUypSvYFb8EMMD3DAFePOX5D0DE+CDtaPz0GQN grNYFIqMmYBZearBWaCMHLC6gRZgTCCWp2J1o09N54mAPg3RYZaxUolowTmggy2EoeKAfc0qqPkbw ux8mESha8aILcbFpDQ0kqX8KUI12+Na1zSUpuJgpUQcP1v2rezKif9qlMlsvt3nvlbuTTgEAyIf3u 8uzt0F3wUoGuQzR9q114Vkgktq5W7lsiu/23T3i0zdMej6l0Ylf+H82Hj1Tc5c05r3wKUQ8Lks/Uo R4ZHjwCg==; Received: from [2001:4bb8:19a:27af:cb3f:eabc:1c16:9756] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJrY2-00GGmS-7s; Mon, 23 Jan 2023 07:47:22 +0000 From: Christoph Hellwig To: jim@jtan.com, geoff@infradead.org Cc: linux-block@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH] ps3vram: remove bio splitting Date: Mon, 23 Jan 2023 08:47:18 +0100 Message-Id: <20230123074718.57951-1-hch@lst.de> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org ps3vram iterates over the bio one segment, that is page aligned and max page sized chunk, a time. Because of that there is no point in calling bio_split_to_limits, or explicitly setting the default limits that are only used by bio_split_to_limits. Signed-off-by: Christoph Hellwig --- drivers/block/ps3vram.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/block/ps3vram.c b/drivers/block/ps3vram.c index 574e470b220b09..38d42af01b2535 100644 --- a/drivers/block/ps3vram.c +++ b/drivers/block/ps3vram.c @@ -586,10 +586,6 @@ static void ps3vram_submit_bio(struct bio *bio) dev_dbg(&dev->core, "%s\n", __func__); - bio = bio_split_to_limits(bio); - if (!bio) - return; - spin_lock_irq(&priv->lock); busy = !bio_list_empty(&priv->list); bio_list_add(&priv->list, bio); @@ -749,9 +745,6 @@ static int ps3vram_probe(struct ps3_system_bus_device *dev) gendisk->private_data = dev; strscpy(gendisk->disk_name, DEVICE_NAME, sizeof(gendisk->disk_name)); set_capacity(gendisk, priv->size >> 9); - blk_queue_max_segments(gendisk->queue, BLK_MAX_SEGMENTS); - blk_queue_max_segment_size(gendisk->queue, BLK_MAX_SEGMENT_SIZE); - blk_queue_max_hw_sectors(gendisk->queue, BLK_SAFE_MAX_SECTORS); dev_info(&dev->core, "%s: Using %llu MiB of GPU memory\n", gendisk->disk_name, get_capacity(gendisk) >> 11); -- 2.39.0