Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0530C61DA4 for ; Fri, 27 Jan 2023 02:52:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233616AbjA0Cw5 (ORCPT ); Thu, 26 Jan 2023 21:52:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233117AbjA0Cwy (ORCPT ); Thu, 26 Jan 2023 21:52:54 -0500 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67494196BA for ; Thu, 26 Jan 2023 18:52:50 -0800 (PST) Received: by mail-ej1-x630.google.com with SMTP id k4so4719835eje.1 for ; Thu, 26 Jan 2023 18:52:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=profian-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ndi8r0k5qmI5H0mD72hydSKAWjCqri28uGHpAKNsfwI=; b=J+MEjZcEMAozPoJMzOMGFuLh/rXFwKnSkJCp7M6wYzV1qCJ411aGKRONcTDWmZnpQt 60GCM69y32AM+8403zNk7TEwhFLcnZy+uTOYTZ1csLL8Fazp3sJQ5I7pPU6hL+Ma0CoL XooGUzX2iRIgrCoeTjE/d35TENVosv26T/K+nOae75Yw6bkPgRzg2pEemK9qr7oQ8DTK pWncSuCGRMmjNPAdPHAo+UypK/FBOhv2CuKtDMpKEIi9jjJqnfewmFdXlqd0s/H2lIGT 4dzc6RYV6rxqX7ECkEfB/AjYfGeLoIQrLco7rH3EKPXErc10gO2zX0k4r4GFrQwq698Q ZSdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ndi8r0k5qmI5H0mD72hydSKAWjCqri28uGHpAKNsfwI=; b=zJQOZk2i9wIYfEN5hKXgeOwD+kl8EufQgNU3DZlMh23MxKl5q692NyWq7SGhWr95jk Q780MiV02I+A/D6FVXjcdqboZHjRPOt2GyllhUV/Pjx4pdb6gkZaqo6s16M4lstgxB9D wEzbXU7j3sSe0xzhfWcBCreMFmIkVjmUYZtZWGFYsks2TsRJY5/dfitc5RQ6RX9Y1zS+ 61exog5MmIEXEO7/cx6IjQrXpeMZgDlmWWFX4eUVbbxyYzKnYhWK/5cIUQ4detNOf6La bj/JosY9ZCs7wQGhzew/YY/yeDjH7PT7q5Nwh+IPHY2yqMWi6HAndaXN0JTLsyzf8WjF NDjA== X-Gm-Message-State: AFqh2krCiZ/GlCugXpnLgyAwGJdvgGrRSVlecX02WLagZOtdvQtf259B a1GosjO9CU9TULA6D8NJaU4zzA== X-Google-Smtp-Source: AMrXdXu57VRGjXM7FMcpSFGz84LKNvBjg3pMXc2fVdX3CF8xPg1MMVN07PY+9CCaJ4FuB43Vd0BIVA== X-Received: by 2002:a17:907:8c14:b0:84c:e9c4:5751 with SMTP id ta20-20020a1709078c1400b0084ce9c45751mr41792387ejc.74.1674787968997; Thu, 26 Jan 2023 18:52:48 -0800 (PST) Received: from localhost (88-113-101-73.elisa-laajakaista.fi. [88.113.101.73]) by smtp.gmail.com with ESMTPSA id z16-20020a170906945000b0084d46461852sm1432144ejx.126.2023.01.26.18.52.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 18:52:48 -0800 (PST) From: Jarkko Sakkinen To: Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Cc: Harald Hoyer , Tom Dohrmann , Ashish Kalra , Michael Roth , Tom Lendacky , Jarkko Sakkinen , kvm@vger.kernel.org (open list:KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86)), linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)) Subject: [PATCH RFC 2/8] KVM: SVM: fix: initialize `npinned` Date: Fri, 27 Jan 2023 02:52:31 +0000 Message-Id: <20230127025237.269680-3-jarkko@profian.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230127025237.269680-1-jarkko@profian.com> References: <20230127025237.269680-1-jarkko@profian.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: Tom Dohrmann If UPM is enabled and getting the PFN fails, `npinned` is never set, but is read for the call to `unpin_user_pages`. Link: https://lore.kernel.org/lkml/Y6Sgwp%2FBofzCUrQe@notebook/ Signed-off-by: Tom Dohrmann Signed-off-by: Jarkko Sakkinen --- arch/x86/kvm/svm/sev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c index d3468d1533bd..6d3162853c33 100644 --- a/arch/x86/kvm/svm/sev.c +++ b/arch/x86/kvm/svm/sev.c @@ -510,7 +510,7 @@ static struct page **sev_pin_memory(struct kvm *kvm, unsigned long uaddr, { struct kvm_sev_info *sev = &to_kvm_svm(kvm)->sev_info; unsigned long npages, size; - int npinned; + int npinned = 0; unsigned long locked, lock_limit; struct page **pages; unsigned long first, last; -- 2.38.1