Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 383C4C05027 for ; Fri, 17 Feb 2023 09:43:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B5CA6B0072; Fri, 17 Feb 2023 04:43:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 765A56B0073; Fri, 17 Feb 2023 04:43:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 654B06B0074; Fri, 17 Feb 2023 04:43:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 553EF6B0072 for ; Fri, 17 Feb 2023 04:43:49 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1FB401C6F33 for ; Fri, 17 Feb 2023 09:43:49 +0000 (UTC) X-FDA: 80476296978.01.F974F90 Received: from mail3-163.sinamail.sina.com.cn (mail3-163.sinamail.sina.com.cn [202.108.3.163]) by imf14.hostedemail.com (Postfix) with ESMTP id CDAD110000D for ; Fri, 17 Feb 2023 09:43:45 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.163 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676627027; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s39KymYoc6O0Q/q1pcnrDqTDudjFHoZ8G0be31EetJo=; b=IDFrcM/YCP4gZE7rii8YTwBTUyS0RDYiG26mzQ+d5CVewgq1lH+9eygNGkqbIjb1Prd9Mt SdGTf7o4kaiFSN+zMg8SeL+wsofxlysGH/YJgOAxIRITnRIPq0Le5W5dCIhE1KSqizdQcc 2hFr6cayYC5n2DGTsvM2FLYh1r3ECAQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.163 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676627027; a=rsa-sha256; cv=none; b=GV3fI0hbrLJCnGp4oNoNZRBd7cvefwEC2ry8UPp3ITbW4hwQPGA6jh/jnpt9w+gHNqf3vd SHgxf/OJrgji3iq+JeOb6ps5JbSqyYhRu0+uR0paI0RyjNO2OU6yYr3oNGw/JNphrFrzcD 6E7cd0HeWCQTA6VzZmzg9+SSP8gPDuQ= Received: from unknown (HELO localhost.localdomain)([114.249.61.130]) by sina.com (172.16.97.27) with ESMTP id 63EF4BD400027CAE; Fri, 17 Feb 2023 17:41:41 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 68495049283324 From: Hillf Danton To: Waiman Long Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] locking/rwsem: Wake up all readers for wait queue waker Date: Fri, 17 Feb 2023 17:43:29 +0800 Message-Id: <20230217094329.1748-1-hdanton@sina.com> In-Reply-To: <0baab14d-abea-4248-e6d5-23c465f0a4a5@redhat.com> References: <20230213194832.832256-1-longman@redhat.com> <20230214030901.3250-1-hdanton@sina.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: CDAD110000D X-Stat-Signature: sqffmjhf3wsdw53qkfcansm9axj5kk59 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676627025-594491 X-HE-Meta: U2FsdGVkX18F4SxdpkB62qpkHNTeOzSdFQWFcOZk7DnkDZajSWhZkKn7C4/RSsJ2/t4GW8zH3Ifg0TrnUwqIrVuupaDmz/MVoAH89Il/MEH6mn0hww8GGsgQ4I8YkVmL5K/mMaPSJI4xbhjnMZ7lPFL8Lgz4GOyn+Tcse9/mvrRCuSCk6tzYlSIpzh79uJPvlhRHYvVQWhPCH2V204nXcsuwRssX6+1ryQMtoHQqrHQucDLTLeEQfBjGxeBtCnjfoEdBldvt01fcfYlOkwHBobQD2RDiZ6xr1PGroydvEByQ9ZrvdG+u40Lp7mFaoEn/PMKJNs/IQcrIh2ObMPA1hXO7ihlg3m7Vm9+y2lYAhcs/iScNM9sQS8QTRST5pXIUSPqxVMefJMKezvDMK27IxVXRgIcEQ03iKtcaa/Xksi+FZ5SXtL8ahfkcCDfew4TXQdVZCi+o5jXLRV5vB9jPQhlP8JRrHVsYdCD4IXsiWja0HiWfxvxR039X4UKfj3vQJY+J4Ach9WZKwBuY3d478YvIyNC4vM8KSYCXyuIRyopxBpoE8e70R9RvcAjVNb1TmWM5+gJXnfUC2BafeELIpir4t4vBzx/48mnl8V7JYE+B+cfacp6s3fRPsisw6KY9eFBXeiPwhjn7ZpQT+aguJuZgFfixpJfwsNY05LzeEd7vs2FAAV9DF6Mcv74D4EFZ40s98UCHI7irEx8UDRQrBticnhQEjasnJkFk5g4QnxpVPE6p4DT281Y2ohpwA+hwB4nX6fAn4zkMpfnWt1pDrEt93tVka5wJsO7yG2RHzZFvdnPjl+rw5xnCSi36+WV1ne2aiLGfutLH4o9jhNZnf5nVqWvCooO14wCQUGDWK5blEUx8Gq2Wirs6xWFsPf1YAY93w6MWA1taJJlsrzOtv5adbKbcLlDs96tVlosYa1ZXyAAS0Ck0QMygZJUb9wWtFatWxmBuExzGTdsb3ia VrTJ2M+O 6evvkquDzm5bZoDWroX4I8bDmEOvISfKQXfKro/qRjHDlPB7uhT3kTW4x8O4o9VItT32ATABWBJkwetIkTxjDR/ehDG5jsSPmjUGo0d1ZlOyrpArIrYxqwDN8b+AD06pZYSf05z1lJJchAhnUC/Ay1UCxyDVgc9nEGcWTN2rh6LGlhX0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.215848, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 16 Feb 2023 16:07:25 -0500 Waiman Long >On 2/13/23 22:09, Hillf Danton wrote: >> Downgrade is conceptually the right time to let all read waiters go >> regardless write waiter. > > Still, a downgraded task is still in the read critical section and we > shouldn't introduce arbitrary latency to that. Let's focus on the easy > one and we can discuss about other possibility later. Fair. Revisit it after this patchset lands upstream. Hillf