Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CE3279C1 for ; Tue, 21 Feb 2023 17:56:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD87DC433D2; Tue, 21 Feb 2023 17:56:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677002174; bh=i1G9p2HFfEsGEPBCun+w0p9u3T0NIUNu09S0UeZIsbg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ph/VR6MhjStUE0IqlCrdfg+ZiHOln3ZJN4CZxDKzhmqEkqVLEvcWOilw+RDHXXPRF K+BfYQ1mbAWBgbv+pMwSDAMJcT91d1yIKpVfkswkoOce16ITtuRye0rBO8thbhxr9z 1Jhg67DXRU3QC2Pntya3vep1MdKb2mgDuaNJwD1VvWl4crC+rIr+16imofuJQBoVKv 8N1M60Cn4ax0PljzN4maQtBqblStXdhuQ2EY9GbzmDPobiTRuvsduWe2HV0j2nCPsl 4aEqnJLjKufeFE0rnMubSnkWGG97hJrXxI8iUumSki/6oqGTa9Mx6FIiDDcLqKKCeO Urp3dLtJJmulg== From: SeongJae Park To: Anders Roxell Cc: sj@kernel.org, shuah@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 2/2] selftests: damon: change scripts to be executable Date: Tue, 21 Feb 2023 17:56:12 +0000 Message-Id: <20230221175612.131555-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230221070837.1502935-2-anders.roxell@linaro.org> References: Precedence: bulk X-Mailing-List: damon@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, 21 Feb 2023 08:08:37 +0100 Anders Roxell wrote: > When running kselftest-damon The following issues shows up: > > '# Warning: file debugfs_attrs.sh is not executable' > > Changing the scripts so they are executable. I tried to make similar changes before[1], but resulted in making a change in kselftest following Greg's comment[2]. So it might make sense to remove the warning message from kselftest instead of this change, though I think this change also looks good. Could I ask others' opinions? [1] https://lore.kernel.org/mm-commits/20210810112050.22225-1-sj38.park@gmail.com/ [2] https://lore.kernel.org/mm-commits/YRJisBs9AunccCD4@kroah.com/ Thanks, SJ > > Signed-off-by: Anders Roxell > ---