Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pUjAB-0007uA-Rv for mharc-grub-devel@gnu.org; Wed, 22 Feb 2023 02:03:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUj9I-0007O0-Pl for grub-devel@gnu.org; Wed, 22 Feb 2023 02:02:48 -0500 Received: from mail-am6eur05on2059.outbound.protection.outlook.com ([40.107.22.59] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUj9H-0006ui-BI for grub-devel@gnu.org; Wed, 22 Feb 2023 02:02:44 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LzdHV4uZktrUNp9XLv288Mn24vJ7ukmG1rjEjgGcwCgxffldXoL8EIkQHXKyjeCu6Gj48de9AA66FxQRnpwAO7X5te3Gi1H3YS+hVrDujvdUAmAKC+7NW1bhKdkn3nVPtuS5DALoFxxCLteXj174/vM2Mmns62M/HQy/xZKVB/0t2CJyTqRKiFj6l0t5fJKsDNtWJGwrrbMIbYYHy99tvfnPLqkxINGpaKoiW9tu2iqOrzAx6E4zkZrcTUXHapfa9Yp59q2fCyHt/Jur8DU2yEg0XhaZG3Ec+BFqZFqpvKqWcu45/zvReDguZZB7UQCvWlm1mGmaOuowaFyI9hGOTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1FiEng8dYHNU3L4+YB0LLolaiAWLAcJlikrmGvO2H6I=; b=DDxgSbKIJyJFW3uXb0NOHz7u2Y3bnccZbysSJznlt0AF0hk1Rd+hb0Rw53hGz9TDVHy3VWPjFMO5zWRUeq7RDhMGCSpydzHPxuB6W2aFLUeGLbosDcL3foQ09b8CFSIOds/osn3jOd8Fugs0craHdW6WgQSHL+sPWP8vJU/cZCVJ1C3uoAepeH3AOTg1Y5Fo3FxMcQZi58pf8Vun045ryUpP42lBzK6rRw6LfYt6xED4XUTaLLjJmJpuboApm04tlCDV6xy7Zpi9gKOthzvxLpRHAFIDZ/bl0htW6urpmRDmY99m/U2t8N4SG6wRaSPHV8HNfE8h9MofBqvOBux4TQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1FiEng8dYHNU3L4+YB0LLolaiAWLAcJlikrmGvO2H6I=; b=WhNi0kzN5byh3dyMsJL7rxd4MDDblACeITHse3bddsEmIa0+zmwkRUZx56Uh+Li9zY3Q71b6o6ESyqS8G4dDaBQjNE3hzJR8WMYQe3KmaquMO6iAJQRKiHf1bJ2G7MspxpRxudoepnjpUwqOVlgpvbxVGVz5BFj4cm9vs5w04yI/hFhy1fxjBhf/7bzGY9I0S+zMVea/5p6Endu85NszNSVnSQRuV1AerFmsVRlxuVUnXJ2nK8uLOTr3XXRSZdPMAKsaR675RF8mqvGXA2fqHuJzHROC6I398a3hkk5p0+KjHWiTH2Jj8CXR89V0nXa19GkTxMut2ZIE61mazjT0bw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DBBPR04MB6140.eurprd04.prod.outlook.com (2603:10a6:10:c7::18) by DBBPR04MB7980.eurprd04.prod.outlook.com (2603:10a6:10:1f0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Wed, 22 Feb 2023 07:02:00 +0000 Received: from DBBPR04MB6140.eurprd04.prod.outlook.com ([fe80::688f:bc10:59e2:772a]) by DBBPR04MB6140.eurprd04.prod.outlook.com ([fe80::688f:bc10:59e2:772a%6]) with mapi id 15.20.6111.021; Wed, 22 Feb 2023 07:02:00 +0000 From: Gary Lin To: grub-devel@gnu.org Cc: 'Hernan Gatta ' , 'Daniel Kiper ' , shkhisti@microsoft.com, jaskaran.khurana@microsoft.com, christopher.co@microsoft.com, daniel.mihai@microsoft.com, rharwood@redhat.com, jaredz@redhat.com, development@efficientek.com, jejb@linux.ibm.com, mchang@suse.com Subject: [PATCH 12/14] tpm2: pack the missing authorization command for TPM2_PCR_Read Date: Wed, 22 Feb 2023 15:00:52 +0800 Message-Id: <20230222070054.5122-13-glin@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230222070054.5122-1-glin@suse.com> References: <20230222070054.5122-1-glin@suse.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: FR0P281CA0008.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::13) To DBBPR04MB6140.eurprd04.prod.outlook.com (2603:10a6:10:c7::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR04MB6140:EE_|DBBPR04MB7980:EE_ X-MS-Office365-Filtering-Correlation-Id: 656bee26-2222-46b1-fc13-08db14a2b15e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hPlHu67O2uWRy00k+azVAUA4hup3oSHoBZlQiIUdyx+9jRxMzqS0hYOQonzMfX2H7u8QfZ/hWZvMQSuMufI8SyR1pf6XoQIIElQ5j//ZwP/renzDqCpq2u1CySmpU9DtF7M3QVe7CZRBWtvkFrxru/ye+mWs4FGnGXgEE1ZlYtfl13LyZHxsddn4m7KDDak8VBltcUI8FAsfci/WNzh0sLLwGhWcssA9AmNtso/47LPHGJBiVAE2XPeLf8sHPvv9aKUMn4A1852I6+fmU7MnAr+Z0VUbfuKudKG4PnOO5HFqaBTd+4GU0S4xa4cB1DlaW6YcECaTGL+kBwBPmnh6SrkK5KQrwYq3IOukV2ykb7v0fI4Mfb6RwIHdY7LSdGJH/GusTsYCZExHsvp9kV2rIx3PIu2aHBT0TKMZs98UrK9z3r8xe/D3/QiFewFhReIAUXQwRhIiXqervvDcBw/2xCoUdoF3OsrIBon6LLkny+OLRuqe750BcN7a0uPpUSuxWAyZZN881ptltttEMIlhpp17YLzgAi4M92ILipqNjUIMyGmH2W5oubsg3twTTkhoLVXAshgNJd9w91SZlYuKo4WUvHXOwsZFJeSn+AIYYYbxylGWnuR5h0Pumd9J7wCc X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR04MB6140.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(396003)(346002)(366004)(39860400002)(136003)(451199018)(316002)(83380400001)(54906003)(478600001)(38100700002)(36756003)(2906002)(4744005)(86362001)(66946007)(66556008)(66476007)(6916009)(4326008)(8676002)(41300700001)(8936002)(5660300002)(7416002)(2616005)(6486002)(26005)(186003)(6512007)(6506007)(1076003)(107886003)(6666004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?45ljH6xBSA5zH9om6paTyL3WH43ixdCmNFKpTYjjgYcQL83cdEIjz6/KVKS1?= =?us-ascii?Q?TdRtcDUYOQBeXswTelUvaRjFuyoQZar0E+fQMPUitVq1JguzyRn5u4MGsT/T?= =?us-ascii?Q?grEvHNaFg7vzFq96wyTCzDHYHh0FJH0ep7RFxYq8JemdD8BWFlmQCINaFpkp?= =?us-ascii?Q?4tfjVV6+VHIh+er15GoLo0O8lDGh1DwBPToW3dZvKPx2DOoNysltZ3jbI8un?= =?us-ascii?Q?IGfE3ZJ3QKedZmrFh+aJYbDlKPxonpotNGqmUBLH7FFgrZ71dYZqo3o4DEHR?= =?us-ascii?Q?vJq9zo61vMxh1VKd6W1xd1kOPSeaFRzGToGRYbMMfpB4oREKXuXIsFwGrX9e?= =?us-ascii?Q?WRJNubnAetk6dUMo5YeBRrYyld603BMt5yiEHuadqdbAvN2eyQ5mTF5CTKpp?= =?us-ascii?Q?m0mbgsUrePuquYCPJrBUpY5pmg9gERNLdsTPlsCxwLwsl2DNEhxnnp2xdmgm?= =?us-ascii?Q?ebktH6++plyGkJCkOJMU/O3KIjMQPF/Mz0z9xM2skzA5BVY0o50XwK0XNXzC?= =?us-ascii?Q?DO8z3QSTC03raIvGCBqMwhS0ZDLrgnAlFxErxmpDnPilQSGg8UQIMlB/AlwO?= =?us-ascii?Q?4Y7vNl7jM1134/kZ7YLlE6RjlJF3R3XqVds61+SWB0GfLlUb6lRgFRuP8Sfk?= =?us-ascii?Q?Ouv631ZFojpXJFKnl62DRpDdCrxs+lmBkz95a4xuVwe1WFgo9tR75p6wNX1n?= =?us-ascii?Q?DMYIhu6t7H09RMfLIPgWFA5ZYZA6bVsc6NxACQcWbpgybLKMfPs3tqoR0wZo?= =?us-ascii?Q?vzNM0mDdJ6gBCQ8AzzzXAxElBbLx1Z4HMaR2izBwzif175WkP7zBRlNNOj8b?= =?us-ascii?Q?BfMarXh0WrG9HjcSzxQq93j4n3RtR+pa5SuYBVmIz57tyDza1H6E4xmC1nfg?= =?us-ascii?Q?a0IlR2AgE9cBWT4TY/jMyxQo4mNjNSs7DRRhvE/xvTzo/ZCBiAOK1FqoSepz?= =?us-ascii?Q?Vgz/mi5CZoyafknW57fq+ZypykAYRXNqf4D3vCrL6GGzWRNUkrp+wiEIWKD8?= =?us-ascii?Q?10sicmEaLPhm8rz61tUu/poDZEs7okBSd0Bxq1Ao3hVPlxfVUegEn2urnhRj?= =?us-ascii?Q?FSeODogvXZ/T42HDcxyOSZiDs9b8ccRCoUQmz2L3XJBhNafIP1QcGujC8LVi?= =?us-ascii?Q?g58nzUK+iNMHecatmzmChTCjUVGVg4dAkvBWcNy0QXRAXqEOkQSq9rj8pBdz?= =?us-ascii?Q?3u+HMqGXqrgKhf5T2YGrRk4zLWWx6ixGhd4ukk+f+FCypIoQin+BfZGF5eTQ?= =?us-ascii?Q?efrRB8Pen9V7b7uuR8MaGeBajRDNciFYSBLrkHZKeheYJ/EErf5PcFbgiJPr?= =?us-ascii?Q?wzlH9lSg9baNw2eV+bX6Tg1NX2bMqWIWoTHGU7ENHl/mcjVut6DKHo9mZ7TP?= =?us-ascii?Q?LBERKH0Y/HDGID2SoHLAGHSe39MIgzjiROhlgWZXmNSZ5GcpgL8n2iPh+9i7?= =?us-ascii?Q?l5O0auoDG6bBhe0mNzFIWijzwMi+FHrR8ktwCOlwqYE+10ptAj4StSUWuCne?= =?us-ascii?Q?ycIR/CAjNHoF2reldfqkgjX5RHWiBExqpnu4KkvHyF12ALO+zpPl1Upm8yoa?= =?us-ascii?Q?CZt9Pd6deMXs7EJSydUGmJowoDd/ykwyVZtg5AfL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 656bee26-2222-46b1-fc13-08db14a2b15e X-MS-Exchange-CrossTenant-AuthSource: DBBPR04MB6140.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 07:01:59.9700 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wB3saZzGwbEk0oJRMk59roI5YlDPBmy9teDaq6pdfFx7ADqdNBKBPnrY8RkDHxYg X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7980 Received-SPF: pass client-ip=40.107.22.59; envelope-from=GLin@suse.com; helo=EUR05-AM6-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Feb 2023 07:02:53 -0000 When the caller of TPM2_PCR_Read() passes a valid authorization command, we should pack it into the 'in' buffer before sending the command. Signed-off-by: Gary Lin --- grub-core/tpm2/tpm2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/grub-core/tpm2/tpm2.c b/grub-core/tpm2/tpm2.c index ad9d52cd4..470fe7fc1 100644 --- a/grub-core/tpm2/tpm2.c +++ b/grub-core/tpm2/tpm2.c @@ -535,6 +535,8 @@ TPM2_PCR_Read (const TPMS_AUTH_COMMAND *authCommand, /* Marshal */ grub_tpm2_buffer_init (&in); + if (authCommand) + grub_tpm2_mu_TPMS_AUTH_COMMAND_Marshal (&in, authCommand); grub_tpm2_mu_TPML_PCR_SELECTION_Marshal (&in, pcrSelectionIn); if (in.error) return TPM_RC_FAILURE; -- 2.35.3