Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pUj8w-0006zi-Ra for mharc-grub-devel@gnu.org; Wed, 22 Feb 2023 02:02:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUj8a-0006tB-DO for grub-devel@gnu.org; Wed, 22 Feb 2023 02:02:02 -0500 Received: from mail-am6eur05on2057.outbound.protection.outlook.com ([40.107.22.57] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUj8Y-0006lx-1t for grub-devel@gnu.org; Wed, 22 Feb 2023 02:02:00 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bmokmY5VhqULsmGMDxVdth4Fx6QvShEnO2ZEg3sfamwy+Zk3bCx7oa2G5fnjPLBAstjF7jl9xbZ3wOWU3rFfrOMdDgEmZrRPnTKuHwYL3jxg0rjIkNq/EoD4UVrgypubPOa+439ljS+Y0cdQgy1xennl57qT6jLwbY/a0zP64qZRZ9pGkme5hbT1s2zg9KddIbDuqp+k7+WGOjX4XjZiAZLLDlZcAIQyRsjy5hefX4t+8MpfZ+ujm2EdGITB3e4D/68TrxXlIGwVqLdrl8EQ+/8+5o5Ks4dwo9YTenpB25LqDh+v1xQrs93y4tAGgGeKNZvn1NxQpT2JY7DvIBx/4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HTHIuTMyzcIZLLMuZEDG7bOlln8aOFHBo2bN3hB9rEQ=; b=l7efv+QZIMfuo8nIly6u+M7MvBTBW9mD49bEaGn9mXN5aMijq1I6W3NVyJ2SSRt/rrX+ljZA1L4W8gi/zmwTu6oo+bLzB94MRyhfpVI5c1ufZ9H7P7wBGJzudU/0v7sEnpvpymv5hgXQaZMkQ+PqaMrNGHVC9v32EEhrotTsdWe1brgjmNJJAc9HW42F8YnYOM/dYNW4RwGn0SZlInh+i4tYl5OKIb0eUYQWMc/U27WWfCYUgCwLy6/s49ks4hkUvw8H3ylyrEISkKh4acOGUv4n2Wtg3McTmJP4HI9atHVviNZ7tosw8fXEfLI7q+aTcpE53iBoO7Bjas9qmPoL9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HTHIuTMyzcIZLLMuZEDG7bOlln8aOFHBo2bN3hB9rEQ=; b=tHfzYaKZs29/OUZ4E30RH0c7kDZP9hOsqXuVtWoZoWOC+XTl+k+geoU13hBBIHc+N8JyQJSyCil0C/8+7QCq5c2rmyjirL01g4dRH0RJVoPBmdbsJzxRMHwlmUzpUANGTBRhsYDsNfu/Oh41XUA8Q8I/6+yttmws5TSt4a1EcT8j9nHMWsMdCRW77zJ5DpnxhWiISjMAEytxaK+jxsNwqwo30XU2mOSFfnYxy52MXKMiprgHXDqlccsMiKOtD41wEukuUX9hOi19J9ZLAuupFw1Fcv5b5bodvDFQ2M8r+TyoqQZKrvg7RcpBZNn4xobmRlliL0+2XzK5tDTeil0i/Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DBBPR04MB6140.eurprd04.prod.outlook.com (2603:10a6:10:c7::18) by DBBPR04MB7980.eurprd04.prod.outlook.com (2603:10a6:10:1f0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Wed, 22 Feb 2023 07:01:30 +0000 Received: from DBBPR04MB6140.eurprd04.prod.outlook.com ([fe80::688f:bc10:59e2:772a]) by DBBPR04MB6140.eurprd04.prod.outlook.com ([fe80::688f:bc10:59e2:772a%6]) with mapi id 15.20.6111.021; Wed, 22 Feb 2023 07:01:30 +0000 From: Gary Lin To: grub-devel@gnu.org Cc: 'Hernan Gatta ' , 'Daniel Kiper ' , shkhisti@microsoft.com, jaskaran.khurana@microsoft.com, christopher.co@microsoft.com, daniel.mihai@microsoft.com, rharwood@redhat.com, jaredz@redhat.com, development@efficientek.com, jejb@linux.ibm.com, mchang@suse.com Subject: [PATCH 06/14] crytodisk: fix cryptodisk module looking up Date: Wed, 22 Feb 2023 15:00:46 +0800 Message-Id: <20230222070054.5122-7-glin@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230222070054.5122-1-glin@suse.com> References: <20230222070054.5122-1-glin@suse.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: FR3P281CA0185.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::18) To DBBPR04MB6140.eurprd04.prod.outlook.com (2603:10a6:10:c7::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR04MB6140:EE_|DBBPR04MB7980:EE_ X-MS-Office365-Filtering-Correlation-Id: 363fe7c9-1b24-4c66-8e9c-08db14a29fe6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WOq9IhbcJjsEQdkvbuSXWxx6USpao5wM19m70XSSaLspsi2fKgBw2PYVo04cPC3tT4W7/zU5Orp7U08G7xzD/Z/Lx2FnpzEHJ/ylqo0UfVBw1JAriCyGh2L6apdUf4fEwvOIQZZl6PrQENzZJL/sgNIwaYsTDk0Prof2djVFFt/00+fN7wTW7PdXFxtcZXsKAo7ceFAfbkDXyQKy0i1+2BiMX3mnwGKidMKxxYzZ9A4uIDQex/LyFCogDpznOyYq6GfwtRjym9LqHqjy43Ixo+57evKOpcN2mLlDVz6C+PzCvovNbmv8cIw7wF1rLlqLgL6MkveiY4K3GT6dWJgUXuphtp846BNWyAH01q4pmxb9vLbPimfEZKm9+lGFzF4g1TJx/GswBsbz4xpG5fed511rfW2OOQMO/wpENvGqAg3ip/ri3WWCQxAEmZjWtV4KzrECNisZVdZo1qqmJbNztFJGtZz+/XU1GXnaD7I6m1qytcL9S9jyPOumuKBFNOFLxx8cSXqisg3Zd3lv1rKQBeFcqTJvKyp4g2jH/gtG58d7gycqmbb74+OE7Ppxovr4J4BUr+ijfuXiTQH8bA5Ry0TVFBNhSzS6JFZGVcb+n2OZzrH4be6lCoqflAX0a02Kw8fMCACdVVPr4oLBQT01bQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR04MB6140.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(396003)(346002)(366004)(39860400002)(136003)(451199018)(316002)(54906003)(478600001)(38100700002)(36756003)(2906002)(4744005)(86362001)(66946007)(66556008)(66476007)(6916009)(4326008)(8676002)(41300700001)(8936002)(5660300002)(7416002)(2616005)(6486002)(26005)(186003)(6512007)(6506007)(1076003)(107886003)(6666004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?srNApNXTrsB5eIkJOTN61/WaNOnzMykP3vBeitMBEi5CiWCDUiOeNB5yEfm9?= =?us-ascii?Q?YBcQ9T2GoWC+sy8glqb6EttWZQI/rLKx3V6sogMvVnVTROgcePYGdfuvfe7R?= =?us-ascii?Q?DrLB1lhwRSbT/iZU7f2lnXkdOmSAdF2vaow4a9s9Q3qVZBW+cRSpCpeskJRg?= =?us-ascii?Q?O5Bh6L0GsUVpJjA8l6TzvnB/+Yk6kPl/EdFRceQyvPqbVxJWvu2s+AN1Iy3W?= =?us-ascii?Q?jGpsALA3w3bKQevs/EZ1d1hkVbd0E0s+KGov/e/7qRIm/EMLMnuJ25uJaoAJ?= =?us-ascii?Q?1i6MVpI5XBmqkPTXPbHnPRG6kY5cc1keUH5+5jzR/5qnSRHImocZXAAR85At?= =?us-ascii?Q?hPdJvLoz6uOv31XC8sZZ3z6zrCDoCJi0DLLOVCEJub6E9J3b+doL30lovWOd?= =?us-ascii?Q?lqI96ugRnGjvUOC4FEhZ3oxPGqkAyR79CDpmu6LaMUPmRYf2O5HmZ3MAIL0h?= =?us-ascii?Q?NIHHVPN9mRAw6Jle8VfTzwzKrUREmjSVL1CXOjyA06eNC+ejOTv5jVPLd9Y6?= =?us-ascii?Q?jwEQFSRDEP/lkGUaZSNMKl5yTA2HQEeVbj67sg9WypJWiVafZSZFKApAmhtX?= =?us-ascii?Q?MDLIYGOAEYFDR6Tr2sDvIItxmDcnQXuh86onYM5gpWIQtr/tUdXSAKKO/xmV?= =?us-ascii?Q?pQVud/Lkh4DdUyFIxw5B0LyJqefD3V31D+31Imc5WR7gNaV9HEo7xqoXgNkA?= =?us-ascii?Q?DlQjOxRrXFEc37YKAD9/QIC+RjZHC10EDb2hIrG6/c6RFNuCKkyE/qu5b15K?= =?us-ascii?Q?9c8nN+MH74JEj9TKVo4K8XUGO5RIut3/l/Qo0WdM8ujpxI1JjtOT599ac5M1?= =?us-ascii?Q?MkjeEF0Fk3S+w4xNsxTL+cXGgvdPkx63K3aCgWhF+BvMqnuXMDQjTPm3Lwms?= =?us-ascii?Q?/797azqbTqNxSf0xjySmDWf+vhxy88hX2l4V02U3y/ut6iMHOIQOQ39qfcAt?= =?us-ascii?Q?vBygkRf//2T0SGIiNNWmUeNeEq9ZYM2gY+IWGSLG8DNfJ+DC9QFIWCgm3bQb?= =?us-ascii?Q?w/xST1f9hvHvG8/p4P4vX7TVEM6ZRfUUpRm5Lh8ME2zBZLKz97zNWDnNfdIr?= =?us-ascii?Q?DnLY9a50zeNe4VJt8ciMaZbUn1MaRpdrkceYcbx0TooZH6yIm4sqCt9wB61E?= =?us-ascii?Q?gmQBvqh/j+VFfsNn53TrdIb+NixWwnq7LDBZF1DJN66kXj/5JzgYlH1IhW7G?= =?us-ascii?Q?DMftZ1HtiNRG9QgHSV6zet3hXRefEbtszy1Ggn7N4pM5zsfEOZ/YGVYpn+u7?= =?us-ascii?Q?E0WDvkwwphfAwwgHsinekJtcWRHtugHVNcldNUmV+hHa09irimDEbOVl07ue?= =?us-ascii?Q?7dpVXIqqonLw+rPaM1XhHcA7PmQEHVGGqmB22sQbFbfqit14ZfgmjnZlKF73?= =?us-ascii?Q?+HweTqX9v5pBudAMNED+GMPgm2isPil8Mc97rnQSCW3fKW+voa42buzks+nQ?= =?us-ascii?Q?hsuxyMk9bMAMQOBdYiQwpAsboVNSNpXQWYGNiSOMAhD5Nh9Y66TSdcBt5q23?= =?us-ascii?Q?cVO0GNDtkaJrBnpJUXENAYaLfyWoptSAPMHQzoX/6KyzzuQ92TomVg+3VnLH?= =?us-ascii?Q?KgrHgQSkV+PKnv39OByyYsZOYVPj2LqJPrGClaGo?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 363fe7c9-1b24-4c66-8e9c-08db14a29fe6 X-MS-Exchange-CrossTenant-AuthSource: DBBPR04MB6140.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 07:01:30.5970 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2p5eK76tPDA6Swqp2VP/EXEneAWQVXkyjCjauXrOM+YaYMshFZn9tFhRp0FJ8J7c X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7980 Received-SPF: pass client-ip=40.107.22.57; envelope-from=GLin@suse.com; helo=EUR05-AM6-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Feb 2023 07:02:03 -0000 From: Michael Chang The error "no cryptodisk module can handle this device" may happen even encrypted disk were correctly formatted and required modules were loaded. It is casued by missing break to the loop in which cryptodisk modules are iterated to find the one matching target's disk format. With the break statement, the loop will be always ended with testing last cryptodisk module on the list that may not be able to handle the format of encrypted disk's. Signed-off-by: Michael Chang --- grub-core/disk/cryptodisk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c index c990d5985..e199f550f 100644 --- a/grub-core/disk/cryptodisk.c +++ b/grub-core/disk/cryptodisk.c @@ -1119,6 +1119,7 @@ grub_cryptodisk_scan_device_real (const char *name, if (!dev) continue; crd = cr; + break; } if (!dev) -- 2.35.3