Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pUj8r-0006xA-W5 for mharc-grub-devel@gnu.org; Wed, 22 Feb 2023 02:02:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUj8c-0006tP-DI for grub-devel@gnu.org; Wed, 22 Feb 2023 02:02:02 -0500 Received: from mail-am6eur05on2057.outbound.protection.outlook.com ([40.107.22.57] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUj8a-0006lx-Op for grub-devel@gnu.org; Wed, 22 Feb 2023 02:02:02 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DE00sPZaBcjNM/21FDJ/4TLruwXBVLItY2iyhpZUg3UvuQPxJRJqM0Oi1d5xTSXfUoF2koBzeiR+CsEWykSOCuMhOuE4jcAT9j8CAETjsC4Hv4wpSdyFTF0FFKQwg8Jbm943XFgH2W0d/oLKWf/HcJs71Nj4ixXSULQwEGfuuCjXTNuBjcFaKarF10Qvru3oWooUndSWM4PQd2CTE0Qw73XwFiGUsCOTNuxZAMU0oegj7i7RjOfzSYJNZsinYywsajvI6X4qk/kiIGLArdnHYYqHt2gHi8P1ueYMNOduKIJgMKNM9+GJMMBZI67Y7EA8AJ5JVVb9ylX6yL04jzM1Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xwUuNcUegoOwddgz0EX4VToWNsergpcJ5XxWkIli34k=; b=X013iwBQwJ47xS6EiMzjvqlGFiWma0Ob5PEMPPMfTdlXwRF3mDaLyAi5hzRtNj7XO32rv6y1fMNeaA4X7d5ty/nLWlzcoCdaHgNYMutcQkAnF94v6vrvI/jmNwGR5jtGUEyxyCmNwdUr2aqLAFb0sgpyOqDskaq+eHyXzPiirpBuH8PupMo6Ipng7cNoAHCXCTXTYB3k9B+I3goSdGLsdqfOmjGTo/vPP1Uw1u5smpKMeebcGouEtZJMLPuiGmhz+UIHckmjQ7/SQ7ktpUrFA1T+W/jmrqDC6clVHbGimjd0KlKC2wLSISMCTf0Bt3GSPQdNDhwuNv1NcAkrgAkG2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xwUuNcUegoOwddgz0EX4VToWNsergpcJ5XxWkIli34k=; b=FE5kZ3QFbE6KNCsjfX3ZZ6KRr8gvIgQCfZNzhoCM1RRePJvmtvo81pQDJT67O3Gcpl2wGi+2l/auUg2C3jnlWy6/LHtPoIxrjhKsXGVJJZOH5k+0fhDYh93n5I4vpVKNZIIWidlCbaMRDTnlNP5W8D24nCDjmt9fux3Zib70V7IzgWRZssRYqA73I7EhcwTbicUUvqYY1ockDR4WziwpTotZHetMVzqL+GFG8D1NbE/pgvgaQ940EXgmbYumLx0VKfhdapLuHYF7ZeKzin4RSERZM8E8rQ2IqhiovmCWyV6Um6tFMRqQF20hCcjNuJ0ASZ7WNhQMJ/Rwtq3GdfJxwQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DBBPR04MB6140.eurprd04.prod.outlook.com (2603:10a6:10:c7::18) by DBBPR04MB7980.eurprd04.prod.outlook.com (2603:10a6:10:1f0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Wed, 22 Feb 2023 07:01:35 +0000 Received: from DBBPR04MB6140.eurprd04.prod.outlook.com ([fe80::688f:bc10:59e2:772a]) by DBBPR04MB6140.eurprd04.prod.outlook.com ([fe80::688f:bc10:59e2:772a%6]) with mapi id 15.20.6111.021; Wed, 22 Feb 2023 07:01:35 +0000 From: Gary Lin To: grub-devel@gnu.org Cc: 'Hernan Gatta ' , 'Daniel Kiper ' , shkhisti@microsoft.com, jaskaran.khurana@microsoft.com, christopher.co@microsoft.com, daniel.mihai@microsoft.com, rharwood@redhat.com, jaredz@redhat.com, development@efficientek.com, jejb@linux.ibm.com, mchang@suse.com Subject: [PATCH 07/14] tpm2: Don't measure the sealed key Date: Wed, 22 Feb 2023 15:00:47 +0800 Message-Id: <20230222070054.5122-8-glin@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230222070054.5122-1-glin@suse.com> References: <20230222070054.5122-1-glin@suse.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: FR3P281CA0190.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::8) To DBBPR04MB6140.eurprd04.prod.outlook.com (2603:10a6:10:c7::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR04MB6140:EE_|DBBPR04MB7980:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d6c84e2-0ce9-45bf-21f6-08db14a2a2f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5Jl0KpGxdlUvDqRSReJTdCh0tqx3U/keym7HR6J/8tLz/srbSLDk1FXgc0BTuwpEWF+TkVDnI4skaHwbE5xg++9CXixs3PA8VnktypPtFrjjeWIvNhqwlVL31ohO4oTGY9l5fkbXvrjx8BDyKYTk5NZ/lgaoivCYo33MKCmzmS3pH9OJn6H4YRTcgTh4cFML+LdczRidVMpo6NhIc1HM8Cu91pTayfVIC1Xs4+h8D+Gf2ZooHMOBGIpe5XTOjQdAxvvlAfdPU0nXlgSkohlTf5e1MS0JjxHT8BBJ0IWw1WvSc0dsI92EEDXdl7PT4Q1GZI14oI1Af9Wh1Je35hTPakKO6dCU0EUugsyAHmlPUmADsIuNkWr81i2s96D1236Ehoii5vrp5sXvpZ/s7Sd88T2KHJYSUMZG5d8G9TGbD3+IT7K+O8GvetgWO5YBdR02ALyxyh6ClejBJx+D+0Zm2AKlw4emKWNnLFMEmIyf0JPG7W/ao9cuafxI1lr6Pamepsqio99VmXyRs4ZPGiuSM1nlo9V2pB0ZLR3b9kIlj0VzUWUvDC05WIhY5P5skztJjtiNP6s4xf8Sjvjl917XYv3nAOQTkhKne7zSksalE5QNrF7B8zRuYqBVu0AMlwqQjhfGNfTFhCqqI45dsY+blQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR04MB6140.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(396003)(346002)(366004)(39860400002)(136003)(451199018)(316002)(83380400001)(54906003)(478600001)(38100700002)(36756003)(2906002)(86362001)(66946007)(66556008)(66476007)(6916009)(4326008)(8676002)(41300700001)(8936002)(5660300002)(7416002)(2616005)(6486002)(26005)(186003)(6512007)(6506007)(1076003)(107886003)(6666004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hC0hJLWTV48ASEopY7CclYhj3La65vivm/Hnqc2f8ySclF9vcuYZc4rgqZvj?= =?us-ascii?Q?HhnWEVof595y2W13mcRoIp6zETMbpq1aFFqFEcm6Euk+vfVyH65OY7VZNdy3?= =?us-ascii?Q?bhYBwwNnVHeG5PfK8W2p9qDncJc3xC+6uR4J+UGqrMdHN9S8an1niKfm31Qh?= =?us-ascii?Q?oUa3pKpRZ9j0XSPpfedvGXpmLk8qu1nWBtgwiviHZ8DKbFOVpyMz0xMxpSGl?= =?us-ascii?Q?zRDxxnYXDa6FPddi+yhbndcGOjwpxmau1uwSpeWWOi6agZM6YBMl41rLWodF?= =?us-ascii?Q?AF1T6+nV+ICe6lbGngmVqlOiw0dR0ePS9EAQZmU4jl8NFmioYNMjL6JxZ/Q3?= =?us-ascii?Q?XA7cis67PVr7l9GCz2xk/tmSx+8T8j+ton/fz/1nmUVyPmo8Drsq6fSGp9+9?= =?us-ascii?Q?7P3EDBdnMZyVi8ZWzd+u0eRUmsd7eHeDXd66WYNZlCBXGWUxhp6j9TXJucIO?= =?us-ascii?Q?fZNYmQ+4w+yH9lL/FdZhgxBy3G1ggWEM60Rkpv/ClWQpR3kcigQt+ur4SyyI?= =?us-ascii?Q?XMqqnV3MSxGERZGkqrQ+WOYO+ohZ9ctJSAAbmJiVqoy5V7cw2Hw0vpVXIeoQ?= =?us-ascii?Q?tN0ZIYqeLXW9v52fR9nWlFBrSsfKURF5ctAmCIPDWLQfkmafynEFLacLAhdj?= =?us-ascii?Q?DZSNYqfqJkq4TL4mLTannJAolhhtOQRjKxmbFfa5lonnyYfBFYmv9a4dR9tm?= =?us-ascii?Q?R20wHS/U8cEpA0GJnrWLMr7QZ+SENH8wDhDGwWT33CwBLBlX2vdfxT5XKYSs?= =?us-ascii?Q?SuXjdn7H6M35oI2T2ah2McJbZp8H+iWdRsVr3b52JuzeT1z2FgSca+4HD5lc?= =?us-ascii?Q?yOlCrNbTdM7uW2CNnNfunUPSbS8P1TpE8dQ/IwYYUav5TOWuZ0a3pqtb44vR?= =?us-ascii?Q?HBmRtTfn8QEK6fRk20JY2B9Db5efwiIj+fmCksY3Zbz0RUICUO2oqlZMJ6jC?= =?us-ascii?Q?9TBIKW+Z4OnvO/eLnOKnIT7ZpYvfb/m1g1TE48uo7Q4nozsFG6LVMyILmAXb?= =?us-ascii?Q?LdrcN6rmsukEOKg3QxBzhylyzG24w9RmhxcU52OeYfpkNYetrPjZfmTA0qBO?= =?us-ascii?Q?Tt/A8aR333oNJORjKH28cSSxpdGngZv0UtGKhZB9K+2OaBUq/Uwshn3uVs9Q?= =?us-ascii?Q?H1JSKtDhgFCq/IxM+jbTIbS3LNecXJ/uPpw1EBTsShRnZe+76RprlSYofeGy?= =?us-ascii?Q?W5MUv2UvVHvdQpB7akLun8hMNdUagc4Sl4WrjftaexgPiR82i7Vrm7rYcQi8?= =?us-ascii?Q?JM1Y+uI9rSe/U6xCKi/37sw3DCQUgtDUFEY49J9pFD4IjDHP8NXh5PRaUTL1?= =?us-ascii?Q?xSp3LPCNjUtVuZk0y15CJH4EDqC1Zcoe8VTkkP+f8LOa8m6oSUVtj4R1TXyd?= =?us-ascii?Q?USRfE7DyWrvUWICfZ8IEfvRBeuVmNlEtneG3FpkLWp2tH5AGWVQnzmOnkSf0?= =?us-ascii?Q?nmDuf1/Qah5b/InStwvcGXFWqQ8st0G+W6F/8LM3XqOW/dElNG7I/ipKQ7Cm?= =?us-ascii?Q?6b8iq81iW9E0ANEIkNdYunFJXg90/Q4bkX0RLaa9YMexcBohUFyycUQzTFp/?= =?us-ascii?Q?lbjxny+MM6YMMbhxhLvjOZhZgreCjBgrOd4Dcs9L?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d6c84e2-0ce9-45bf-21f6-08db14a2a2f2 X-MS-Exchange-CrossTenant-AuthSource: DBBPR04MB6140.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 07:01:35.7841 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fZw7yTT4x4getuVD52Bl/LO4xq8Rh8RcN8rg8kdKJLWuBHRrtva/m2R7o3YcQegu X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7980 Received-SPF: pass client-ip=40.107.22.57; envelope-from=GLin@suse.com; helo=EUR05-AM6-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Feb 2023 07:02:03 -0000 Based on the patch from Olaf Kirch The sealed key is the subject to change and measuring the file into PCR9 makes the prediction of PCR9 value impossible. This commit opens the file with GRUB_FILE_TYPE_SIGNATURE to avoid the measurement. Signed-off-by: Gary Lin --- grub-core/tpm2/module.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/grub-core/tpm2/module.c b/grub-core/tpm2/module.c index c35bfabdb..bebdecd1c 100644 --- a/grub-core/tpm2/module.c +++ b/grub-core/tpm2/module.c @@ -139,7 +139,9 @@ grub_tpm2_protector_srk_read_keyfile (const char *filepath, void **buffer, void *sealed_key_buffer; grub_off_t sealed_key_read; - sealed_key_file = grub_file_open (filepath, GRUB_FILE_TYPE_NONE); + /* Using GRUB_FILE_TYPE_SIGNATURE ensures we do not hash the keyfile into PCR9 + * otherwise we'll never be able to predict the value of PCR9 at unseal time */ + sealed_key_file = grub_file_open (filepath, GRUB_FILE_TYPE_SIGNATURE); if (!sealed_key_file) { grub_dprintf ("tpm2", "Could not open sealed key file.\n"); -- 2.35.3