Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A96BC6FD19 for ; Thu, 16 Mar 2023 17:37:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229599AbjCPRhw (ORCPT ); Thu, 16 Mar 2023 13:37:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229852AbjCPRht (ORCPT ); Thu, 16 Mar 2023 13:37:49 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20160D588C for ; Thu, 16 Mar 2023 10:37:44 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B8B1B1FDB0; Thu, 16 Mar 2023 17:37:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1678988262; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YPB4Rj1ncr3qPvCdDJ54dmAtBv2DxMxCFFqcuhWPUsM=; b=gFabpDSiJAywZWpDiWE+ED4J+ZDLAmraz6yWFaCy4JS42fXCFWn8Fn7ld2vLqL7epuUhXB 13cbFHuEyGiwNp4EpQ5qKaUzrfyaDHp9ijx8y+r4M/v2sLWlU43Vg/klQpnQMyMo2BzW7o /XA2ndYZw9x1wmj6NCxMUA+Dp86ppsk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1678988262; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YPB4Rj1ncr3qPvCdDJ54dmAtBv2DxMxCFFqcuhWPUsM=; b=VjBZg+j9vuSz+VKdUU9jZ5JdbgsUBmqFfAd8jqxwjIaBV/8V4RyM1fVbSLhW75gsiH43Ul CwJyDrgHo2mj3+Dg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 81F2B13A2F; Thu, 16 Mar 2023 17:37:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Ais4HuZTE2QYTAAAMHmgww (envelope-from ); Thu, 16 Mar 2023 17:37:42 +0000 Date: Thu, 16 Mar 2023 18:31:34 +0100 From: David Sterba To: Christoph Hellwig Cc: Chris Mason , Josef Bacik , David Sterba , Johannes Thumshirn , linux-btrfs@vger.kernel.org Subject: Re: [PATCH 01/10] btrfs: use a plain workqueue for ordered_extent processing Message-ID: <20230316173134.GC10580@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <20230314165910.373347-1-hch@lst.de> <20230314165910.373347-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230314165910.373347-2-hch@lst.de> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Mar 14, 2023 at 05:59:01PM +0100, Christoph Hellwig wrote: > --- a/fs/btrfs/super.c > +++ b/fs/btrfs/super.c > @@ -1632,8 +1632,6 @@ static void btrfs_resize_thread_pool(struct btrfs_fs_info *fs_info, > btrfs_workqueue_set_max(fs_info->hipri_workers, new_pool_size); > btrfs_workqueue_set_max(fs_info->delalloc_workers, new_pool_size); > btrfs_workqueue_set_max(fs_info->caching_workers, new_pool_size); > - btrfs_workqueue_set_max(fs_info->endio_write_workers, new_pool_size); > - btrfs_workqueue_set_max(fs_info->endio_freespace_worker, new_pool_size); I haven't noticed in the past workque patches but here we lose the connection of mount option thread_pool and max_active per workqueue.